New issue
Advanced search Search tips

Issue 876629 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Ejecting CD/DVD only physically ejects the disk once.

Project Member Reported by amistry@chromium.org, Aug 22

Issue description

Chrome Version: 70
OS: Chrome

What steps will reproduce the problem?
1. Plug in external CD/DVD drive.
2. Insert disk.
3. Eject disk by clicking the eject button in the file manager.
4. Wait for disk to be ejected, and re-insert.
5. Click eject again.

What is the expected result?
Disk should be ejected.

What happens instead?
Disk is unmounted from the Files app, but disk isn't ejected.

Bug is obvious, CL on the way. I filed this issue to keep track of it.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/57340373c068e8d786c4949796d7b1478f329091

commit 57340373c068e8d786c4949796d7b1478f329091
Author: Anand K Mistry <amistry@chromium.org>
Date: Thu Aug 30 04:05:48 2018

cros-disks: Fix waiting for eject process to finish.

The process needs to be started before we can have its pid.

BUG= chromium:876629 
TEST=platform_CrosDisks* + manually on chell

Change-Id: Iade7af3bdabb9c3e1292d94eba392c7bbe76111e
Reviewed-on: https://chromium-review.googlesource.com/1184652
Commit-Ready: Anand Mistry <amistry@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>

[modify] https://crrev.com/57340373c068e8d786c4949796d7b1478f329091/cros-disks/device_ejector.cc

Status: Fixed (was: Assigned)

Sign in to add a comment