New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 876606 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Refactor ChromeComponentExtensionResourceManagerTest.IsComponentExtensionResource not to depend on real file_manager data

Project Member Reported by alexlau@chromium.org, Aug 22

Issue description

The unit test uses a test manifest but real file_manager grit resources for testing. It also requires that the relative path of the file_manager icon to match what is defined in the test_manifest (currently common/images/icon16.png) else IsComponentExtensionResource is unable find the resource id in its map.

Refactor the unit test not to depend on real file_manager grit resources.

https://codesearch.chromium.org/chromium/src/chrome/browser/extensions/chrome_component_extension_resource_manager_unittest.cc?rcl=bbc810df20d5b70e320c6ae5be761f9e97f89f6c&l=71

 
Wasn't sure which component the specific unit test belongs to, please change if necessary.

Labels: CrOSFilesCategory-Testing
Status: Assigned (was: Untriaged)
Owner: ----
Status: Available (was: Assigned)

Sign in to add a comment