cbuildbot config use goma_client_type instead of cbb_goma_canary |
||
Issue descriptionCurrently we use the flag "cbb_goma_canary". However, when we need to have a builder that tries yet another cipd package ref, it is difficult for us to make it choose the ref. Let me replace the flag with "cbb_goma_client_type".
,
Aug 27
As far as I know, due to crbug.com/876225, cbb_goma_canary flag seems not be set. That is why it is fine to submit #1. To fix this issue, two things remained. 1. update chromite to make cbb_goma_client_type supported. blocked by https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1180509 2. update luci-scheduler.cfg using the chromite updated in 1.
,
Sep 26
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/16285b48a4d5cc5c467bb59809db939abef8910f commit 16285b48a4d5cc5c467bb59809db939abef8910f Author: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Date: Wed Sep 26 03:40:55 2018 support cbb_goma_client_type. To make builders use arbitrary cipd ref of goma client package, we need to make cbb_goma_client_type supported. We may use "candidate" to specify the release candidate, and "latest" to specify the latest goma client. Bug: chromium:876585 , chromium:876225 Change-Id: I57be8633d4727aee6645c57338be6e44d569f531 Reviewed-on: https://chromium-review.googlesource.com/1188202 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/16285b48a4d5cc5c467bb59809db939abef8910f/config/chromeos_config.py [modify] https://crrev.com/16285b48a4d5cc5c467bb59809db939abef8910f/lib/request_build.py [modify] https://crrev.com/16285b48a4d5cc5c467bb59809db939abef8910f/scripts/gen_luci_scheduler_unittest.py [modify] https://crrev.com/16285b48a4d5cc5c467bb59809db939abef8910f/scripts/gen_luci_scheduler.py [modify] https://crrev.com/16285b48a4d5cc5c467bb59809db939abef8910f/config/config_dump.json [modify] https://crrev.com/16285b48a4d5cc5c467bb59809db939abef8910f/lib/config_lib.py [modify] https://crrev.com/16285b48a4d5cc5c467bb59809db939abef8910f/config/luci-scheduler.cfg
,
Oct 5
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Aug 27