New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 876581 link

Starred by 2 users
Status: Fixed
Owner:
alph@chromium.org
Closed: Oct 10
Cc:
erikc...@chromium.org
█ picksi@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature
Hotlist-MemoryInfra



Sign in to add a comment

Make use of base::SamplingHeapProfiler for memlog heap profiling

Project Member Reported by alph@chromium.org, Aug 22 
base::SHP has a minimal overhead ~1% for 128K sampling rate.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77953ee8335b197e2e7a02b8f28aaedf714bc193

commit 77953ee8335b197e2e7a02b8f28aaedf714bc193
Author: Alexei Filippov <alph@chromium.org>
Date: Sun Aug 26 00:55:29 2018

Use SamplingHeapProfiler for memlog sampling mode.

The patch makes OOPHP use base::SamplingHeapProfiler in the
sampling mode.

BUG= 876581 

Change-Id: I179dbc9a40127a3fe9370c9ed0222ee45fc0556d
Reviewed-on: https://chromium-review.googlesource.com/1184229
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586158}
[modify] https://crrev.com/77953ee8335b197e2e7a02b8f28aaedf714bc193/base/sampling_heap_profiler/sampling_heap_profiler.cc
[modify] https://crrev.com/77953ee8335b197e2e7a02b8f28aaedf714bc193/components/heap_profiling/test_driver.cc
[modify] https://crrev.com/77953ee8335b197e2e7a02b8f28aaedf714bc193/components/services/heap_profiling/public/cpp/BUILD.gn
[modify] https://crrev.com/77953ee8335b197e2e7a02b8f28aaedf714bc193/components/services/heap_profiling/public/cpp/allocator_shim.cc
[modify] https://crrev.com/77953ee8335b197e2e7a02b8f28aaedf714bc193/components/services/heap_profiling/public/cpp/allocator_shim.h
[modify] https://crrev.com/77953ee8335b197e2e7a02b8f28aaedf714bc193/components/services/heap_profiling/public/cpp/client.cc
[modify] https://crrev.com/77953ee8335b197e2e7a02b8f28aaedf714bc193/components/services/heap_profiling/public/cpp/client.h
[add] https://crrev.com/77953ee8335b197e2e7a02b8f28aaedf714bc193/components/services/heap_profiling/public/cpp/sampling_profiler_wrapper.cc
[add] https://crrev.com/77953ee8335b197e2e7a02b8f28aaedf714bc193/components/services/heap_profiling/public/cpp/sampling_profiler_wrapper.h
[modify] https://crrev.com/77953ee8335b197e2e7a02b8f28aaedf714bc193/components/services/heap_profiling/public/cpp/settings.cc
[modify] https://crrev.com/77953ee8335b197e2e7a02b8f28aaedf714bc193/components/services/heap_profiling/public/cpp/settings.h
[modify] https://crrev.com/77953ee8335b197e2e7a02b8f28aaedf714bc193/components/services/heap_profiling/public/cpp/stream.h

Comment 2 by alph@chromium.org, Oct 10

Status: Fixed (was: Assigned)
►

Sign in to add a comment