Issue 876568 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	eroman@chromium.org
Closed:	Sep 4
Components:	Internals>Network>Proxy Internals>Services>Network
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Bug
Hotlist-KnownIssue
Proj-Servicification

Hook up OnProxyError() for network service

Project Member Reported by eroman@chromium.org, Aug 22

Issue description

The failing test:
   ProxySettingsApiTest.ProxyEventsInvalidProxy

is because extensions::ProxyEventRouter::OnProxyError() is not called when the network service is enabled.

In the non-network service case, ChromeNetworkDelegate forwards OnResponseStarted to ChromeExtensionsNetworkDelegate, which identifies proxy errors, and sends an event to any listeners that registered with chrome.proxy.onProxyError.addListener.

The other notifier for onProxyError is PAC script errors ( Issue 851609 ).

Project Member

Comment 1 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec799b97b5698c76ed76a8630fac96604069f1f1

commit ec799b97b5698c76ed76a8630fac96604069f1f1
Author: Eric Roman <eroman@chromium.org>
Date: Wed Aug 22 19:29:09 2018

Annotate reason for failing test ProxySettingsApiTest.ProxyEventsInvalidProxy.

Bug:  876568 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I30ca8030e94f34245d4d53dfc25a463d66bca00e
Reviewed-on: https://chromium-review.googlesource.com/1185462
Reviewed-by: Matt Mueller <mattm@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585198}
[modify] https://crrev.com/ec799b97b5698c76ed76a8630fac96604069f1f1/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Comment 2 by dxie@google.com, Aug 24

Labels: Hotlist-KnownIssue

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d576f34af2134e4205788845247d5d52063fee1f

commit d576f34af2134e4205788845247d5d52063fee1f
Author: Eric Roman <eroman@chromium.org>
Date: Thu Aug 30 22:31:19 2018

Make chrome.proxy.onProxyError extension API work under the Network Service.

This adds an optional "ProxyErrorClient" client to the NetworkContext which
receives notifications of errors in the PAC script, as well as notifications
of failed URL loads that may have been proxy related.

Bug:  876568 , 851609 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I645ef91875135fcc81a7bd113442a0b65c661e65
Reviewed-on: https://chromium-review.googlesource.com/1192123
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587812}
[modify] https://crrev.com/d576f34af2134e4205788845247d5d52063fee1f/chrome/browser/net/chrome_extensions_network_delegate.cc
[modify] https://crrev.com/d576f34af2134e4205788845247d5d52063fee1f/chrome/browser/net/chrome_extensions_network_delegate.h
[modify] https://crrev.com/d576f34af2134e4205788845247d5d52063fee1f/chrome/browser/net/chrome_network_delegate.cc
[modify] https://crrev.com/d576f34af2134e4205788845247d5d52063fee1f/chrome/browser/net/chrome_network_delegate.h
[modify] https://crrev.com/d576f34af2134e4205788845247d5d52063fee1f/chrome/browser/net/proxy_config_monitor.cc
[modify] https://crrev.com/d576f34af2134e4205788845247d5d52063fee1f/chrome/browser/net/proxy_config_monitor.h
[modify] https://crrev.com/d576f34af2134e4205788845247d5d52063fee1f/net/base/layered_network_delegate.cc
[modify] https://crrev.com/d576f34af2134e4205788845247d5d52063fee1f/net/base/layered_network_delegate.h
[modify] https://crrev.com/d576f34af2134e4205788845247d5d52063fee1f/net/base/layered_network_delegate_unittest.cc
[modify] https://crrev.com/d576f34af2134e4205788845247d5d52063fee1f/services/network/network_context.cc
[modify] https://crrev.com/d576f34af2134e4205788845247d5d52063fee1f/services/network/network_context_unittest.cc
[modify] https://crrev.com/d576f34af2134e4205788845247d5d52063fee1f/services/network/public/mojom/network_context.mojom
[modify] https://crrev.com/d576f34af2134e4205788845247d5d52063fee1f/services/network/public/mojom/proxy_config_with_annotation.mojom
[modify] https://crrev.com/d576f34af2134e4205788845247d5d52063fee1f/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Comment 4 by eroman@chromium.org, Aug 30

Status: Fixed (was: Assigned)

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8ae9cb3ceebc17db40280a83c5599a2a27bc739

commit b8ae9cb3ceebc17db40280a83c5599a2a27bc739
Author: Jan Wilken Dörrie <jdoerrie@chromium.org>
Date: Fri Aug 31 08:10:59 2018

Revert "Make chrome.proxy.onProxyError extension API work under the Network Service."

This reverts commit d576f34af2134e4205788845247d5d52063fee1f.

Reason for revert: Likely culprit of  https://crbug.com/879491 .

Original change's description:
> Make chrome.proxy.onProxyError extension API work under the Network Service.
> 
> This adds an optional "ProxyErrorClient" client to the NetworkContext which
> receives notifications of errors in the PAC script, as well as notifications
> of failed URL loads that may have been proxy related.
> 
> Bug:  876568 , 851609 
> Cq-Include-Trybots: luci.chromium.try:linux_mojo
> Change-Id: I645ef91875135fcc81a7bd113442a0b65c661e65
> Reviewed-on: https://chromium-review.googlesource.com/1192123
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Reviewed-by: Will Harris <wfh@chromium.org>
> Commit-Queue: Eric Roman <eroman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#587812}

TBR=eroman@chromium.org,mmenke@chromium.org,wfh@chromium.org

Change-Id: I286c7f768b04b6e47f1836abc459a33c7b394498
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  876568 ,  851609 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1199043
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587966}
[modify] https://crrev.com/b8ae9cb3ceebc17db40280a83c5599a2a27bc739/chrome/browser/net/chrome_extensions_network_delegate.cc
[modify] https://crrev.com/b8ae9cb3ceebc17db40280a83c5599a2a27bc739/chrome/browser/net/chrome_extensions_network_delegate.h
[modify] https://crrev.com/b8ae9cb3ceebc17db40280a83c5599a2a27bc739/chrome/browser/net/chrome_network_delegate.cc
[modify] https://crrev.com/b8ae9cb3ceebc17db40280a83c5599a2a27bc739/chrome/browser/net/chrome_network_delegate.h
[modify] https://crrev.com/b8ae9cb3ceebc17db40280a83c5599a2a27bc739/chrome/browser/net/proxy_config_monitor.cc
[modify] https://crrev.com/b8ae9cb3ceebc17db40280a83c5599a2a27bc739/chrome/browser/net/proxy_config_monitor.h
[modify] https://crrev.com/b8ae9cb3ceebc17db40280a83c5599a2a27bc739/net/base/layered_network_delegate.cc
[modify] https://crrev.com/b8ae9cb3ceebc17db40280a83c5599a2a27bc739/net/base/layered_network_delegate.h
[modify] https://crrev.com/b8ae9cb3ceebc17db40280a83c5599a2a27bc739/net/base/layered_network_delegate_unittest.cc
[modify] https://crrev.com/b8ae9cb3ceebc17db40280a83c5599a2a27bc739/services/network/network_context.cc
[modify] https://crrev.com/b8ae9cb3ceebc17db40280a83c5599a2a27bc739/services/network/network_context_unittest.cc
[modify] https://crrev.com/b8ae9cb3ceebc17db40280a83c5599a2a27bc739/services/network/public/mojom/network_context.mojom
[modify] https://crrev.com/b8ae9cb3ceebc17db40280a83c5599a2a27bc739/services/network/public/mojom/proxy_config_with_annotation.mojom
[modify] https://crrev.com/b8ae9cb3ceebc17db40280a83c5599a2a27bc739/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Comment 6 by eroman@chromium.org, Aug 31

Status: Assigned (was: Fixed)

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9fb9f49403a9a47597db318cd3646284f71b9d2

commit b9fb9f49403a9a47597db318cd3646284f71b9d2
Author: Eric Roman <eroman@chromium.org>
Date: Sat Sep 01 03:37:46 2018

Make chrome.proxy.onProxyError extension API work under the Network Service.

This adds an optional "ProxyErrorClient" client to the NetworkContext which
receives notifications of errors in the PAC script, as well as notifications
of failed URL loads that may have been proxy related.

(Reland of d576f34af2134e4205788845247d5d52063fee1f).

Bug:  876568 , 851609 , 879491 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I08987d658879913d94c9b13b6fdc1de2a32a6d54
Reviewed-on: https://chromium-review.googlesource.com/1200076
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588259}
[modify] https://crrev.com/b9fb9f49403a9a47597db318cd3646284f71b9d2/chrome/browser/net/chrome_extensions_network_delegate.cc
[modify] https://crrev.com/b9fb9f49403a9a47597db318cd3646284f71b9d2/chrome/browser/net/chrome_extensions_network_delegate.h
[modify] https://crrev.com/b9fb9f49403a9a47597db318cd3646284f71b9d2/chrome/browser/net/chrome_network_delegate.cc
[modify] https://crrev.com/b9fb9f49403a9a47597db318cd3646284f71b9d2/chrome/browser/net/chrome_network_delegate.h
[modify] https://crrev.com/b9fb9f49403a9a47597db318cd3646284f71b9d2/chrome/browser/net/proxy_config_monitor.cc
[modify] https://crrev.com/b9fb9f49403a9a47597db318cd3646284f71b9d2/chrome/browser/net/proxy_config_monitor.h
[modify] https://crrev.com/b9fb9f49403a9a47597db318cd3646284f71b9d2/net/base/layered_network_delegate.cc
[modify] https://crrev.com/b9fb9f49403a9a47597db318cd3646284f71b9d2/net/base/layered_network_delegate.h
[modify] https://crrev.com/b9fb9f49403a9a47597db318cd3646284f71b9d2/net/base/layered_network_delegate_unittest.cc
[modify] https://crrev.com/b9fb9f49403a9a47597db318cd3646284f71b9d2/services/network/network_context.cc
[modify] https://crrev.com/b9fb9f49403a9a47597db318cd3646284f71b9d2/services/network/network_context_unittest.cc
[modify] https://crrev.com/b9fb9f49403a9a47597db318cd3646284f71b9d2/services/network/public/mojom/network_context.mojom
[modify] https://crrev.com/b9fb9f49403a9a47597db318cd3646284f71b9d2/services/network/public/mojom/proxy_config_with_annotation.mojom
[modify] https://crrev.com/b9fb9f49403a9a47597db318cd3646284f71b9d2/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter

Comment 8 by eroman@chromium.org, Sep 4

Status: Fixed (was: Assigned)

►

Issue 876568 link

Issue metadata

Hook up OnProxyError() for network service

Issue description

Comment 1 by bugdroid1@chromium.org, Aug 22

Comment 1 Deleted

Comment 2 by dxie@google.com, Aug 24

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Aug 30

Comment 3 Deleted

Comment 4 by eroman@chromium.org, Aug 30

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Aug 31

Comment 5 Deleted

Comment 6 by eroman@chromium.org, Aug 31

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Sep 1

Comment 7 Deleted

Comment 8 by eroman@chromium.org, Sep 4

Comment 8 Deleted

Sign in to add a comment