Issue metadata
Sign in to add a comment
|
net_unittests failing on chromium.mac/Mac10.10 Tests |
||||||||||||||||||||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of skym@chromium.org net_unittests failing on chromium.mac/Mac10.10 Tests Builders failed on: - Mac10.10 Tests: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests
,
Aug 22
Findit thinks a likely culprit was https://chromium.googlesource.com/chromium/src/+/d184f073fbb8fd0a74862a41943e32ef9b83cb87 , the last 2 runs have failed very similarly, speculativly reverting. +xunjieli@
,
Aug 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1280d17a159c4db866e3ae90a33538a55b58b00d commit 1280d17a159c4db866e3ae90a33538a55b58b00d Author: Sky Malice <skym@chromium.org> Date: Wed Aug 22 00:07:40 2018 Revert "Add NetLog events for cookie blocking by NetworkDelegate" This reverts commit d184f073fbb8fd0a74862a41943e32ef9b83cb87. Reason for revert: Speculative revert to fix net_unittests BUG: 876563 Original change's description: > Add NetLog events for cookie blocking by NetworkDelegate > > Cookies setting and getting can be blocked by a NetworkDelegate. > This CL adds NetLog events so they can aid in the investigation of cookies bugs. > > Bug: 875849 > Change-Id: Ia2a09b443fb1ebfe8ce9dde1617920264f6f24a7 > Reviewed-on: https://chromium-review.googlesource.com/1181244 > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Helen Li <xunjieli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584809} TBR=mmenke@chromium.org,xunjieli@chromium.org Change-Id: Ifbfcf98ec819cda47cb04e4c87e6274db0e93579 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 875849 Reviewed-on: https://chromium-review.googlesource.com/1184274 Reviewed-by: Sky Malice <skym@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#584929} [modify] https://crrev.com/1280d17a159c4db866e3ae90a33538a55b58b00d/net/log/net_log_event_type_list.h [modify] https://crrev.com/1280d17a159c4db866e3ae90a33538a55b58b00d/net/url_request/url_request.cc [modify] https://crrev.com/1280d17a159c4db866e3ae90a33538a55b58b00d/net/url_request/url_request_unittest.cc
,
Aug 22
That CL is completely unrelated to the failing tests - this is a duplicate of issue 847263 .
,
Aug 22
Since https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/34389 net_unittests are no longer failed. Not sure which change fixed this issue or just configuration issue(?) All Changes: Always anchor to bottom. Changed by David Black - dmblack@google.com Changed at 2018-08-22 8:30 AM (JST) Repository https://chromium.googlesource.com/chromium/src Branch Revision 361edc1d47f672969f6d40a8aa473c2a25f95d6e Comments Always anchor to bottom. Per change in product spec, we should no longer anchor to the top of the screen when in tablet mode. We should always anchor to the bottom. Bug: b:112849003 Change-Id: If2ec374fc4ea26377edb2251be5ae445db736c80 Reviewed-on: https://chromium-review.googlesource.com/1182442 Commit-Queue: David Black <dmblack@google.com> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#584922} Changed files ash/assistant/ui/assistant_container_view.cc ash/assistant/ui/assistant_container_view.h ash/assistant/ui/assistant_container_view_unittest.cc Require MacOS 10.13 for 'Mac Builder'. Changed by Roberto Carrillo - robertocn@google.com Changed at 2018-08-22 8:30 AM (JST) Repository https://chromium.googlesource.com/chromium/src Branch Revision 0bd9043c397beefa60c5543874b687a68f607e5b Comments Require MacOS 10.13 for 'Mac Builder'. R=tandrii No-Try: True Bug: 872448 Change-Id: Ia12df35141be3e9073167f24bd70fdf02568c66e Reviewed-on: https://chromium-review.googlesource.com/1184249 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#584921} Changed files infra/config/global/cr-buildbucket.cfg WebUI: Make WebUIDataSourceImpl report the file size properly Changed by Tommy C. Li - tommycli@chromium.org Changed at 2018-08-22 8:23 AM (JST) Repository https://chromium.googlesource.com/chromium/src Branch Revision 1395a2e636b0ae8bf9ef2931b72c0252df9ee08b Comments WebUI: Make WebUIDataSourceImpl report the file size properly Without this CL, video streaming from chrome:// does not work. Now it will work for URLs that use the WebUIDataSourceImpl source. This also extends URLDataSource class in general, so other source subclasses may report content size if they wish. <video> only supports unknown length content with http/https. For these other sources, the resources are assumed to be fully buffered. Bug: 866703 Change-Id: I826b2fa1a732c6f99f37b5df3603658a5b5b8165 Reviewed-on: https://chromium-review.googlesource.com/1173497 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: Rachel Blum <groby@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#584920} Changed files content/browser/webui/url_data_manager_backend.cc Use active window to calculate ax bounds Changed by Yuki Awano - yawano@chromium.org Changed at 2018-08-22 8:05 AM (JST) Repository https://chromium.googlesource.com/chromium/src Branch Revision 8d952da6e3eb1740175450db344a2b1c747ef3cd Comments Use active window to calculate ax bounds - Initially ExoShellSurface has both focus and active state. But when user clicks something on Android window, ExoSurface becomes focused. We need to use ExoShellSurface to get the widget. This CL changes it to use active window instead of focused one. click maximize button. Confirm that Chrome doesn't crash. Bug: 867199 Test: Enable S2S and open Play Store app. Focus on the search box and Change-Id: I74e363e2ee91986966a97a12f7cdb5399721f6cf Reviewed-on: https://chromium-review.googlesource.com/1183046 Reviewed-by: David Tseng <dtseng@chromium.org> Commit-Queue: Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#584919} Changed files chrome/browser/chromeos/arc/accessibility/ax_tree_source_arc.cc Add localization strings for timer notification. Changed by Li Lin - llin@chromium.org Changed at 2018-08-22 8:03 AM (JST) Repository https://chromium.googlesource.com/chromium/src Branch Revision 54d4a765647991019b5f2d56fac74e3e6c24c73e Comments Add localization strings for timer notification. Bug: b:110107505 Change-Id: Ie642268b7bab2abd867bae2d5e1ad85b29459aa2 Reviewed-on: https://chromium-review.googlesource.com/1182667 Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584918} Changed files chrome/app/chromeos_strings.grdp Android OOP-D: DisplayScheduler should only report draw-inducing damage Changed by Eric Karl - ericrk@chromium.org Changed at 2018-08-22 7:59 AM (JST) Repository https://chromium.googlesource.com/chromium/src Branch Revision 60d359fd3bd0bbe1089cf24c196187b3c03fcd65 Comments Android OOP-D: DisplayScheduler should only report draw-inducing damage Currently DisplayScheduler reports damage to SurfaceManager in any case where a damaged surface ID damages the display. While these cases will trigger a draw when visible, they don't necessarily trigger a draw in any defined timeframe. This can lead to issues. Consider: 1) Display 1 is not visible, embeds surface A. 2) Surface A sends CF 1, we don't immediately ack as we will wait for Display 1 to draw. 3) Display 2 becomes visible, embeds surface A with a new surface ID. 4) Display 2 will never update, as no new frames will be produced for surface A as the renderer is continually waiting on the ack for CF 1. By having DisplayScheduler report no damage if invisible, we always ack frames in a timely manner. This may allow a renderer to produce some extra frames when its display is invisible, but this should be limited as the renderer itself receives visibility notifications and won't get additional BeginFrames once visibility is fully processed. Bug: 875895 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I272de950d8e4d4c819c445dc8162ac360afb80a1 Reviewed-on: https://chromium-review.googlesource.com/1182862 Reviewed-by: Fady Samuel <fsamuel@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#584917} Changed files components/viz/service/display/display_scheduler.cc components/viz/service/display/display_scheduler_unittest.cc components/viz/service/surfaces/surface_observer.h Finish conversation starters. Changed by David Black - dmblack@google.com Changed at 2018-08-22 7:56 AM (JST) Repository https://chromium.googlesource.com/chromium/src Branch Revision 02974f882755d857cef268302274e6c7095dce3a Comments Finish conversation starters. This involved: - Limiting conversation starter count to 3. - Shuffling and selecting conversation starters to reach 3. - Refreshing conversation starter cache for new UI sessions. - Center aligning conversation starters (but keeping suggestion chips for interaction responses start aligned). Bug: b:111694337 Change-Id: I1b5b94fabcd0a37ce3a3400a670db4224fc6a667 Reviewed-on: https://chromium-review.googlesource.com/1182863 Commit-Queue: David Black <dmblack@google.com> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#584916} Changed files ash/assistant/assistant_cache_controller.cc ash/assistant/assistant_cache_controller.h ash/assistant/assistant_controller.cc ash/assistant/ui/main_stage/suggestion_container_view.cc ash/assistant/ui/main_stage/suggestion_container_view.h Suppress two layout test failures on 'WebKit Android (Nexus4)'. Changed by Kenneth Russell - kbr@chromium.org Changed at 2018-08-22 7:53 AM (JST) Repository https://chromium.googlesource.com/chromium/src Branch Revision 07d8d2d9a382a0c5a9d851ebe5145dc4512b8612 Comments Suppress two layout test failures on 'WebKit Android (Nexus4)'. external/wpt/web-animations/interfaces/Animatable/animate.html http/tests/worklet/webexposed/ global-interface-listing-paint-worklet.html These are the remaining test failures seen on this bot when running with --use-gpu-in-tests. Unfortunately there doesn't seem to be a way to specialize these for this device. Bug: 875172 Change-Id: I050b131b2702987f2e5803ac6e75ea6dfae35b2b Reviewed-on: https://chromium-review.googlesource.com/1183979 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#584915} Changed files third_party/WebKit/LayoutTests/TestExpectations Suppress webgl-compressed-texture-s3tc flake on Linux Intel. Changed by Kenneth Russell - kbr@chromium.org Changed at 2018-08-22 7:47 AM (JST) Repository https://chromium.googlesource.com/chromium/src Branch Revision 9cbe26531ad64a7fdb332f570ccbf9ae303f838e Comments Suppress webgl-compressed-texture-s3tc flake on Linux Intel. Observed flaky after starting testing on the passthrough command decoder on this configuration. Tbr: geofflang@chromium.org Bug: 872302 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I44700af5fa229f10037435c226f870e306736730 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/1184178 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#584914} Changed files content/test/gpu/gpu_tests/webgl2_conformance_expectations.py Factor out password_prompt_dialog from people_page/ to controls/. Changed by Ryan Hansberry - hansberry@chromium.org Changed at 2018-08-22 7:41 AM (JST) Repository https://chromium.googlesource.com/chromium/src Branch Revision e5e5821f7f34e2acd230b197a6ad206a2d1e1de0 Comments Factor out password_prompt_dialog from people_page/ to controls/. A new people_page/lock_screen_password_prompt_dialog is created that implements lock screen specific logic that previously resided in password_prompt_dialog. Bug: 870122 Change-Id: If1fb68e6b7fd84f91850a169342ab04fb8a75404 Reviewed-on: https://chromium-review.googlesource.com/1179377 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#584913} Changed files chrome/browser/resources/settings/controls/BUILD.gn chrome/browser/resources/settings/controls/password_prompt_dialog.html chrome/browser/resources/settings/controls/password_prompt_dialog.js chrome/browser/resources/settings/people_page/BUILD.gn chrome/browser/resources/settings/people_page/lock_screen.html chrome/browser/resources/settings/people_page/lock_screen.js chrome/browser/resources/settings/people_page/lock_screen_password_prompt_dialog.html chrome/browser/resources/settings/people_page/lock_screen_password_prompt_dialog.js chrome/browser/resources/settings/people_page/password_prompt_dialog.js chrome/browser/resources/settings/settings_resources.grd chrome/test/data/webui/settings/cr_settings_browsertest.js chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js chromeos: Cleanup usage of IsAshInBrowserProcess, part 3 Changed by James Cook - jamescook@chromium.org Changed at 2018-08-22 7:26 AM (JST) Repository https://chromium.googlesource.com/chromium/src Branch Revision 913f1641f753a2a10c0dfc3bbfc0ae345474ef3a Comments chromeos: Cleanup usage of IsAshInBrowserProcess, part 3 We need to distinguish between MultiProcessMash, SingleProcessMash and both (aka IsUsingWindowService). * Power - ML and settings UI * Exo * WebRTC desktop capture * Tabs extension API * Tab dragging * TestBrowserDialog The remaining ones are in browser frame code. Bug: 874468 Change-Id: Iac58a63b518966e781a25a090b58a24b8d2ace95 Reviewed-on: https://chromium-review.googlesource.com/1183790 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#584912} Changed files ash/app_list/app_list_controller_impl.cc chrome/browser/chromeos/power/ml/DEPS chrome/browser/chromeos/power/ml/adaptive_screen_brightness_manager.cc chrome/browser/chromeos/power/ml/user_activity_controller.cc chrome/browser/exo_parts.cc chrome/browser/extensions/api/tabs/tabs_api.cc chrome/browser/media/webrtc/desktop_capture_access_handler.cc chrome/browser/ui/app_list/search/answer_card/answer_card_web_contents.cc chrome/browser/ui/test/test_browser_dialog.cc chrome/browser/ui/views/chrome_views_delegate_chromeos.cc chrome/browser/ui/views/tabs/tab_drag_controller.cc chrome/browser/ui/views/tabs/window_finder_chromeos.cc chrome/browser/ui/webui/settings/md_settings_ui.cc Reland "Fix background painting on scrolling contents layer with foregrounds" Changed by Philip Rogers - pdr@chromium.org Changed at 2018-08-22 7:22 AM (JST) Repository https://chromium.googlesource.com/chromium/src Branch Revision bea4d986d6fb6aa030542a1057901981af39c0ff Comments Reland "Fix background painting on scrolling contents layer with foregrounds" This reverts commit e06da142bd6f0c6857318a598423914ff029b55e. Reason for revert: Was not the root cause of test failures. Original change's description: > Revert "Fix background painting on scrolling contents layer with foregrounds" > > This reverts commit 7834ee2169007c67e67feec762999a9d85c200f6. > > Reason for revert: Suspected as causing failing tests in 874162 > > Original change's description: > > Fix background painting on scrolling contents layer with foregrounds > > > > This patch removes a negative z-index children check from > > PaintLayer::GetBackgroundPaintLocation. This lets backgrounds paint in > > the scrolling contents layer in the presence of negative z-index > > children, fixing the painting of background-attachment: local. This > > patch also removes a DCHECK that was hit when a foreground layer and > > kBackgroundPaintInScrollingContents coexisted. This DCHECK[1] could be > > hit for root layers without the functional change in this patch. As the > > test in this patch shows, kBackgroundPaintInScrollingContents and > > foreground layers work together, so this patch makes non-root-layers use > > both, and removes the DCHECK. > > > > What are foreground layers? A foreground layer is created if a stacked > > PaintLayer has composited negative z-index children that should wedge > > between the layer's background and the layer's contents. The foreground > > layer will have the normal-flow contents in this case. See the comment > > above foreground_layer_ in composited_layer_mapping.h. > > > > [1] DCHECK originally added in: https://crrev.com/9a2cdc8d96d. Reading > > the comments, I think the DCHECK was intended to ensure the background > > would not be painted into the foreground layer. > > > > Bug: 861948 > > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > > Change-Id: I7409cbe9ac61fed444856df342d0707d6babab09 > > Reviewed-on: https://chromium-review.googlesource.com/1173532 > > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > > Commit-Queue: Philip Rogers <pdr@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#584802} > > TBR=pdr@chromium.org,chrishtr@chromium.org > > Change-Id: Ifd22a963dbd5ce288dfb31ab1e8ac41ebe63062d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 861948 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Reviewed-on: https://chromium-review.googlesource.com/1184109 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584895} TBR=pdr@chromium.org,chrishtr@chromium.org Change-Id: I569313a9d5e1dd0b79e541cc3e3ae8816c4c3e05 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 861948 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1184181 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#584911} Changed files third_party/WebKit/LayoutTests/paint/background/scrolling-background-with-negative-z-child-expected.html third_party/WebKit/LayoutTests/paint/background/scrolling-background-with-negative-z-child.html third_party/WebKit/LayoutTests/paint/invalidation/invalidation-on-foreground-graphics-layer-expected.txt third_party/WebKit/LayoutTests/paint/stacking/html-with-negative-z-index-expected.html third_party/WebKit/LayoutTests/paint/stacking/html-with-negative-z-index.html third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc third_party/blink/renderer/core/paint/paint_layer.cc third_party/blink/renderer/core/paint/paint_layer_scrollable_area_test.cc [CrOS MultiDevice] Read prefs from PageContentData in settings UI Changed by Jordy Greenblatt - jordynass@chromium.org Changed at 2018-08-22 7:19 AM (JST) Repository https://chromium.googlesource.com/chromium/src Branch Revision 074a70f972c79fe5fc27d88c63bb0f1cddd82cd9 Comments [CrOS MultiDevice] Read prefs from PageContentData in settings UI Because changes to the MultiDevice feature prefs need to go through the MultiDevice service, we want all reading and writing to occur through that medium. This CL migrates the MultiDevice Settings UI to read feature prefs from the MultiDevice service instead of the settings page's prefs object. Change-Id: I3c4ddb3886faf68e37c4a8a3cacd2fe87b58328e Reviewed-on: https://chromium-review.googlesource.com/1179368 Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#584910} Changed files chrome/browser/resources/settings/basic_page/basic_page.html chrome/browser/resources/settings/multidevice_page/BUILD.gn chrome/browser/resources/settings/multidevice_page/multidevice_feature_item.html chrome/browser/resources/settings/multidevice_page/multidevice_feature_item.js chrome/browser/resources/settings/multidevice_page/multidevice_feature_toggle.html chrome/browser/resources/settings/multidevice_page/multidevice_feature_toggle.js chrome/browser/resources/settings/multidevice_page/multidevice_page.html chrome/browser/resources/settings/multidevice_page/multidevice_page.js chrome/browser/resources/settings/multidevice_page/multidevice_page_container.html chrome/browser/resources/settings/multidevice_page/multidevice_page_container.js chrome/browser/resources/settings/multidevice_page/multidevice_subpage.html chrome/browser/resources/settings/multidevice_page/multidevice_subpage.js chrome/test/data/webui/settings/cr_settings_browsertest.js chrome/test/data/webui/settings/multidevice_feature_item_tests.js chrome/test/data/webui/settings/multidevice_feature_toggle_tests.js chrome/test/data/webui/settings/multidevice_subpage_tests.js Icon in mini view should be wavy. Changed by David Black - dmblack@google.com Changed at 2018-08-22 7:19 AM (JST) Repository https://chromium.googlesource.com/chromium/src Branch Revision cb110d267438c4b47026a1e0a41d8b2c5a26a50d Comments Icon in mini view should be wavy. Per the mocks, in the mini view the Assistant icon should be in its wavy state. Bug: b:112904117 Change-Id: Ic29c447e23d39c629a4cd2856b3953e620af0192 Reviewed-on: https://chromium-review.googlesource.com/1183973 Commit-Queue: David Black <dmblack@google.com> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#584909} Changed files ash/assistant/ui/assistant_mini_view.cc Deprecate explore deep link. Changed by David Black - dmblack@google.com Changed at 2018-08-22 7:12 AM (JST) Repository https://chromium.googlesource.com/chromium/src Branch Revision 7453790af910cd25bbc606accd71298ae412481c Comments Deprecate explore deep link. Decision was made to launch explore in a browser tab instead of within Assistant container. As such, we can deprecate the deep link and will instead use the OpenUrlResponse interaction flow. Bug: b:111704177 Change-Id: Iec68644f0b7c8df23c3926e89fae1283f3f6fd11 Reviewed-on: https://chromium-review.googlesource.com/1183965 Commit-Queue: David Black <dmblack@google.com> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#584908} Changed files ash/assistant/assistant_controller.cc ash/assistant/util/deep_link_util.cc ash/assistant/util/deep_link_util.h ash/assistant/util/deep_link_util_unittest.cc Disable v8.browsing_desktop-future/browse:tools:maps on Mac Changed by Ned Nguyen - nednguyen@google.com Changed at 2018-08-22 7:10 AM (JST) Repository https://chromium.googlesource.com/chromium/src Branch Revision d3c38ed5d6306f187fb910ea8f382a762067c1be Comments Disable v8.browsing_desktop-future/browse:tools:maps on Mac Bug:773084 Change-Id: I8ef6fe66ad10246e62e926f11d1d54ef209d300c NOTRY=true TBR=mythia@chromium.org, ulan@chromium.org Change-Id: I8ef6fe66ad10246e62e926f11d1d54ef209d300c Reviewed-on: https://chromium-review.googlesource.com/1183905 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#584907} Changed files tools/perf/expectations.config Dragged window should have active window shadow during dragging. Changed by Xiaoqian Dai - xdai@chromium.org Changed at 2018-08-22 7:09 AM (JST) Repository https://chromium.googlesource.com/chromium/src Branch Revision b7ee049e2130a36eba7734b648b07f1a60bbca2c Comments Dragged window should have active window shadow during dragging. Bug: 874261 Change-Id: I5973ae1a7afd1a0ffd6f2dd61df679cc566e998a Reviewed-on: https://chromium-review.googlesource.com/1180253 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Mitsuru Oshima (Slow) <oshima@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#584906} Changed files ash/BUILD.gn ash/wm/splitview/split_view_controller_unittest.cc ash/wm/tablet_mode/tablet_mode_window_drag_delegate.cc ash/wm/tablet_mode/tablet_mode_window_drag_delegate.h ash/wm/wm_shadow_controller_delegate.cc ui/wm/core/shadow_controller.cc ui/wm/core/shadow_types.cc ui/wm/core/shadow_types.h Make title of WebAuthn dialogs multi-line. Changed by Balazs Engedy - engedy@chromium.org Changed at 2018-08-22 7:07 AM (JST) Repository https://chromium.googlesource.com/chromium/src Branch Revision bda2056df569ed215723d6adc159694f94ffa9e7 Comments Make title of WebAuthn dialogs multi-line. In case of long relying party IDs, we should not truncate them. Bug: 849323 Change-Id: Idbfb63866c54bd98b6a9006f47c59291a29bc4cc Reviewed-on: https://chromium-review.googlesource.com/1183494 Reviewed-by: Jun Choi <hongjunchoi@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#584905} Changed files chrome/browser/ui/views/webauthn/authenticator_request_sheet_view.cc ChromeDriver: Convert mouse events into touch events Changed by Joel Einbinder - einbinder@chromium.org Changed at 2018-08-22 7:05 AM (JST) Repository https://chromium.googlesource.com/chromium/src Branch Revision e4e4440f89bd318d228713278a9486a184680972 Comments ChromeDriver: Convert mouse events into touch events This patch uses Input.dispatchTouchEvent instead of Emulation.setEmitTouchEventsForMouse. This gives more predictable behavior and allows for each touch event to be awaited. Bug: chromedriver:2144 Change-Id: Ic243c216e2f832844a64f8f2af894eb6cc4234d1 Reviewed-on: https://chromium-review.googlesource.com/1182506 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by: John Chen <johnchen@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#584904} Changed files chrome/test/chromedriver/chrome/mobile_emulation_override_manager.cc chrome/test/chromedriver/chrome/web_view_impl.cc chrome/test/chromedriver/chrome/web_view_impl.h chrome/test/chromedriver/test/run_py_tests.py
,
Aug 22
Hey, xunjieli@, looks like this failure is back, and in the same build that picked up your reland of your CL. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/34400 Seems very suspicious, can you please investigate?
,
Aug 22
my CL (https://chromium-review.googlesource.com/c/chromium/src/+/1185102) doesn't seem related to the test failures, but i'll take a look.
,
Aug 22
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by s...@chromium.org
, Aug 22