PWAs: Add "Uninstall" to PWA app menu on platforms that don't support system uninstall |
|||
Issue descriptionChrome Version: 70 OS: Windows, Linux (And MAYBE Chrome OS too, if we decide that uninstall from the App Launcher is undiscoverable, since most of the time people will try to uninstall from the shelf which doesn't work yet.) What steps will reproduce the problem? (1) Install a PWA (e.g., https://santatracker.google.com -> Chrome menu -> Install). (2) Try to uninstall it. What is the expected result? You can remove it from the system Add/Remove Programs as you would a native application. But since that is too hard (Issue 846606), a short-term solution is to add an "Uninstall $APPNAME" item to the PWA app menu. What happens instead? There is no system UI for doing so (e.g., in Windows, Santa Tracker does not appear in Add/Remove programs). See Issue 846606. You *can* uninstall the app by going to chrome://apps and removing it there. But that is quite hard to discover.
,
Aug 22
+austinknight & hwi: Does the placement of the uninstall option in the app menu seem okay to you?
,
Aug 22
WIP CL: https://chromium-review.googlesource.com/c/chromium/src/+/1184128 Some hosted apps cannot be removed, for these I've greyed out the uninstall option.
,
Aug 22
Stumbled upon some bugs I noticed a while ago re uninstalling PWAs. Looks like we don't set the extension association properly when popping in/out of tabs and we sometimes close tabs or don't close windows when uninstalling the PWA. This is most noticeable when you install a PWA and then immediately uninstall it, the app window continues to hang around and crashes next time you open the app menu. I can't repro this on Chrome OS and I'm not sure why.
,
Aug 23
Filed issue 877009 for bug in #5.
,
Aug 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a0ec9e44d5dcc4e6696edd5fec7bfe2b79ef4c23 commit a0ec9e44d5dcc4e6696edd5fec7bfe2b79ef4c23 Author: Alan Cutter <alancutter@chromium.org> Date: Mon Aug 27 01:18:06 2018 Add uninstall option to the hosted app menu Currently it's not obvious how to remove a PWA on platforms other than Chrome OS. The user needs to navigate to chrome://apps, right click icon and pick "Remove from Chromium". This CL adds a hosted app menu option to uninstall the hosted app. Screenshots: Menu option: https://bugs.chromium.org/p/chromium/issues/attachment?aid=354298&signed_aid=_QBTIue6dZ9AK09Q11Ppzw==&inline=1 Confirmation: https://bugs.chromium.org/p/chromium/issues/attachment?aid=354299&signed_aid=XgFqjDNSIfIOnosVYz-B6w==&inline=1 Disabled option: https://bugs.chromium.org/p/chromium/issues/attachment?aid=354300&signed_aid=GLxQI_0xEXHLyc8ZG3IKwA==&inline=1 Bug: 876560 Change-Id: Idc95eb5f8f48db5033cd61a944c7d172fe96842b Reviewed-on: https://chromium-review.googlesource.com/1184128 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#586178} [modify] https://crrev.com/a0ec9e44d5dcc4e6696edd5fec7bfe2b79ef4c23/chrome/app/generated_resources.grd [modify] https://crrev.com/a0ec9e44d5dcc4e6696edd5fec7bfe2b79ef4c23/chrome/browser/extensions/extension_uninstall_dialog.h [modify] https://crrev.com/a0ec9e44d5dcc4e6696edd5fec7bfe2b79ef4c23/chrome/browser/ui/extensions/hosted_app_browser_controller.cc [modify] https://crrev.com/a0ec9e44d5dcc4e6696edd5fec7bfe2b79ef4c23/chrome/browser/ui/extensions/hosted_app_browser_controller.h [modify] https://crrev.com/a0ec9e44d5dcc4e6696edd5fec7bfe2b79ef4c23/chrome/browser/ui/extensions/hosted_app_browsertest.cc [modify] https://crrev.com/a0ec9e44d5dcc4e6696edd5fec7bfe2b79ef4c23/chrome/browser/ui/extensions/hosted_app_menu_model.cc [modify] https://crrev.com/a0ec9e44d5dcc4e6696edd5fec7bfe2b79ef4c23/chrome/browser/ui/extensions/hosted_app_menu_model.h [modify] https://crrev.com/a0ec9e44d5dcc4e6696edd5fec7bfe2b79ef4c23/extensions/browser/uninstall_reason.h
,
Aug 27
|
|||
►
Sign in to add a comment |
|||
Comment 1 by mgiuca@chromium.org
, Aug 21