New issue
Advanced search Search tips

Issue 876558 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 22
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Remove old GTK2 code

Project Member Reported by thomasanderson@chromium.org, Aug 21

Issue description

GTK2 code was historically kept around to keep the electron build working.  But as of Nov 26, 2017, electron now uses GTK3:
https://github.com/electron/electron/issues/2927#issuecomment-347092515

It should now be safe to remove all of the old GTK2-only code.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/287339e07364162daa8fd6f90ef1d2338f32bed5

commit 287339e07364162daa8fd6f90ef1d2338f32bed5
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Wed Aug 22 21:52:02 2018

Remove GTK2 code

GTK2 code was historically kept around to keep the electron build working.  But
as of Nov 26, 2017, electron now uses GTK3 [1], so it should now be safe to
remove all of the old GTK2-only code.

[1] https://github.com/electron/electron/issues/2927#issuecomment-347092515

BUG= 876558 
R=sky

Change-Id: I78402053ae508ccd8fc7ac73697a861bb1ebacf6
Reviewed-on: https://chromium-review.googlesource.com/1183858
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585265}
[modify] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/build/config/linux/atk/BUILD.gn
[modify] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/build/config/linux/gtk/BUILD.gn
[delete] https://crrev.com/16ac37826eca7f3aafb9f4de78aab3da704ef0a8/build/config/linux/gtk/gtk.gni
[delete] https://crrev.com/16ac37826eca7f3aafb9f4de78aab3da704ef0a8/build/config/linux/gtk2/BUILD.gn
[delete] https://crrev.com/16ac37826eca7f3aafb9f4de78aab3da704ef0a8/build/config/linux/gtk3/BUILD.gn
[modify] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/build/experimental/install-build-deps.py
[modify] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/build/install-build-deps.sh
[modify] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/build/linux/sysroot_scripts/sysroot-creator-sid.sh
[modify] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/chrome/browser/icon_loader_auralinux.cc
[modify] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/chrome/browser/ui/libgtkui/BUILD.gn
[modify] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/chrome/browser/ui/libgtkui/app_indicator_icon.cc
[rename] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/chrome/browser/ui/libgtkui/gtk_background_painter.cc
[rename] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/chrome/browser/ui/libgtkui/gtk_background_painter.h
[modify] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/chrome/browser/ui/libgtkui/gtk_event_loop.cc
[modify] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/chrome/browser/ui/libgtkui/gtk_event_loop.h
[modify] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/chrome/browser/ui/libgtkui/gtk_key_bindings_handler.cc
[modify] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/chrome/browser/ui/libgtkui/gtk_key_bindings_handler.h
[modify] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/chrome/browser/ui/libgtkui/gtk_status_icon.cc
[modify] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/chrome/browser/ui/libgtkui/gtk_status_icon.h
[modify] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/chrome/browser/ui/libgtkui/gtk_ui.cc
[modify] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/chrome/browser/ui/libgtkui/gtk_ui.h
[modify] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/chrome/browser/ui/libgtkui/gtk_util.cc
[modify] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/chrome/browser/ui/libgtkui/gtk_util.h
[modify] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/chrome/browser/ui/libgtkui/libgtkui_export.h
[rename] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/chrome/browser/ui/libgtkui/native_theme_gtk.cc
[rename] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/chrome/browser/ui/libgtkui/native_theme_gtk.h
[delete] https://crrev.com/16ac37826eca7f3aafb9f4de78aab3da704ef0a8/chrome/browser/ui/libgtkui/native_theme_gtk2.cc
[delete] https://crrev.com/16ac37826eca7f3aafb9f4de78aab3da704ef0a8/chrome/browser/ui/libgtkui/native_theme_gtk2.h
[rename] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/chrome/browser/ui/libgtkui/nav_button_provider_gtk.cc
[rename] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/chrome/browser/ui/libgtkui/nav_button_provider_gtk.h
[modify] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/chrome/browser/ui/libgtkui/print_dialog_gtk.cc
[modify] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/chrome/browser/ui/libgtkui/print_dialog_gtk.h
[modify] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/chrome/browser/ui/libgtkui/settings_provider.h
[modify] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/chrome/browser/ui/libgtkui/settings_provider_gsettings.cc
[rename] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/chrome/browser/ui/libgtkui/settings_provider_gtk.cc
[rename] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/chrome/browser/ui/libgtkui/settings_provider_gtk.h
[modify] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/chrome/browser/ui/libgtkui/x11_input_method_context_impl_gtk.cc
[modify] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/chrome/browser/ui/libgtkui/x11_input_method_context_impl_gtk.h
[modify] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/chrome/browser/ui/views/chrome_browser_main_extra_parts_views_linux.cc
[modify] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/chrome/common/features.gni
[modify] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/docs/linux_build_instructions.md
[modify] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/docs/linux_debugging.md
[modify] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/docs/linux_debugging_gtk.md
[modify] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/docs/linux_gtk_theme_integration.md
[modify] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/remoting/host/continue_window_linux.cc
[modify] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/remoting/host/disconnect_window_linux.cc
[modify] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/third_party/instrumented_libraries/BUILD.gn
[delete] https://crrev.com/16ac37826eca7f3aafb9f4de78aab3da704ef0a8/third_party/instrumented_libraries/patches/libgtk2.0-0.trusty.diff
[modify] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/third_party/instrumented_libraries/scripts/install-build-deps.sh
[delete] https://crrev.com/16ac37826eca7f3aafb9f4de78aab3da704ef0a8/third_party/instrumented_libraries/scripts/pre-build/libgtk2.0-0.sh
[modify] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/tools/android/loading/cloud/backend/startup-script.sh
[modify] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/ui/accessibility/BUILD.gn
[rename] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/ui/accessibility/platform/atk_util_auralinux_gtk.cc
[delete] https://crrev.com/16ac37826eca7f3aafb9f4de78aab3da704ef0a8/ui/accessibility/platform/atk_util_auralinux_gtk2.cc
[modify] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/ui/views/features.gni
[modify] https://crrev.com/287339e07364162daa8fd6f90ef1d2338f32bed5/ui/views/linux_ui/linux_ui.h

Status: Fixed (was: Started)

Sign in to add a comment