add cros-container-guest-tools to repo manifest |
||
Issue descriptionI'd like to add https://chromium.googlesource.com/chromiumos/containers/cros-container-guest-tools to our repo manifest so it's automatically branched like the rest of CrOS. This repo contains guest package sources and kokoro build scripts. For lack of a better place to put this, I'm proposing: src/containers/guest-tools but I'm not attached to mauve for this bikeshed's color.
,
Aug 22
My concern with src/platform/ was the implication that this project might be built or distributed for normal CrOS images. But as I said, don't feel strongly about this. src/platform/ sounds good to me.
,
Aug 22
src/platform/ hosts all sort of content that isn't built into "normal CrOS repos". we have partner repos in there (e.g. jetstream) as well as build-time only repos (e.g. dev/ and factory and firmware and such). at this point, i think we can consider src/platform/ as "all first party stuff that CrOS needs checked out". i'm not against splitting out stuff from src/platform/ when it makes sense, but i think it's better to let a pattern emerge first and then shuffle around vs adding a single project to a new dir under src/. if we had sep repos for many of the container related projects instead of hosting them in platform2, i would have said that's a good reason to give a dedicated dir :).
,
Aug 23
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/manifest-internal/+/34dd91e1c264f0d462f5243e736f91898dec38f3 commit 34dd91e1c264f0d462f5243e736f91898dec38f3 Author: Stephen Barber <smbarber@chromium.org> Date: Thu Aug 23 20:20:59 2018
,
Aug 23
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/manifest/+/bef0be22b4f22a592e902affa4a8ef16fc8a9387 commit bef0be22b4f22a592e902affa4a8ef16fc8a9387 Author: Stephen Barber <smbarber@chromium.org> Date: Thu Aug 23 20:20:51 2018 container-guest-tools: add to external manifest BUG= chromium:876522 TEST=repo sync Change-Id: Ia1cbc0cc455bdcca2f9ebfec3203ed8bf7a82ef7 Reviewed-on: https://chromium-review.googlesource.com/1185733 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Stephen Barber <smbarber@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/bef0be22b4f22a592e902affa4a8ef16fc8a9387/full.xml
,
Aug 24
Verified on ToT |
||
►
Sign in to add a comment |
||
Comment 1 by vapier@chromium.org
, Aug 22