New issue
Advanced search Search tips

Issue 876517 link

Starred by 1 user
Status: Untriaged
Owner: ----
Cc:
b...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Improve HttpServerPropertiesImpl::GetAlternativeServiceInfos implementation

Project Member Reported by zhongyi@chromium.org, Aug 21 
The current HttpServerPropertiesImpl::GetAlternativeServiceInfos implementation is confusing. It doesn't exclude broken alternative services if the alternative service list is directly retrieved based on the original host. However, it does exclude the broken alternative services when the alternative service list is retrieved based on the canonical host.

It worth a clean up so that this API semantics is more clear and caller can get more accurate alternative service list.

Comment 1 by zhongyi@chromium.org, Aug 21

Cc: b...@chromium.org

Comment 2 by zhongyi@chromium.org, Aug 21 

Ah, the .h file says:
  // Return all alternative services for |origin|, including broken ones.
  // Returned alternative services never have empty hostnames.
  virtual AlternativeServiceInfoVector GetAlternativeServiceInfos(
      const url::SchemeHostPort& origin) = 0;

I wonder whether we should include those broken alternative services for canonical host as well.
►

Sign in to add a comment