The applist stopped working with the switch to ws2. This is because ash runs the windowservice directly, which RemoteViewHost isn't setup for.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a1c161f5dfddb7fcf16126f13bcc6d720052f18f commit a1c161f5dfddb7fcf16126f13bcc6d720052f18f Author: Scott Violet <sky@chromium.org> Date: Wed Aug 22 21:33:11 2018 window-service: adds ServerRemoteViewHost for embedding use This class is intended for use by the owner of the WindowService to handle embeddings initiated by clients via ScheduleEmbedForExistingClient(). It roughly mirrors that of views::RemoteViewHost. I put this file in ws2 (but in it's own directly) to reinfoce that it's optional and only for use with the owner of ws2. BUG= 876513 TEST=covered by test Change-Id: Ibc837fcb4619eefcfe90ca3c782446c581aef4cd Reviewed-on: https://chromium-review.googlesource.com/1185362 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#585254} [modify] https://crrev.com/a1c161f5dfddb7fcf16126f13bcc6d720052f18f/services/ui/ws2/BUILD.gn [modify] https://crrev.com/a1c161f5dfddb7fcf16126f13bcc6d720052f18f/services/ui/ws2/embedding.cc [modify] https://crrev.com/a1c161f5dfddb7fcf16126f13bcc6d720052f18f/services/ui/ws2/embedding.h [add] https://crrev.com/a1c161f5dfddb7fcf16126f13bcc6d720052f18f/services/ui/ws2/remote_view_host/BUILD.gn [add] https://crrev.com/a1c161f5dfddb7fcf16126f13bcc6d720052f18f/services/ui/ws2/remote_view_host/server_remote_view_host.cc [add] https://crrev.com/a1c161f5dfddb7fcf16126f13bcc6d720052f18f/services/ui/ws2/remote_view_host/server_remote_view_host.h [add] https://crrev.com/a1c161f5dfddb7fcf16126f13bcc6d720052f18f/services/ui/ws2/remote_view_host/server_remote_view_host_unittest.cc [modify] https://crrev.com/a1c161f5dfddb7fcf16126f13bcc6d720052f18f/services/ui/ws2/server_window.cc [modify] https://crrev.com/a1c161f5dfddb7fcf16126f13bcc6d720052f18f/services/ui/ws2/server_window.h [modify] https://crrev.com/a1c161f5dfddb7fcf16126f13bcc6d720052f18f/services/ui/ws2/window_service.cc [modify] https://crrev.com/a1c161f5dfddb7fcf16126f13bcc6d720052f18f/services/ui/ws2/window_service.h [modify] https://crrev.com/a1c161f5dfddb7fcf16126f13bcc6d720052f18f/services/ui/ws2/window_service_unittest.cc [modify] https://crrev.com/a1c161f5dfddb7fcf16126f13bcc6d720052f18f/services/ui/ws2/window_tree.cc [modify] https://crrev.com/a1c161f5dfddb7fcf16126f13bcc6d720052f18f/services/ui/ws2/window_tree.h [modify] https://crrev.com/a1c161f5dfddb7fcf16126f13bcc6d720052f18f/services/ui/ws2/window_tree_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e5c3f5be57c342fec0b0ba3d934d80771f6afd7f commit e5c3f5be57c342fec0b0ba3d934d80771f6afd7f Author: Scott Violet <sky@chromium.org> Date: Wed Aug 22 21:56:45 2018 chromeos: makes app-list use ServerRemoteViewHost This converts ash to using ServerRemoteViewHost now that it hosts the WindowService. This also makes WindowServiceOwner create the WindowService immediately. BUG= 876513 TEST=covered by tests Change-Id: I7aba636c9e87db4ab08e1ccab97acecacdfc59f9 Reviewed-on: https://chromium-review.googlesource.com/1185796 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#585269} [modify] https://crrev.com/e5c3f5be57c342fec0b0ba3d934d80771f6afd7f/ash/app_list/BUILD.gn [modify] https://crrev.com/e5c3f5be57c342fec0b0ba3d934d80771f6afd7f/ash/app_list/app_list_controller_impl.cc [modify] https://crrev.com/e5c3f5be57c342fec0b0ba3d934d80771f6afd7f/ash/app_list/app_list_controller_impl.h [modify] https://crrev.com/e5c3f5be57c342fec0b0ba3d934d80771f6afd7f/ash/app_list/app_list_view_delegate.h [modify] https://crrev.com/e5c3f5be57c342fec0b0ba3d934d80771f6afd7f/ash/app_list/test/app_list_test_view_delegate.cc [modify] https://crrev.com/e5c3f5be57c342fec0b0ba3d934d80771f6afd7f/ash/app_list/test/app_list_test_view_delegate.h [modify] https://crrev.com/e5c3f5be57c342fec0b0ba3d934d80771f6afd7f/ash/app_list/views/search_result_answer_card_view.cc [modify] https://crrev.com/e5c3f5be57c342fec0b0ba3d934d80771f6afd7f/ash/assistant/ui/assistant_web_view.h [modify] https://crrev.com/e5c3f5be57c342fec0b0ba3d934d80771f6afd7f/ash/shell.cc [modify] https://crrev.com/e5c3f5be57c342fec0b0ba3d934d80771f6afd7f/ash/shell/app_list.cc [modify] https://crrev.com/e5c3f5be57c342fec0b0ba3d934d80771f6afd7f/ash/ws/window_service_owner.cc [modify] https://crrev.com/e5c3f5be57c342fec0b0ba3d934d80771f6afd7f/ash/ws/window_service_owner.h
Comment 1 by xiy...@chromium.org
, Aug 21