New issue
Advanced search Search tips

Issue 876484 link

Starred by 3 users
Status: Fixed
Owner:
sammiequon@chromium.org
Closed: Aug 31
Cc:
omrilio@chromium.org
weidongg@chromium.org
sammiequon@chromium.org
mccanny@chromium.org
kejiashao@chromium.org
newcomer@chromium.org
osh...@chromium.org
manucornet@chromium.org
minch@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

When app launches in fullscreen mode, can't swipe up to bring back the shelf

Project Member Reported by kejiashao@chromium.org, Aug 21 
Chrome Version: (copy from chrome://version)
OS: (e.g. Win10, MacOS 10.12, etc...)

What steps will reproduce the problem?
(1) Open one of these apps: Asphalt 8, Clash Royale
(2) Swipe up on the bottom
(3)

What is the expected result?

Shelf should show up

What happens instead?

Nothing happens: https://photos.app.goo.gl/7Dqc2YvBH7goK2Tx5



Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

Comment 1 by osh...@chromium.org, Aug 21

Owner: sammiequon@chromium.org
Status: Assigned (was: Untriaged)
This may be a side effect of disabling the hiding shelf. I can reproduce the
same behavior even with chrome browser's immersive mode.

I think we should at least allow revaling the shelf by gesture.
sammie, can you look into it?

Comment 2 by sammiequon@chromium.org, Aug 22

Status: Started (was: Assigned)
hmm, im not sure what happened here, im pretty sure i tested this case when i disabled autohide

Comment 3 by sammiequon@chromium.org, Aug 22

Status: Available (was: Started)
+newcomer +weidongg

I tried disabling the home-launcher flag, and the issue is not there, so adding a couple launcher folks.

Comment 4 by sammiequon@chromium.org, Aug 22

Cc: weidongg@chromium.org newcomer@chromium.org
+newcomer +weidongg

for real this time

Comment 5 by sammiequon@chromium.org, Aug 22

Components: -Platform>Apps>ARC UI>Shell>Shelf
Status: Started (was: Available)
This is a bug swap from https://chromium-review.googlesource.com/c/chromium/src/+/1179303.

Also happens to non-arc apps, so changing component.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d397a8a6321c15489c58e8a1b87d5ee8dc03e4c

commit 7d397a8a6321c15489c58e8a1b87d5ee8dc03e4c
Author: Sammie Quon <sammiequon@google.com>
Date: Tue Aug 28 22:37:47 2018

shelf: Fix bug with cannot show autohidden shelf with homecher.

Do not skip events if app list is visible with home launcher on.
Do allow home launcher gesture handler to process events if the shelf
is invisible, or if it is visible via auto-hide.

Test: manual
Bug:  876484 
Change-Id: I4080dff5cbd8647d0b1bf6aebc2f19559d7e7d15
Reviewed-on: https://chromium-review.googlesource.com/1194686
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586897}
[modify] https://crrev.com/7d397a8a6321c15489c58e8a1b87d5ee8dc03e4c/ash/shelf/shelf_layout_manager.cc

Comment 7 by sammiequon@chromium.org, Aug 29

Cc: manucornet@chromium.org osh...@chromium.org
 Issue 878146  has been merged into this issue.

Comment 8 by manucornet@chromium.org, Aug 29 

Thank you Sammie!

Should this be marked as fixed now? Or are there other remaining issues?

Comment 9 by manucornet@chromium.org, Aug 29

Cc: minch@chromium.org sammiequon@chromium.org
 Issue 878798  has been merged into this issue.

Comment 10 by sammiequon@chromium.org, Aug 29 

manucornet - I think its fixed, im just waiting to double check on ToT, and then i will mark as fixed.

Comment 11 by manucornet@chromium.org, Aug 29 

Ok thank you! Sorry for the noise. I guess M-70 bugs are getting more attention in this final sprint ;-)

Comment 12 by sammiequon@chromium.org, Aug 31

Status: Fixed (was: Started)
►

Sign in to add a comment