New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 876478 link

Starred by 1 user
Status: Fixed
Owner:
█ offenwanger@chromium.org
Last visit > 30 days ago
Closed: Aug 22
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

NFC fails to fire Vrdisplayactivate on O

Project Member Reported by bsheedy@chromium.org, Aug 21 
Recently, WebXrVrTransitionTest#testNfcFiresVrdisplayactivate has started failing 100% of the time on O. However, other NFC tests still pass, so it looks like this is an issue specific to firing the vrdisplayactivate event in response to an NFC scan.

Unfortunately, this started sometime during the test outage from  Issue 875909 , so the regression range is pretty large. It started sometime between 37e7a2d72203b0e6924eab2441a94a901a813702 (good) and af5475b887c46f2261cdc098b2e272274e57c9a9 (bad).

Comment 1 by bsheedy@chromium.org, Aug 21

Owner: offenwanger@chromium.org
Status: Assigned (was: Untriaged)
Bisect points to https://chromium-review.googlesource.com/1181535 as the culprit.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f71fb12ebd22cbd4aa45a6fc69a7a628424d8268

commit f71fb12ebd22cbd4aa45a6fc69a7a628424d8268
Author: Anna Offenwanger <offenwanger@chromium.org>
Date: Wed Aug 22 16:25:59 2018

Fix error in WebVR set Activate

Somehow an _ got removed that shouldn't have been.

Bug:  876478 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I8f0368cfbc2b2f0e1180ecf9ab2f126d2c418394
Reviewed-on: https://chromium-review.googlesource.com/1183846
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585043}
[modify] https://crrev.com/f71fb12ebd22cbd4aa45a6fc69a7a628424d8268/chrome/browser/vr/service/xr_device_impl.cc

Comment 3 by offenwanger@chromium.org, Aug 22

Status: Fixed (was: Assigned)

Comment 4 by bsheedy@chromium.org, Aug 29

Labels: -VR-Caught-By-Test XR-Caught-By-Test
►

Sign in to add a comment