Issue metadata
Sign in to add a comment
|
6.3% regression in rendering.desktop at 584583:584590 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Aug 21
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/1297ce16640000
,
Aug 21
📍 Found significant differences after each of 2 commits. https://pinpoint-dot-chromeperf.appspot.com/job/1297ce16640000 Move TimeClamper to core/timing by dgozman@chromium.org https://chromium.googlesource.com/chromium/src/+/2c38ce9585da7b0d07aff3b03faf8085548f1c6e 54.05 → 52.24 (-1.817) blink/canvas: Ensure constant PaintImage::ContentId for canvas snapshots. by khushalsagar@chromium.org https://chromium.googlesource.com/chromium/src/+/f93f8b7c3d3080586deba2a1a7f6b47bcfc4e340 52.56 → 60.32 (+7.754) Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Aug 21
-dgozman@, Its definitely my change. I'm super confused with how this change increased the number of tasks. Its curious that there is a decline in the number of tasks on the same benchmark from https://chromium.googlesource.com/chromium/src/+/79531c77e491dc9536c985d6c4f5dcd8c6bb48b8, which also regressed the behaviour that the patch above fixes. fserb@, does anything in the traces jump out to you, that would explain why the initial change reduced the number of tasks and this change would increase them back?
,
Aug 21
Faster rendering can lead to more tasks per unit time. pdr and vmpstr investigated a similar "regression" recently.
,
Aug 21
Thanks Chris, that is probably the case here as well. The change above is an overall improvement in smoothness and frame_times (https://chromeperf.appspot.com/group_report?rev=584588) and the tasks_per_frame_total_all regression for this config is minor in comparison to the improvements everywhere else. I think the change is working as intended.
,
Aug 27
Issue 876844 has been merged into this issue. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Aug 21