Right now only the SVGShapePainter calls the RecordHitTestData, while all other SVG related painters should. We should add new tests for this.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7106e771bed5cda6749224287e56e8758a50db85 commit 7106e771bed5cda6749224287e56e8758a50db85 Author: Xida Chen <xidachen@chromium.org> Date: Tue Aug 28 20:18:02 2018 Add RecordHitTestData in SVGTextPainter This CL adds RecordHitTestData in SVGTextPainter. Two layout tests are added. One of them adds a touch event listener in the svg text, and the other one adds in the SVG container that contains the SVG text. In theory, these two tests should give the same results. From the results we can see that they are correct with PTAR but incorrect without PTAR. Bug: 876468 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I5d290fdb73fe56b5a021fd5a82f7efef14523990 Reviewed-on: https://chromium-review.googlesource.com/1186152 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#586830} [modify] https://crrev.com/7106e771bed5cda6749224287e56e8758a50db85/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 [add] https://crrev.com/7106e771bed5cda6749224287e56e8758a50db85/third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-svg-container-expected.txt [add] https://crrev.com/7106e771bed5cda6749224287e56e8758a50db85/third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-svg-container.html [add] https://crrev.com/7106e771bed5cda6749224287e56e8758a50db85/third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-svg-text-expected.txt [add] https://crrev.com/7106e771bed5cda6749224287e56e8758a50db85/third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-svg-text.html [add] https://crrev.com/7106e771bed5cda6749224287e56e8758a50db85/third_party/WebKit/LayoutTests/platform/linux/virtual/paint-touchaction-rects/fast/events/touch/compositor-touch-hit-rects-svg-container-expected.txt [add] https://crrev.com/7106e771bed5cda6749224287e56e8758a50db85/third_party/WebKit/LayoutTests/platform/linux/virtual/paint-touchaction-rects/fast/events/touch/compositor-touch-hit-rects-svg-text-expected.txt [add] https://crrev.com/7106e771bed5cda6749224287e56e8758a50db85/third_party/WebKit/LayoutTests/virtual/paint-touchaction-rects/fast/events/touch/compositor-touch-hit-rects-svg-container-expected.txt [add] https://crrev.com/7106e771bed5cda6749224287e56e8758a50db85/third_party/WebKit/LayoutTests/virtual/paint-touchaction-rects/fast/events/touch/compositor-touch-hit-rects-svg-text-expected.txt [modify] https://crrev.com/7106e771bed5cda6749224287e56e8758a50db85/third_party/blink/renderer/core/paint/svg_text_painter.cc [modify] https://crrev.com/7106e771bed5cda6749224287e56e8758a50db85/third_party/blink/renderer/core/paint/svg_text_painter.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55ab84658e7914d67795c2f440eaea14a3335284 commit 55ab84658e7914d67795c2f440eaea14a3335284 Author: Xida Chen <xidachen@chromium.org> Date: Wed Aug 29 00:57:59 2018 [LayoutTest] Add a new test for SVG foregin object case for PTAR This CL adds a new test case with SVG foregin object, to test the correctness of PaintTouchActionRects. Bug: 876468 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie3702b3e719b2e1a025fb604e2260d0c877d6e5b Reviewed-on: https://chromium-review.googlesource.com/1194465 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#586975} [modify] https://crrev.com/55ab84658e7914d67795c2f440eaea14a3335284/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 [add] https://crrev.com/55ab84658e7914d67795c2f440eaea14a3335284/third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-svg-foreign-object-expected.txt [add] https://crrev.com/55ab84658e7914d67795c2f440eaea14a3335284/third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-svg-foreign-object.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3f0aba15245c67496e4e418d31dd432b80da8c24 commit 3f0aba15245c67496e4e418d31dd432b80da8c24 Author: Xida Chen <xidachen@chromium.org> Date: Thu Aug 30 16:02:17 2018 Add RecordHitTestData in SVGImagePainter This CL adds RecordHitTestData in SVGImagePainter to compute touch action rects during paint. A layout test is also added. This CL also put the RecordHitTestData in SVGModelObjectPainter so that both SVGImagePainter and SVGShapePainter can call. Bug: 876468 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6aabbad8ac10fc4fb25e4ec16b7a53cbc6cfff27 Reviewed-on: https://chromium-review.googlesource.com/1196903 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#587603} [modify] https://crrev.com/3f0aba15245c67496e4e418d31dd432b80da8c24/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 [add] https://crrev.com/3f0aba15245c67496e4e418d31dd432b80da8c24/third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-svg-image-expected.txt [add] https://crrev.com/3f0aba15245c67496e4e418d31dd432b80da8c24/third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-svg-image.html [add] https://crrev.com/3f0aba15245c67496e4e418d31dd432b80da8c24/third_party/WebKit/LayoutTests/virtual/paint-touchaction-rects/fast/events/touch/compositor-touch-hit-rects-svg-image-expected.txt [modify] https://crrev.com/3f0aba15245c67496e4e418d31dd432b80da8c24/third_party/blink/renderer/core/paint/svg_image_painter.cc [modify] https://crrev.com/3f0aba15245c67496e4e418d31dd432b80da8c24/third_party/blink/renderer/core/paint/svg_model_object_painter.cc [modify] https://crrev.com/3f0aba15245c67496e4e418d31dd432b80da8c24/third_party/blink/renderer/core/paint/svg_model_object_painter.h [modify] https://crrev.com/3f0aba15245c67496e4e418d31dd432b80da8c24/third_party/blink/renderer/core/paint/svg_shape_painter.cc [modify] https://crrev.com/3f0aba15245c67496e4e418d31dd432b80da8c24/third_party/blink/renderer/core/paint/svg_shape_painter.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc6eae274d854a86ecb8887bf4aaec6378473d5a commit fc6eae274d854a86ecb8887bf4aaec6378473d5a Author: Xida Chen <xidachen@chromium.org> Date: Sat Sep 01 02:38:29 2018 Add RecordHitTestData in LayoutReplacedPainter This CL adds RecordHitTestData in LayoutReplacedPainter. Two layout tests are added for SVG root and HTML image element cases. Bug: 876468 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iea6a2318bcd7029b252ebccc92d62d93ad0b6c23 Reviewed-on: https://chromium-review.googlesource.com/1196914 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#588250} [modify] https://crrev.com/fc6eae274d854a86ecb8887bf4aaec6378473d5a/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 [add] https://crrev.com/fc6eae274d854a86ecb8887bf4aaec6378473d5a/third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-img-element-expected.txt [add] https://crrev.com/fc6eae274d854a86ecb8887bf4aaec6378473d5a/third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-img-element.html [add] https://crrev.com/fc6eae274d854a86ecb8887bf4aaec6378473d5a/third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-svg-root-expected.txt [add] https://crrev.com/fc6eae274d854a86ecb8887bf4aaec6378473d5a/third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-svg-root.html [add] https://crrev.com/fc6eae274d854a86ecb8887bf4aaec6378473d5a/third_party/WebKit/LayoutTests/virtual/paint-touchaction-rects/fast/events/touch/compositor-touch-hit-rects-svg-root-expected.txt [modify] https://crrev.com/fc6eae274d854a86ecb8887bf4aaec6378473d5a/third_party/blink/renderer/core/paint/replaced_painter.cc [modify] https://crrev.com/fc6eae274d854a86ecb8887bf4aaec6378473d5a/third_party/blink/renderer/core/paint/replaced_painter.h
Comment 1 by bugdroid1@chromium.org
, Aug 28