New issue
Advanced search Search tips

Issue 876463 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Aug 22
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

chrome_public_test_apk failing on chromium.memory/Android CFI

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Aug 21

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of skym@chromium.org

chrome_public_test_apk failing on chromium.memory/Android CFI

Builders failed on: 
- Android CFI: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI


 
Cc: kinuko@chromium.org
Last two test runs have failed org.chromium.chrome.browser.metrics.MainIntentBehaviorMetricsIntegrationTest#testLaunch_From_InAppActivities

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/2590
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/2591

java.lang.AssertionError: expected:<1> but was:<2>
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.failNotEquals(Assert.java:834)
	at org.junit.Assert.assertEquals(Assert.java:645)
	at org.junit.Assert.assertEquals(Assert.java:631)
	at org.chromium.chrome.browser.metrics.MainIntentBehaviorMetricsIntegrationTest.testLaunch_From_InAppActivities(MainIntentBehaviorMetricsIntegrationTest.java:299)
	at java.lang.reflect.Method.invoke(Method.java)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:52)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.chromium.base.test.ScreenshotOnFailureStatement.evaluate(ScreenshotOnFailureStatement.java:37)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.chromium.chrome.test.ChromeActivityTestRule$1.evaluate(ChromeActivityTestRule.java:116)
	at android.support.test.internal.statement.UiThreadStatement.evaluate(UiThreadStatement.java:55)
	at android.support.test.rule.ActivityTestRule$ActivityStatement.evaluate(ActivityTestRule.java:270)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:237)
	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:48)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.chromium.base.test.BaseJUnit4ClassRunner.run(BaseJUnit4ClassRunner.java:220)
	at org.junit.runners.Suite.runChild(Suite.java:128)
	at org.junit.runners.Suite.runChild(Suite.java:27)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
	at android.support.test.internal.runner.TestExecutor.execute(TestExecutor.java:59)
	at android.support.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:262)
	at org.chromium.base.test.BaseChromiumAndroidJUnitRunner.onStart(BaseChromiumAndroidJUnitRunner.java:125)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1879)

I'm not familiar with this test or associated code, but I'm wondering if https://chromium-review.googlesource.com/c/chromium/src/+/1178324 could be the cause, which was new to the 2590 build. +kinuko
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5a63a645f2979ac862ce626629b14abb6606eec

commit d5a63a645f2979ac862ce626629b14abb6606eec
Author: Sky Malice <skym@chromium.org>
Date: Tue Aug 21 20:23:38 2018

Revert "Remove data use updates from page load metrics"

This reverts commit 66ce35f8440ce92535f78f37579724774c687f3f.

Reason for revert: Speculative revert to fix 
MainIntentBehaviorMetricsIntegrationTest#testLaunch_From_InAppActivities, see  https://crbug.com/876463 

Bug:  876463 

Original change's description:
> Remove data use updates from page load metrics
> 
> Now that per-resource updates are sent to page load metrics, we no
> longer need to send totals from the renderer process. Remove all
> piping/callbacks and convert existing consumers to
> OnResourceDataUseObserved.
> 
> Per-resource updates:
> https://chromium-review.googlesource.com/c/chromium/src/+/1164222
> 
> Change-Id: I1cb03df5e6579fc0ff767900336308a6bbad244a
> Reviewed-on: https://chromium-review.googlesource.com/1178324
> Reviewed-by: Charlie Harrison <csharrison@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Commit-Queue: John Delaney <johnidel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#584744}

TBR=kinuko@chromium.org,csharrison@chromium.org,rajendrant@chromium.org,johnidel@chromium.org

Change-Id: I4b750a31c1f0a99b5edd18d7104d1b948913e1c8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1184062
Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584887}
[modify] https://crrev.com/d5a63a645f2979ac862ce626629b14abb6606eec/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
[modify] https://crrev.com/d5a63a645f2979ac862ce626629b14abb6606eec/chrome/browser/page_load_metrics/metrics_web_contents_observer.h
[modify] https://crrev.com/d5a63a645f2979ac862ce626629b14abb6606eec/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc
[modify] https://crrev.com/d5a63a645f2979ac862ce626629b14abb6606eec/chrome/browser/page_load_metrics/observers/data_saver_site_breakdown_metrics_observer.cc
[modify] https://crrev.com/d5a63a645f2979ac862ce626629b14abb6606eec/chrome/browser/page_load_metrics/observers/data_saver_site_breakdown_metrics_observer.h
[modify] https://crrev.com/d5a63a645f2979ac862ce626629b14abb6606eec/chrome/browser/page_load_metrics/observers/noscript_preview_page_load_metrics_observer.cc
[modify] https://crrev.com/d5a63a645f2979ac862ce626629b14abb6606eec/chrome/browser/page_load_metrics/observers/noscript_preview_page_load_metrics_observer.h
[modify] https://crrev.com/d5a63a645f2979ac862ce626629b14abb6606eec/chrome/browser/page_load_metrics/observers/noscript_preview_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/d5a63a645f2979ac862ce626629b14abb6606eec/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc
[modify] https://crrev.com/d5a63a645f2979ac862ce626629b14abb6606eec/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h
[modify] https://crrev.com/d5a63a645f2979ac862ce626629b14abb6606eec/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_tester.cc
[modify] https://crrev.com/d5a63a645f2979ac862ce626629b14abb6606eec/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_tester.h
[modify] https://crrev.com/d5a63a645f2979ac862ce626629b14abb6606eec/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
[modify] https://crrev.com/d5a63a645f2979ac862ce626629b14abb6606eec/chrome/browser/page_load_metrics/page_load_metrics_observer.h
[modify] https://crrev.com/d5a63a645f2979ac862ce626629b14abb6606eec/chrome/browser/page_load_metrics/page_load_metrics_test_waiter.cc
[modify] https://crrev.com/d5a63a645f2979ac862ce626629b14abb6606eec/chrome/browser/page_load_metrics/page_load_metrics_test_waiter.h
[modify] https://crrev.com/d5a63a645f2979ac862ce626629b14abb6606eec/chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.cc
[modify] https://crrev.com/d5a63a645f2979ac862ce626629b14abb6606eec/chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.h
[modify] https://crrev.com/d5a63a645f2979ac862ce626629b14abb6606eec/chrome/browser/page_load_metrics/page_load_tracker.cc
[modify] https://crrev.com/d5a63a645f2979ac862ce626629b14abb6606eec/chrome/browser/page_load_metrics/page_load_tracker.h
[modify] https://crrev.com/d5a63a645f2979ac862ce626629b14abb6606eec/chrome/common/page_load_metrics/page_load_metrics.mojom
[modify] https://crrev.com/d5a63a645f2979ac862ce626629b14abb6606eec/chrome/renderer/page_load_metrics/fake_page_timing_sender.cc
[modify] https://crrev.com/d5a63a645f2979ac862ce626629b14abb6606eec/chrome/renderer/page_load_metrics/fake_page_timing_sender.h
[modify] https://crrev.com/d5a63a645f2979ac862ce626629b14abb6606eec/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
[modify] https://crrev.com/d5a63a645f2979ac862ce626629b14abb6606eec/chrome/renderer/page_load_metrics/metrics_render_frame_observer.h
[modify] https://crrev.com/d5a63a645f2979ac862ce626629b14abb6606eec/chrome/renderer/page_load_metrics/page_resource_data_use.cc
[modify] https://crrev.com/d5a63a645f2979ac862ce626629b14abb6606eec/chrome/renderer/page_load_metrics/page_resource_data_use.h
[modify] https://crrev.com/d5a63a645f2979ac862ce626629b14abb6606eec/chrome/renderer/page_load_metrics/page_timing_metrics_sender.cc
[modify] https://crrev.com/d5a63a645f2979ac862ce626629b14abb6606eec/chrome/renderer/page_load_metrics/page_timing_metrics_sender.h
[modify] https://crrev.com/d5a63a645f2979ac862ce626629b14abb6606eec/chrome/renderer/page_load_metrics/page_timing_metrics_sender_unittest.cc
[modify] https://crrev.com/d5a63a645f2979ac862ce626629b14abb6606eec/chrome/renderer/page_load_metrics/page_timing_sender.h

Status: Fixed (was: Available)
Succeeded since 2592: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/2592
I don't think https://chromium-review.googlesource.com/c/chromium/src/+/1178324 was the cause of the failing test. Build 2592 succeeded without the reversion in the patch. The reversion was new to 2593. This test is still flaky on newer builds (2615/2614/...) if you check the flakiness links on chrome_public_test_apk.



Project Member

Comment 5 by bugdroid1@chromium.org, Aug 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39aaf8ede2dfb0b4779cdf1ef7c555ab9a715cdd

commit 39aaf8ede2dfb0b4779cdf1ef7c555ab9a715cdd
Author: John Delaney <johnidel@chromium.org>
Date: Thu Aug 23 19:38:21 2018

Reland "Remove data use updates from page load metrics"

This is a reland of 66ce35f8440ce92535f78f37579724774c687f3f

Reverted in :
https://chromium-review.googlesource.com/c/chromium/src/+/1184062

See :  https://crbug.com/876463 

Build #2592 succeeded without reversion and test seems flaky in
more recent builds (#2608). Not believed to be the cause of the failing
test.

TBR=kinuko@chromium.org

Original change's description:
> Remove data use updates from page load metrics
>
> Now that per-resource updates are sent to page load metrics, we no
> longer need to send totals from the renderer process. Remove all
> piping/callbacks and convert existing consumers to
> OnResourceDataUseObserved.
>
> Per-resource updates:
> https://chromium-review.googlesource.com/c/chromium/src/+/1164222
>
> Change-Id: I1cb03df5e6579fc0ff767900336308a6bbad244a
> Reviewed-on: https://chromium-review.googlesource.com/1178324
> Reviewed-by: Charlie Harrison <csharrison@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Commit-Queue: John Delaney <johnidel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#584744}

Change-Id: Ifdc90e57677eb214e404616a41242d5fc1fa64a0
Bug:  876463 
Reviewed-on: https://chromium-review.googlesource.com/1185101
Commit-Queue: John Delaney <johnidel@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585576}
[modify] https://crrev.com/39aaf8ede2dfb0b4779cdf1ef7c555ab9a715cdd/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
[modify] https://crrev.com/39aaf8ede2dfb0b4779cdf1ef7c555ab9a715cdd/chrome/browser/page_load_metrics/metrics_web_contents_observer.h
[modify] https://crrev.com/39aaf8ede2dfb0b4779cdf1ef7c555ab9a715cdd/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc
[modify] https://crrev.com/39aaf8ede2dfb0b4779cdf1ef7c555ab9a715cdd/chrome/browser/page_load_metrics/observers/data_saver_site_breakdown_metrics_observer.cc
[modify] https://crrev.com/39aaf8ede2dfb0b4779cdf1ef7c555ab9a715cdd/chrome/browser/page_load_metrics/observers/data_saver_site_breakdown_metrics_observer.h
[modify] https://crrev.com/39aaf8ede2dfb0b4779cdf1ef7c555ab9a715cdd/chrome/browser/page_load_metrics/observers/noscript_preview_page_load_metrics_observer.cc
[modify] https://crrev.com/39aaf8ede2dfb0b4779cdf1ef7c555ab9a715cdd/chrome/browser/page_load_metrics/observers/noscript_preview_page_load_metrics_observer.h
[modify] https://crrev.com/39aaf8ede2dfb0b4779cdf1ef7c555ab9a715cdd/chrome/browser/page_load_metrics/observers/noscript_preview_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/39aaf8ede2dfb0b4779cdf1ef7c555ab9a715cdd/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc
[modify] https://crrev.com/39aaf8ede2dfb0b4779cdf1ef7c555ab9a715cdd/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h
[modify] https://crrev.com/39aaf8ede2dfb0b4779cdf1ef7c555ab9a715cdd/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_tester.cc
[modify] https://crrev.com/39aaf8ede2dfb0b4779cdf1ef7c555ab9a715cdd/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_tester.h
[modify] https://crrev.com/39aaf8ede2dfb0b4779cdf1ef7c555ab9a715cdd/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
[modify] https://crrev.com/39aaf8ede2dfb0b4779cdf1ef7c555ab9a715cdd/chrome/browser/page_load_metrics/page_load_metrics_observer.h
[modify] https://crrev.com/39aaf8ede2dfb0b4779cdf1ef7c555ab9a715cdd/chrome/browser/page_load_metrics/page_load_metrics_test_waiter.cc
[modify] https://crrev.com/39aaf8ede2dfb0b4779cdf1ef7c555ab9a715cdd/chrome/browser/page_load_metrics/page_load_metrics_test_waiter.h
[modify] https://crrev.com/39aaf8ede2dfb0b4779cdf1ef7c555ab9a715cdd/chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.cc
[modify] https://crrev.com/39aaf8ede2dfb0b4779cdf1ef7c555ab9a715cdd/chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.h
[modify] https://crrev.com/39aaf8ede2dfb0b4779cdf1ef7c555ab9a715cdd/chrome/browser/page_load_metrics/page_load_tracker.cc
[modify] https://crrev.com/39aaf8ede2dfb0b4779cdf1ef7c555ab9a715cdd/chrome/browser/page_load_metrics/page_load_tracker.h
[modify] https://crrev.com/39aaf8ede2dfb0b4779cdf1ef7c555ab9a715cdd/chrome/common/page_load_metrics/page_load_metrics.mojom
[modify] https://crrev.com/39aaf8ede2dfb0b4779cdf1ef7c555ab9a715cdd/chrome/renderer/page_load_metrics/fake_page_timing_sender.cc
[modify] https://crrev.com/39aaf8ede2dfb0b4779cdf1ef7c555ab9a715cdd/chrome/renderer/page_load_metrics/fake_page_timing_sender.h
[modify] https://crrev.com/39aaf8ede2dfb0b4779cdf1ef7c555ab9a715cdd/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
[modify] https://crrev.com/39aaf8ede2dfb0b4779cdf1ef7c555ab9a715cdd/chrome/renderer/page_load_metrics/metrics_render_frame_observer.h
[modify] https://crrev.com/39aaf8ede2dfb0b4779cdf1ef7c555ab9a715cdd/chrome/renderer/page_load_metrics/page_resource_data_use.cc
[modify] https://crrev.com/39aaf8ede2dfb0b4779cdf1ef7c555ab9a715cdd/chrome/renderer/page_load_metrics/page_resource_data_use.h
[modify] https://crrev.com/39aaf8ede2dfb0b4779cdf1ef7c555ab9a715cdd/chrome/renderer/page_load_metrics/page_timing_metrics_sender.cc
[modify] https://crrev.com/39aaf8ede2dfb0b4779cdf1ef7c555ab9a715cdd/chrome/renderer/page_load_metrics/page_timing_metrics_sender.h
[modify] https://crrev.com/39aaf8ede2dfb0b4779cdf1ef7c555ab9a715cdd/chrome/renderer/page_load_metrics/page_timing_metrics_sender_unittest.cc
[modify] https://crrev.com/39aaf8ede2dfb0b4779cdf1ef7c555ab9a715cdd/chrome/renderer/page_load_metrics/page_timing_sender.h

org.chromium.chrome.browser.metrics.MainIntentBehaviorMetricsIntegrationTest#testLaunch_From_InAppActivities has not failed since the re-land in build 2619.

Sign in to add a comment