Page Icons Use the Wrong Color in the Omnibox |
|||||||||
Issue descriptionSee screenshot. The Favorite button icon color is different from the other two.
,
Aug 21
,
Aug 22
Seems to look correct on my machine. What platform did you get your screenshot from?
,
Aug 22
Nevermind, I see this now on Material Design On.
,
Aug 27
,
Aug 28
I'll take a look at this.
,
Aug 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1df63fa89627c6e34cd5d54c345fbe1f1df21930 commit 1df63fa89627c6e34cd5d54c345fbe1f1df21930 Author: Tommy C. Li <tommycli@chromium.org> Date: Wed Aug 29 20:34:02 2018 Omnibox: Make content setting icons use same color as page action icons Previously, we were not setting the color of content setting icons. In the pre-Material world, this just worked well enough that no one noticed apparently. After this CL, the content setting icons will have the same color set as the other page action icons. Bug: 876458 Change-Id: Ifec3601478ceb3e65ac999806558416dfe076401 Reviewed-on: https://chromium-review.googlesource.com/1195721 Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#587280} [modify] https://crrev.com/1df63fa89627c6e34cd5d54c345fbe1f1df21930/chrome/browser/ui/views/location_bar/location_bar_view.cc
,
Sep 13
,
Sep 20
,
Sep 26
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by robliao@chromium.org
, Aug 21