Issue metadata
Sign in to add a comment
|
Background tabs in inactive windows are not transparent |
||||||||||||||||||||||
Issue descriptionSee the attached image. Background tabs in GTK should always blend in with the frame (they should be 100% transparent). Version: Google Chrome 70.0.3521.2 dev GTK Theme: Arc-Dark
,
Aug 22
Requesting merge of CL in c#1 to M69. The CL should be safe and only affects Linux.
,
Aug 22
This bug requires manual review: We are only 12 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 22
Pls update bug with canary result tomorrow. Also may I pls know why multiple merge requests coming this late in release cycle?
,
Aug 22
I'm sure you're aware already, but there were some large UI changes targeted for M69. We just keep finding new bugs with the new design so we keep having to fix them ¯\_(ツ)_/¯ This bug is fairly minor, however.
,
Aug 22
Yeah, understood. I'm just trying to minimize the merges as we're getting very close to stable promotion. As per comment #2, this is safe and only affects Linux so I will approve the merge after you verify it on canary tomorrow. Thank you.
,
Aug 22
The NextAction date has arrived: 2018-08-22
,
Aug 22
Verified on 70.0.3530.0
,
Aug 22
Approving merge to M69 branch 3497 based on comment #8. Pls merge now. Thank you.
,
Aug 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e2f9357845d0017c772c572273e3739513578ef2 commit e2f9357845d0017c772c572273e3739513578ef2 Author: Tom Anderson <thomasanderson@chromium.org> Date: Wed Aug 22 18:52:54 2018 [Merge to M69] GTK: Supply COLOR_BACKGROUND_TAB* theme colors > BUG= 876451 > R=pkasting > > Change-Id: I2be8079b64ef0f05fbb740dc99562f44a1734fab > Reviewed-on: https://chromium-review.googlesource.com/1184045 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584928} BUG= 876451 TBR=pkasting NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Change-Id: I30bd568bcce68f893ebf5e4e4efefe1de73e1647 Reviewed-on: https://chromium-review.googlesource.com/1185530 Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#774} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/e2f9357845d0017c772c572273e3739513578ef2/chrome/browser/ui/libgtkui/gtk_ui.cc
,
Aug 22
,
Aug 23
Tried testing the issue on ubuntu 17.10 using chrome version #69.0.3497.57 as per the comment #0. Attaching screen cast for reference. Did not observe any difference in chrome reported version #70.0.3521.2 and chrome version #69.0.3497.57. Observed that background inactive tabs are 100% transparent in both the versions. thomasanderson@ - Could you please check the attached screen cast and please let us know if anything missed from our end in verifying the fix. Thanks...!!
,
Aug 23
Please see c#8 for the verification
,
Aug 23
Verified on 69.0.3497.57 Beta |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Aug 21