New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 876448 link

Starred by 1 user
Status: Fixed
Owner:
jamescook@chromium.org
Closed: Aug 23
Cc:
█ zhelfins@chromium.org
msw@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

CrOS Shortcut Viewer a11y: unable to dictate into the search box

Project Member Reported by leberly@chromium.org, Aug 21 
70.0.3524.2 (Official Build) canary (64-bit)
Google_Eve.9584.160.0

Steps to repro:
# Enable dictation via Settings > Manage Accessibility Settings
# Open Shortcuts using ctrl + alt + /
# Put focus into the search box
# Press ctrl + d to start dictation, say a word
Expected: when dictation turns off, word is entered into search box
Actual: dictated words are never entered into this box

Comment 2 by leberly@chromium.org, Aug 22

Status: WontFix (was: Available)

Checking again with flag disabled: 

70.0.3524.2 (Official Build) canary (64-bit)
Google_Eve.9584.160.0
#ash-keyboard-shortcut-viewer-app set to 'Disabled' 

Does not reproduce using above steps; closing as WontFix.

Comment 3 by leberly@chromium.org, Aug 22

Status: Available (was: WontFix)
Actually, reopening since I'll let the team decide whether or not to close this bug based on the above finding.

Comment 4 by msw@chromium.org, Aug 22

Cc: msw@chromium.org
Labels: Proj-Mash-KSV

Comment 5 by jamescook@chromium.org, Aug 23

Owner: jamescook@chromium.org
Status: Started (was: Available)
This might be a general remote app issue, so taking a look...
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cae5f8710a9652a6f1716812fbedfdd59fced679

commit cae5f8710a9652a6f1716812fbedfdd59fced679
Author: James Cook <jamescook@chromium.org>
Date: Thu Aug 23 22:12:01 2018

chromeos: Fix dictation into keyboard shortcut viewer app

Chrome creates a second InputMethodChromeOS when a remote mojo app
opens. This sets a new IMEInputContextHandler on IMEBridge, but does
not trigger an "engine switch".

Make sure the dictation code looks up the current IMEInputContextHandler
each time it tries to inject text.

Bug:  876448 
Test: added to interactive_ui_tests
Change-Id: I100a62920ffb397ec823a4bcddb1adf94ec5f6a3
Reviewed-on: https://chromium-review.googlesource.com/1187135
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585632}
[modify] https://crrev.com/cae5f8710a9652a6f1716812fbedfdd59fced679/chrome/browser/chromeos/accessibility/dictation_chromeos.cc
[modify] https://crrev.com/cae5f8710a9652a6f1716812fbedfdd59fced679/chrome/browser/chromeos/accessibility/dictation_chromeos.h
[modify] https://crrev.com/cae5f8710a9652a6f1716812fbedfdd59fced679/chrome/browser/chromeos/accessibility/dictation_chromeos_browsertest.cc

Comment 7 by jamescook@chromium.org, Aug 23

Status: Fixed (was: Started)
►

Sign in to add a comment