New issue
Advanced search Search tips

Issue 876440 link

Starred by 0 users
Status: Fixed
Owner:
newcomer@chromium.org
Closed: Nov 19
Cc:
xiy...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: ----



Sign in to add a comment

App icons in AppList are in a strange state after multi touching while showing a menu.

Project Member Reported by newcomer@chromium.org, Aug 21 
Chrome Version: 70.0.3530.0

What steps will reproduce the problem?
(1) Long press an app icon to show a menu in the applist or shelf.
(2) Without removing the finger, tap another are of the screen a few times.

What is the expected result?
Nothing.

What happens instead?
The menu dissapears and the icon remains enlarged. The drag state machine has been disrupted after the multi-touch fix.

We just need to re-think some of the drag code in AppsGridView and AppListView after the fix for the multi-touch bug.

Comment 1 by xiy...@chromium.org, Aug 21 

With https://chromium-review.googlesource.com/1179250, when the 2nd finger touch down and up, it generates a GESTURE_END and should stop the touch dragging (i.e. icon should scale down and appear to be dropped).

I could somehow repro your case by doing many taps quickly on the 2nd finger and sometime I ended up in that state. Not sure what happened. Sounds like GESTURE_END promise is broken (as it should be sent for every finger touch).

Comment 2 by newcomer@chromium.org, Aug 28

Labels: -M-70 M-71
Hard to repro, so moving to M-71. Will merge this one if we have time.

Comment 3 by newcomer@chromium.org, Oct 30

Labels: -M-71 M-72
Punting because we haven't seen any more reports on this. It still exists in M-71 but it's not easy.
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2976ff8722e8436e3a7e26a708d5adcf07d290e

commit c2976ff8722e8436e3a7e26a708d5adcf07d290e
Author: Alex Newcomer <newcomer@chromium.org>
Date: Fri Nov 16 23:48:29 2018

cros: Fix launcher drag state after multi touch menu dismissal

Handle the case where the menu is not dismissed due to a drag sequence.
This was not handled gracefully, and resulted in a bad drag state on the
app icon.

finger. Then touch the screen somewhere else.

Example: Show a menu on an app icon via long press, don't release the
Bug:  876440 
Change-Id: I8ebde0669aec7b7925fb1c855008cbfbaa8b3683
Reviewed-on: https://chromium-review.googlesource.com/c/1340822
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609027}
[modify] https://crrev.com/c2976ff8722e8436e3a7e26a708d5adcf07d290e/ash/app_list/views/app_list_item_view.cc
[modify] https://crrev.com/c2976ff8722e8436e3a7e26a708d5adcf07d290e/ash/app_list/views/app_list_item_view.h

Comment 5 by newcomer@chromium.org, Nov 19

Status: Fixed (was: Started)
►

Sign in to add a comment