New issue
Advanced search Search tips

Issue 876425 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 28
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

ios_chrome_ui_egtests (iPad Air iOS 10.3) on Mac failing on internal.bling.main/ipad10-simulator-x64

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Aug 21

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of skym@chromium.org

ios_chrome_ui_egtests (iPad Air iOS 10.3) on Mac failing on internal.bling.main/ipad10-simulator-x64

Builders failed on: 
- ipad10-simulator-x64: 
  https://ci.chromium.org/buildbot/internal.bling.main/ipad10-simulator-x64


 
First failing build: https://ci.chromium.org/buildbot/internal.bling.main/iphone10-simulator-x64/14445
Failure seems to be translate related:
	1   ios_chrome_external_url_egtests     0x00000001061774d5 -[TranslateTestCase testAutoTranslate] + 5669

Only included CL: https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/664888
But that is a DEPS roll, so let's look at what's in it:

> git log --name-only 0cd13efcb6b67e59bdc5911226455bab13560167..af5475b887c46f2261cdc098b2e272274e57c9a9

Includes https://chromium-review.googlesource.com/1178691 which is modifying ios translate things.
Cc: jzw@chromium.org
Status: Started (was: Available)
Going to rollback above mentioned CL, but I think we'll have to wait for a DEPS roll before tests go green.
Owner: jzw@chromium.org
Thanks. I'll fix the translate test.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6eee40f586f5e1ad0867b00de834e93fce600b86

commit 6eee40f586f5e1ad0867b00de834e93fce600b86
Author: John Z Wu <jzw@chromium.org>
Date: Wed Aug 22 18:30:13 2018

[Reland] Replace polling with callbacks in translate_ios.js.

This should alleviate flaky errors when translating on iOS.

When translate is tapped, translate_ios.js polls translate.js to wait
for translate element ready and then later polls again to wait for the
translation result. Polling can often time out due to network slowness.

Bug: 869729,  876425 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I237a02bf42fe09af30dab4579c19c32cf1b0edad
Reviewed-on: https://chromium-review.googlesource.com/1178691
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: John Wu <jzw@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#584549}
Reviewed-on: https://chromium-review.googlesource.com/1184102
Cr-Commit-Position: refs/heads/master@{#585176}
[modify] https://crrev.com/6eee40f586f5e1ad0867b00de834e93fce600b86/components/translate/core/browser/resources/translate.js
[modify] https://crrev.com/6eee40f586f5e1ad0867b00de834e93fce600b86/components/translate/ios/browser/ios_translate_driver.h
[modify] https://crrev.com/6eee40f586f5e1ad0867b00de834e93fce600b86/components/translate/ios/browser/ios_translate_driver.mm
[modify] https://crrev.com/6eee40f586f5e1ad0867b00de834e93fce600b86/components/translate/ios/browser/js_translate_manager.h
[modify] https://crrev.com/6eee40f586f5e1ad0867b00de834e93fce600b86/components/translate/ios/browser/js_translate_manager.mm
[modify] https://crrev.com/6eee40f586f5e1ad0867b00de834e93fce600b86/components/translate/ios/browser/resources/translate_ios.js
[modify] https://crrev.com/6eee40f586f5e1ad0867b00de834e93fce600b86/components/translate/ios/browser/translate_controller.h
[modify] https://crrev.com/6eee40f586f5e1ad0867b00de834e93fce600b86/components/translate/ios/browser/translate_controller.mm
[modify] https://crrev.com/6eee40f586f5e1ad0867b00de834e93fce600b86/ios/chrome/browser/translate/translate_egtest.mm

Status: Fixed (was: Started)

Sign in to add a comment