New issue
Advanced search Search tips

Issue 876403 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 29
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 737777



Sign in to add a comment

devtool remote device inspect position is wrong after enabling use-zoom-for-dsf

Project Member Reported by eirage@chromium.org, Aug 21

Issue description

after enabling use-zoom-for-dsf, devtool remote device inspect element are highlighting elements at the wrong position

 
Blocking: 737777
Cc: vkuzkokov@chromium.org
 Issue 875346  has been merged into this issue.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ac34f5dc71728cb7cfde16f504526095d022778

commit 0ac34f5dc71728cb7cfde16f504526095d022778
Author: Ella Ge <eirage@chromium.org>
Date: Wed Aug 29 20:14:15 2018

fix hit test location for remote devtool

1. With use-zoom-for-dsf enabled, root_scroll_offset from metadata
is in physical pixel, it needs to be convert to dip.
2. In blink, the hit test is expecting document point, but x and y
from the devtool front end is in CSS scale. We need to apply the
PageZoomFactor before doing the hit test.

Bug:  876403 
Change-Id: I6cd2f7ecd4d908a6aa986c4d1dfdab7e332355cb
Reviewed-on: https://chromium-review.googlesource.com/1183968
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587268}
[modify] https://crrev.com/0ac34f5dc71728cb7cfde16f504526095d022778/content/browser/devtools/protocol/page_handler.cc
[modify] https://crrev.com/0ac34f5dc71728cb7cfde16f504526095d022778/third_party/blink/renderer/core/inspector/inspector_dom_agent.cc

Status: Fixed (was: Assigned)

Sign in to add a comment