New issue
Advanced search Search tips

Issue 876398 link

Starred by 1 user
Status: Fixed
Owner:
wutao@chromium.org
Closed: Sep 26
Cc:
dtseng@chromium.org
lpalmaro@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

CrOS Shortcut Viewer a11y: overly verbose category names

Project Member Reported by leberly@chromium.org, Aug 21 
70.0.3524.2 (Official Build) canary (64-bit)
Google_Eve.9584.160.0

Steps to repro:
# Start ChromeVox with ctrl + alt + z
# Launch keyboard shortcuts app using ctrl + alt + /
# Use linear navigation to navigate to any list item in a category such as the first item in the Popular Shortcuts list
Expected: just the shortcut is listed, Copy selected content...
Actual: before every list item, the category name Popular Shortcuts is read, creating a confusing experience.

Comment 1 by leberly@chromium.org, Aug 22 

Checking again with flag disabled: 

70.0.3524.2 (Official Build) canary (64-bit)
Google_Eve.9584.160.0
#ash-keyboard-shortcut-viewer-app set to 'Disabled' 

Reproduces per steps above. Keeping bug open.

Comment 2 by leberly@chromium.org, Aug 22

Labels: Proj-Mash-KSV

Comment 3 by jamescook@chromium.org, Aug 22

Labels: -Proj-Mash-KSV
Sorry for the confusion, "mash" means the app version. If it still repros with the app disabled, it's not a "mash" problem.

Comment 4 by afakhry@chromium.org, Sep 7

Owner: wutao@chromium.org
Status: Assigned (was: Available)

Comment 6 by wutao@chromium.org, Sep 11

Cc: wutao@chromium.org
Owner: lpalmaro@chromium.org

Comment 7 by lpalmaro@chromium.org, Sep 14

Cc: -wutao@chromium.org
Owner: wutao@chromium.org
Actually, I'm sorry but I think there was a miscommunication. I didn't intend for "popular shortcuts" to be spoken before every item. Only the shortcut itself should be read here. Can you please take a look at this?
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51fd0b482432b1e69e77b7dbbbc9577ee35da303

commit 51fd0b482432b1e69e77b7dbbbc9577ee35da303
Author: wutao <wutao@chromium.org>
Date: Wed Sep 26 00:10:54 2018

KSV: Fix a11y spoken for shortcut item

Currently spoken of shortcut viewer shortcut item is verbose and has
not seperation between description and shortcut.

This patch fixes the two a11y spoken issues by:
1. Remove category text in each item.
2. Add a punctuation between description and shortcut.

Bug:  876398 ,  876400 
Test: manual.
Change-Id: I42b1558c0e165ad7a25227475309c205b6fdabaa
Reviewed-on: https://chromium-review.googlesource.com/1244158
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594151}
[modify] https://crrev.com/51fd0b482432b1e69e77b7dbbbc9577ee35da303/ash/components/shortcut_viewer/views/keyboard_shortcut_item_view.cc

Comment 9 by wutao@chromium.org, Sep 26

Status: Fixed (was: Assigned)
►

Sign in to add a comment