New issue
Advanced search Search tips

Issue 876383 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
karandeepb@chromium.org
rdevlin....@chromium.org
lazyboy@chromium.org
dbertoni@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 367595



Sign in to add a comment

Extensions: Clean up gn check errors

Project Member Reported by rdevlin....@chromium.org, Aug 21 
GN can check errors for includes/deps/etc.  Currently, there are a lot for //extensions, leading to it being excluded from the checks:

#"//extensions/*",  # Lots of errors.

https://chromium.googlesource.com/chromium/src/+/3890683844d752b78a1614cb87d3fd3aee5a9868/.gn#256

We should fix that.  I'll start by adding some more targets that work, but we'll have to drill down on some of the others.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f5ee77915e339939c43b39b01e73379cbbe43d8

commit 8f5ee77915e339939c43b39b01e73379cbbe43d8
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Tue Aug 21 18:32:34 2018

[Extensions] Add some more extensions targets to gn checks

Add targets that already pass or are trivial to fix to the list of
targets to check in .gn.

Bug: 876383
Change-Id: I08a49ecc2626ce35f54e308eaf5f824f4d8e169c
Reviewed-on: https://chromium-review.googlesource.com/1183690
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584853}
[modify] https://crrev.com/8f5ee77915e339939c43b39b01e73379cbbe43d8/.gn
[modify] https://crrev.com/8f5ee77915e339939c43b39b01e73379cbbe43d8/extensions/common/BUILD.gn
►

Sign in to add a comment