Clean up technical debt left behind from password prompt addition |
|||
Issue descriptionPassword prompt is being added quickly to facilitate dogfood ASAP. This is a tracker bug for any code that needs to be cleaned up post-launch.
,
Aug 21
We definitely have some browser tests to add.
,
Aug 21
I'm placing this bug number in key TODOs, wherever reviewers have nits. The biggest issue so far that needs to be resolved in this bug is to only require authentication for enabling Better Together Suite if the Smart Lock user pref is already enabled.
,
Aug 21
Ryan, please move that last piece to its own bug. That needs to be done by launch, so it should be considered more urgent than just "cleaning up technical debt." Thanks!
,
Aug 21
Good point, done: crbug.com/876436
,
Aug 21
stevenjb@ had some comments on https://chromium-review.googlesource.com/c/chromium/src/+/1179377/6/chrome/browser/resources/settings/controls/password_prompt_dialog.js#89 that I will address in the context of this bug.
,
Sep 20
,
Nov 16
*** UI Mass Triage *** |
|||
►
Sign in to add a comment |
|||
Comment 1 by khorimoto@chromium.org
, Aug 21