New issue
Advanced search Search tips

Issue 876375 link

Starred by 1 user
Status: Fixed
Owner:
jinsuk...@chromium.org
Closed: Aug 29
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug-Regression
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR Iframe tests failing due to JavaScript not running properly

Project Member Reported by bsheedy@chromium.org, Aug 21 
VrBrowserControllerInputTest#testControllerScrollingIframe and VrBrowserControllerInputTest#testControllerClicksRegisterOnIframe have started failing due to not being able to run JavaScript in the iframes.

Looking at logcat output, the following error is repeated every time we try to run JavaScript:

E zygote64: No implementation found for org.chromium.content_public.browser.RenderFrameHost org.chromium.content.browser.test.util.WebContentsUtils.nativeGetFocusedFrame(org.chromium.content_public.browser.WebContents) (tried Java_org_chromium_content_browser_test_util_WebContentsUtils_nativeGetFocusedFrame and Java_org_chromium_content_browser_test_util_WebContentsUtils_nativeGetFocusedFrame__Lorg_chromium_content_1public_browser_WebContents_2)

Suspected culprit is https://chromium-review.googlesource.com/c/chromium/src/+/1180824
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b2f45fc5f1425237ff33e366dd5c12909a489e6

commit 5b2f45fc5f1425237ff33e366dd5c12909a489e6
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Tue Aug 28 06:22:04 2018

Reland "Android: Move more methods to test-only targets"

Relanding https://crrev.com/c/1180824 with following bug fixes:

- |chrome_public_test_vr_apk| was not configured to load the test-only
  native library calling the content native support lib added in the CL.
  Recycles the target |libchromefortest| for vr.
- Neglected the reminder TODO in render_frame_host_android.h. This CL
  deletes it. Also minimizes test code present in the production and
  moves more test code from Java to native (java WebContentsUtil to
  native RenderFrameHostTestEx class).

This reverts commit 3890683844d752b78a1614cb87d3fd3aee5a9868.

Bug: 862153, 875742,  876375 
Change-Id: I93746f36f74f33a93973278dc92890c77b8c2646
Reviewed-on: https://chromium-review.googlesource.com/1184131
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586595}
[modify] https://crrev.com/5b2f45fc5f1425237ff33e366dd5c12909a489e6/chrome/android/BUILD.gn
[modify] https://crrev.com/5b2f45fc5f1425237ff33e366dd5c12909a489e6/chrome/android/javatests/src/org/chromium/chrome/browser/vr/XrTestFramework.java
[modify] https://crrev.com/5b2f45fc5f1425237ff33e366dd5c12909a489e6/content/browser/frame_host/render_frame_host_android.cc
[modify] https://crrev.com/5b2f45fc5f1425237ff33e366dd5c12909a489e6/content/browser/frame_host/render_frame_host_android.h
[modify] https://crrev.com/5b2f45fc5f1425237ff33e366dd5c12909a489e6/content/browser/web_contents/web_contents_android.cc
[modify] https://crrev.com/5b2f45fc5f1425237ff33e366dd5c12909a489e6/content/browser/web_contents/web_contents_android.h
[modify] https://crrev.com/5b2f45fc5f1425237ff33e366dd5c12909a489e6/content/public/android/java/src/org/chromium/content/browser/framehost/RenderFrameHostImpl.java
[modify] https://crrev.com/5b2f45fc5f1425237ff33e366dd5c12909a489e6/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
[modify] https://crrev.com/5b2f45fc5f1425237ff33e366dd5c12909a489e6/content/public/android/java/src/org/chromium/content_public/browser/RenderFrameHost.java
[modify] https://crrev.com/5b2f45fc5f1425237ff33e366dd5c12909a489e6/content/public/android/java/src/org/chromium/content_public/browser/WebContents.java
[modify] https://crrev.com/5b2f45fc5f1425237ff33e366dd5c12909a489e6/content/public/test/android/BUILD.gn
[add] https://crrev.com/5b2f45fc5f1425237ff33e366dd5c12909a489e6/content/public/test/android/javatests/src/org/chromium/content/browser/test/RenderFrameHostTestExt.java
[modify] https://crrev.com/5b2f45fc5f1425237ff33e366dd5c12909a489e6/content/public/test/android/javatests/src/org/chromium/content/browser/test/mock/MockRenderFrameHost.java
[modify] https://crrev.com/5b2f45fc5f1425237ff33e366dd5c12909a489e6/content/public/test/android/javatests/src/org/chromium/content/browser/test/mock/MockWebContents.java
[modify] https://crrev.com/5b2f45fc5f1425237ff33e366dd5c12909a489e6/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/WebContentsUtils.java
[add] https://crrev.com/5b2f45fc5f1425237ff33e366dd5c12909a489e6/content/public/test/android/render_frame_host_test_ext.cc
[add] https://crrev.com/5b2f45fc5f1425237ff33e366dd5c12909a489e6/content/public/test/android/render_frame_host_test_ext.h
[modify] https://crrev.com/5b2f45fc5f1425237ff33e366dd5c12909a489e6/content/public/test/android/web_contents_utils.cc

Comment 2 by bsheedy@chromium.org, Aug 29

Labels: -VR-Caught-By-Test XR-Caught-By-Test

Comment 3 by bsheedy@chromium.org, Aug 29

Status: Fixed (was: Assigned)
►

Sign in to add a comment