New issue
Advanced search Search tips

Issue 876372 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
twelling...@chromium.org
shaktisahu@chromium.org
huayinz@chromium.org
dtrainor@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task

Blocking:
issue 876369



Sign in to add a comment

Introduce res_downloads to chrome/android/java/

Project Member Reported by tedc...@chromium.org, Aug 21 
To provide more autonomy to the downloads team, we should split out their resources into a separate res directory (res_downloads is the proposal) and add their team as the OWNER of it.

This directory is primarily aimed at layouts and we should avoid adding feature specific base styles/colors that will introduce a maintenance burden down the road (hopefully our PRESUBMIT checks would prevent that though).
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 5 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/7f1b1ab78b3e837c930f9d0822809278f7683321

commit 7f1b1ab78b3e837c930f9d0822809278f7683321
Author: Ted Choc <tedchoc@google.com>
Date: Wed Sep 05 22:16:19 2018
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1fbc425017a172fd96232caaeca6d33a2e1eed00

commit 1fbc425017a172fd96232caaeca6d33a2e1eed00
Author: Ted Choc <tedchoc@google.com>
Date: Wed Sep 05 21:48:20 2018

Add a res_download directory.

The initial version focuses on the layouts and initial
styles.  This specifically does not bring over the images yet.

BUG=876372

Change-Id: Ie3b25e2eddcba5c061d8f649874f2d9dd796abc2
Reviewed-on: https://chromium-review.googlesource.com/1194563
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589010}
[modify] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/BUILD.gn
[modify] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/res/values-v17/styles.xml
[add] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/res_download/OWNERS
[rename] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/res_download/layout/confirm_oma_download.xml
[rename] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/res_download/layout/download_home_tabs.xml
[rename] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/res_download/layout/download_home_toolbar.xml
[rename] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/res_download/layout/download_item_view.xml
[rename] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/res_download/layout/download_location_dialog.xml
[rename] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/res_download/layout/download_location_preference.xml
[rename] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/res_download/layout/download_location_preference_item.xml
[rename] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/res_download/layout/download_location_spinner_dropdown_item.xml
[rename] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/res_download/layout/download_location_spinner_item.xml
[rename] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/res_download/layout/download_main.xml
[rename] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/res_download/layout/download_manager_date_item.xml
[rename] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/res_download/layout/download_manager_date_separator.xml
[rename] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/res_download/layout/download_manager_generic_item.xml
[rename] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/res_download/layout/download_manager_image_item.xml
[rename] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/res_download/layout/download_manager_in_progress_item.xml
[rename] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/res_download/layout/download_manager_prefetch_item.xml
[rename] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/res_download/layout/download_manager_section_header.xml
[rename] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/res_download/layout/download_manager_section_separator.xml
[rename] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/res_download/layout/download_manager_spinner.xml
[rename] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/res_download/layout/download_manager_spinner_drop_down.xml
[rename] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/res_download/layout/download_manager_toolbar.xml
[rename] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/res_download/layout/download_manager_ui_space_widget.xml
[rename] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/res_download/layout/download_manager_video_item.xml
[rename] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/res_download/layout/download_storage_summary.xml
[rename] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/res_download/layout/downloads_empty_view.xml
[rename] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/res_download/layout/offline_download_header.xml
[rename] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/res_download/menu/download_manager_menu.xml
[add] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/res_download/values-v17/styles.xml
[modify] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadLocationDialog.java
[modify] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/src/org/chromium/chrome/browser/download/OMADownloadHandler.java
[modify] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/src/org/chromium/chrome/browser/download/home/DownloadManagerCoordinatorImpl.java
[modify] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/src/org/chromium/chrome/browser/download/home/empty/EmptyView.java
[modify] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/src/org/chromium/chrome/browser/download/home/filter/FilterView.java
[modify] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/holder/DateViewHolder.java
[modify] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/holder/GenericViewHolder.java
[modify] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/holder/ImageViewHolder.java
[modify] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/holder/InProgressViewHolder.java
[modify] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/holder/MoreButtonViewHolder.java
[modify] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/holder/PrefetchViewHolder.java
[modify] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/holder/SectionTitleViewHolder.java
[modify] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/holder/SeparatorViewHolder.java
[modify] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/holder/ThumbnailAwareViewHolder.java
[modify] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/holder/VideoViewHolder.java
[modify] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/src/org/chromium/chrome/browser/download/home/storage/StorageCoordinator.java
[modify] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/src/org/chromium/chrome/browser/download/home/toolbar/DownloadHomeToolbar.java
[modify] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapter.java
[modify] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadItemView.java
[modify] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerToolbar.java
[modify] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java
[modify] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/src/org/chromium/chrome/browser/download/ui/FilterAdapter.java
[modify] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/src/org/chromium/chrome/browser/download/ui/OfflineGroupHeaderView.java
[modify] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/src/org/chromium/chrome/browser/download/ui/SpaceDisplay.java
[modify] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/src/org/chromium/chrome/browser/preferences/download/DownloadDirectoryAdapter.java
[modify] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/src/org/chromium/chrome/browser/preferences/download/DownloadLocationPreference.java
[modify] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/java/src/org/chromium/chrome/browser/preferences/download/DownloadLocationPreferenceAdapter.java
[modify] https://crrev.com/1fbc425017a172fd96232caaeca6d33a2e1eed00/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadActivityTest.java
►

Sign in to add a comment