New issue
Advanced search Search tips

Issue 876369 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
twelling...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task

Blocked on: View detail
issue 876372
issue 876373
issue 876376
issue 876378
issue 876483


Sign in to add a comment

[Meta bug] Clean up chrome/android OWNERS structure

Project Member Reported by tedc...@chromium.org, Aug 21 
The chrome/android directory has become unwieldy in it's structure.  We should investigate splitting out separate components, introducing more structure and more OWNERS to all aspects of the directory.

This focuses on primarily the OWNERS issue, but there are some generic refactorings that will be swept up along the way.

Comment 1 by tedc...@chromium.org, Aug 21

Blockedon: 876372

Comment 2 by tedc...@chromium.org, Aug 21

Blockedon: 876373

Comment 3 by tedc...@chromium.org, Aug 21

Blockedon: 876376

Comment 4 by tedc...@chromium.org, Aug 21

Blockedon: 876378

Comment 5 by twelling...@chromium.org, Aug 21

Blockedon: 876483
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf3f9ca1bb88ee897dcc842b8e88b97ca0afbedd

commit cf3f9ca1bb88ee897dcc842b8e88b97ca0afbedd
Author: Ted Choc <tedchoc@google.com>
Date: Wed Aug 22 23:19:52 2018

Make mdjones@ a full owner of toolbar/ in Android.

BUG=876369

Change-Id: I3daff1c0fbec9568edeb987b2f67a8ab168922a3
Reviewed-on: https://chromium-review.googlesource.com/1185912
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585302}
[modify] https://crrev.com/cf3f9ca1bb88ee897dcc842b8e88b97ca0afbedd/chrome/android/java/src/org/chromium/chrome/browser/toolbar/OWNERS
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e774f2119c60822905bbf9840a4b24c52d948c9b

commit e774f2119c60822905bbf9840a4b24c52d948c9b
Author: Ted Choc <tedchoc@google.com>
Date: Thu Aug 23 01:10:09 2018

Introduce ui/android/java/res OWNERS.

Make it the defacto OWNERS directory.

Add mdjones@ and huayinz@ to it.

BUG=876369

Change-Id: I857f0da620c967870c17ddd1b6cacb6a4ae492e4
Reviewed-on: https://chromium-review.googlesource.com/1185918
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585350}
[modify] https://crrev.com/e774f2119c60822905bbf9840a4b24c52d948c9b/chrome/android/java/res/OWNERS
[modify] https://crrev.com/e774f2119c60822905bbf9840a4b24c52d948c9b/content/public/android/java/res/OWNERS
[add] https://crrev.com/e774f2119c60822905bbf9840a4b24c52d948c9b/ui/android/java/res/OWNERS
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8e36a21691657621e085d374fd8ca54dbff4b3a

commit c8e36a21691657621e085d374fd8ca54dbff4b3a
Author: Ted Choc <tedchoc@google.com>
Date: Thu Aug 23 16:40:46 2018

Add chrome/android/java/strings OWNERS

All committers should have the ability to modify strings.

BUG=876369

Change-Id: Ie2d456de05bb6da79b802a408c19ad3d657db187
Reviewed-on: https://chromium-review.googlesource.com/1187007
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585514}
[add] https://crrev.com/c8e36a21691657621e085d374fd8ca54dbff4b3a/chrome/android/java/strings/OWNERS
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9d3c848659e959712cea9cc41a553918e519efa

commit c9d3c848659e959712cea9cc41a553918e519efa
Author: Ted Choc <tedchoc@chromium.org>
Date: Fri Jan 04 00:06:28 2019

Move TabState out of the root package to tab/

BUG=876369

Change-Id: I72d0a94273381ee22cc095d17ab9da27d41f2e9f
Reviewed-on: https://chromium-review.googlesource.com/c/1394931
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619824}
[modify] https://crrev.com/c9d3c848659e959712cea9cc41a553918e519efa/chrome/android/java/src/org/chromium/chrome/browser/NoTouchActivity.java
[modify] https://crrev.com/c9d3c848659e959712cea9cc41a553918e519efa/chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionsTabCreatorManager.java
[modify] https://crrev.com/c9d3c848659e959712cea9cc41a553918e519efa/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabTabPersistencePolicy.java
[modify] https://crrev.com/c9d3c848659e959712cea9cc41a553918e519efa/chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoUtils.java
[modify] https://crrev.com/c9d3c848659e959712cea9cc41a553918e519efa/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
[rename] https://crrev.com/c9d3c848659e959712cea9cc41a553918e519efa/chrome/android/java/src/org/chromium/chrome/browser/tab/TabState.java
[modify] https://crrev.com/c9d3c848659e959712cea9cc41a553918e519efa/chrome/android/java/src/org/chromium/chrome/browser/tab/TabThemeColorHelper.java
[modify] https://crrev.com/c9d3c848659e959712cea9cc41a553918e519efa/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java
[modify] https://crrev.com/c9d3c848659e959712cea9cc41a553918e519efa/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassin.java
[modify] https://crrev.com/c9d3c848659e959712cea9cc41a553918e519efa/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabCreatorManager.java
[modify] https://crrev.com/c9d3c848659e959712cea9cc41a553918e519efa/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java
[modify] https://crrev.com/c9d3c848659e959712cea9cc41a553918e519efa/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersister.java
[modify] https://crrev.com/c9d3c848659e959712cea9cc41a553918e519efa/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabbedModeTabPersistencePolicy.java
[modify] https://crrev.com/c9d3c848659e959712cea9cc41a553918e519efa/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModel.java
[modify] https://crrev.com/c9d3c848659e959712cea9cc41a553918e519efa/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/StorageDelegate.java
[modify] https://crrev.com/c9d3c848659e959712cea9cc41a553918e519efa/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/TabDelegate.java
[modify] https://crrev.com/c9d3c848659e959712cea9cc41a553918e519efa/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
[modify] https://crrev.com/c9d3c848659e959712cea9cc41a553918e519efa/chrome/android/java_sources.gni
[modify] https://crrev.com/c9d3c848659e959712cea9cc41a553918e519efa/chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java
[modify] https://crrev.com/c9d3c848659e959712cea9cc41a553918e519efa/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabTabPersistenceIntegrationTest.java
[modify] https://crrev.com/c9d3c848659e959712cea9cc41a553918e519efa/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabTabPersistencePolicyTest.java
[modify] https://crrev.com/c9d3c848659e959712cea9cc41a553918e519efa/chrome/android/javatests/src/org/chromium/chrome/browser/incognito/IncognitoNotificationServiceTest.java
[modify] https://crrev.com/c9d3c848659e959712cea9cc41a553918e519efa/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java
[rename] https://crrev.com/c9d3c848659e959712cea9cc41a553918e519efa/chrome/android/javatests/src/org/chromium/chrome/browser/tab/TabStateTest.java
[modify] https://crrev.com/c9d3c848659e959712cea9cc41a553918e519efa/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassinTest.java
[modify] https://crrev.com/c9d3c848659e959712cea9cc41a553918e519efa/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/MultiInstanceMigrationTest.java
[modify] https://crrev.com/c9d3c848659e959712cea9cc41a553918e519efa/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/RestoreMigrateTest.java
[modify] https://crrev.com/c9d3c848659e959712cea9cc41a553918e519efa/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabPersistentStoreTest.java
[modify] https://crrev.com/c9d3c848659e959712cea9cc41a553918e519efa/chrome/android/junit/src/org/chromium/chrome/browser/tabmodel/TabPersistentStoreUnitTest.java
[modify] https://crrev.com/c9d3c848659e959712cea9cc41a553918e519efa/chrome/android/junit/src/org/chromium/chrome/browser/tabstate/TabStateUnitTest.java
[modify] https://crrev.com/c9d3c848659e959712cea9cc41a553918e519efa/chrome/browser/BUILD.gn
[modify] https://crrev.com/c9d3c848659e959712cea9cc41a553918e519efa/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/tabmodel/document/MockStorageDelegate.java
[modify] https://crrev.com/c9d3c848659e959712cea9cc41a553918e519efa/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/tabmodel/document/MockTabDelegate.java
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4238a674812b1d4edf5c9dc7b36874a6ca0b15b

commit f4238a674812b1d4edf5c9dc7b36874a6ca0b15b
Author: Ted Choc <tedchoc@chromium.org>
Date: Fri Jan 04 02:14:17 2019

Remove ApplicationInitialization class.

It has a single method, confusing name, and provides little/no
value.  This just inlines the single method into the one call site.

BUG=876369

Change-Id: I8cc09dec289c14764563265e1da7ab41c5e74cf3
Reviewed-on: https://chromium-review.googlesource.com/c/1394928
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619862}
[delete] https://crrev.com/20a5dff5a6f45e5004e00ffb995baff86da2eaab/chrome/android/java/src/org/chromium/chrome/browser/ApplicationInitialization.java
[modify] https://crrev.com/f4238a674812b1d4edf5c9dc7b36874a6ca0b15b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/f4238a674812b1d4edf5c9dc7b36874a6ca0b15b/chrome/android/java_sources.gni
►

Sign in to add a comment