New issue
Advanced search Search tips

Issue 876351 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Move V8 tests out of pool:Chrome

Project Member Reported by bpastene@chromium.org, Aug 21

Issue description

Chrome's trusty pool is currently running tests triggered from V8 bots:
https://chromium-swarm.appspot.com/task?id=3f75ad70a7f58310
https://chromium-swarm.appspot.com/task?id=3f75a40a21fafc10
https://chromium-swarm.appspot.com/task?id=3f759c59be181310
https://chromium-swarm.appspot.com/task?id=3f75a68968507210

Additionally, tests triggered from V8's tryserver runs at pri 28:
https://chromium-swarm.appspot.com/task?id=3f763b83100f4610

While tests from Chrome's CQ runs at pri 30:
https://chromium-swarm.appspot.com/task?id=3f7612f02691a610

So V8 tests take higher precedence over chrome's. We shouldn't be muxing tests like this. Let's keep Chrome's tests in one pool, and V8's in another. Please move V8's tests to a V8-only pool. Spinning up a separate trusty pool should be trivial enough to do via machine provider.
 
Cc: serg...@chromium.org
Owner: machenb...@chromium.org
machenbach / sergiyb - is there some historic reason I've forgotten why you'd have a different priority here? Or a reason to use the chrome pool other than convenience?
Cc: -serg...@chromium.org
Owner: ----
Status: Available (was: Untriaged)
Priority difference is strange. Will change V8.

Using the chrome pool is historical and not trivial to just switch. We benefit from having our core working time in EMEA time zone, which is somewhat complementary to chrome.

In order to split the pools, we'd need our own capacity estimates and MP leases for high/low times. We can work on this as soon as some dev cycles are free.

(V8 label makes this bug visible in our bug queue)
CL for the prio change: https://crrev.com/c/1186586
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/d1d197d3247e8afa446a40f7d1f85a689d0335ac

commit d1d197d3247e8afa446a40f7d1f85a689d0335ac
Author: Michael Achenbach <machenbach@chromium.org>
Date: Thu Aug 23 14:40:22 2018

[V8] Use correct swarming priority on V8 tryserver

Previously, V8 had a code path to allow manual tryjobs with higher priority
than CQ. After the luci migration, the path became dead code and all CQ
tasks were run with too high prio.

This removes the old logic and uses the same priority as in Chromium for
all tryjobs. The requester field seems to be not set anymore but seems to
also not be needed for anything. Neither is the purpose tag. The user
property is None in production tasks, so it's removed here, too.

TBR=dpranke@chromium.org

Bug: 876351
Change-Id: I82f734ae73c8a9bda1d9ee2ad13786fa6d33e7f7
Reviewed-on: https://chromium-review.googlesource.com/1186586
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>

[modify] https://crrev.com/d1d197d3247e8afa446a40f7d1f85a689d0335ac/scripts/slave/recipe_modules/v8/api.py
[modify] https://crrev.com/d1d197d3247e8afa446a40f7d1f85a689d0335ac/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_foobar_rel_ng_triggered_flakes.json
[modify] https://crrev.com/d1d197d3247e8afa446a40f7d1f85a689d0335ac/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_foobar_rel_ng_triggered_failures.json
[modify] https://crrev.com/d1d197d3247e8afa446a40f7d1f85a689d0335ac/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_foobar_rel_ng_triggered_slow_tests.json
[modify] https://crrev.com/d1d197d3247e8afa446a40f7d1f85a689d0335ac/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_foobar_rel_ng_triggered_test_filter.json
[modify] https://crrev.com/d1d197d3247e8afa446a40f7d1f85a689d0335ac/scripts/slave/README.recipes.md
[modify] https://crrev.com/d1d197d3247e8afa446a40f7d1f85a689d0335ac/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_foobar_rel_ng_triggered_triggered_by_cq.json
[modify] https://crrev.com/d1d197d3247e8afa446a40f7d1f85a689d0335ac/scripts/slave/recipes/v8.py
[modify] https://crrev.com/d1d197d3247e8afa446a40f7d1f85a689d0335ac/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_sanitizer_coverage_rel.json
[modify] https://crrev.com/d1d197d3247e8afa446a40f7d1f85a689d0335ac/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_foobar_rel_ng_triggered_positional_extra_flags.json
[delete] https://crrev.com/20294d0ec9f33c119a279431b6a8c589cd20d50e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_foobar_rel_ng_triggered_triggered_by_ts.json

Sign in to add a comment