New issue
Advanced search Search tips

Issue 876348 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Proactive tab freezing and discarding needs a feature flag / developer switch to disable all protections

Project Member Reported by chrisha@chromium.org, Aug 21

Issue description

This will let devs experiment with the feature organically (ie, TabManager driving the state transitions normally) without any heuristic opt-outs being applied.
 
Owner: chrisha@chromium.org
Any idea in which Chrome release we can expect this to be available?
Cc: chrisha@chromium.org
Owner: sebmarchand@chromium.org
Seb, can I hand this off to you to take care of? Basically, we want a feature-flag that disables all "heuristic" protections in CanFreeze/CanDiscard, allowing devs to experiment with lifecycles using a live browser.
Labels: M-71
Sure, I'll take this.
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/494dcbfa7da1c0cd848a12212e096e015be0c024

commit 494dcbfa7da1c0cd848a12212e096e015be0c024
Author: Sebastien Marchand <sebmarchand@chromium.org>
Date: Fri Oct 05 16:56:30 2018

Add a feature flag to disable the proactive discarding protections

Bug:  876348 
Change-Id: Ib932652af7814f421009be79a7e9a1e5413fffd7
Reviewed-on: https://chromium-review.googlesource.com/c/1228505
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597171}
[modify] https://crrev.com/494dcbfa7da1c0cd848a12212e096e015be0c024/chrome/browser/about_flags.cc
[modify] https://crrev.com/494dcbfa7da1c0cd848a12212e096e015be0c024/chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
[modify] https://crrev.com/494dcbfa7da1c0cd848a12212e096e015be0c024/chrome/browser/resource_coordinator/tab_lifecycle_unit.h
[modify] https://crrev.com/494dcbfa7da1c0cd848a12212e096e015be0c024/chrome/browser/resource_coordinator/tab_lifecycle_unit_unittest.cc
[modify] https://crrev.com/494dcbfa7da1c0cd848a12212e096e015be0c024/chrome/browser/resource_coordinator/tab_manager_features.cc
[modify] https://crrev.com/494dcbfa7da1c0cd848a12212e096e015be0c024/chrome/browser/resource_coordinator/tab_manager_features.h
[modify] https://crrev.com/494dcbfa7da1c0cd848a12212e096e015be0c024/chrome/browser/resource_coordinator/tab_manager_features_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment