Issue metadata
Sign in to add a comment
|
When entering fullscreen mode, a blank screen is displayed
Reported by
c.b.ains...@gmail.com,
Aug 21
|
||||||||||||||||||||||
Issue descriptionExample URL: https://eeyo.io/bonnie2 Steps to reproduce the problem: 1. In the Chrome Canary Browser ... 2. Go to https://eeyo.io/bonnie2 3. CLick the screen a few times, until the ">" prompt is seen. 4. type: FULLSCREEN 5. Screen will turn blank. What is the expected behavior? In desktop mode, and on iOS, the "fullscreen" mode should be entered, meaning that the browser bar should disappear from the top of the screen. The text, and image from the screen should be shown. What went wrong? The screen displays white content only, nothing more can be seen, except for the soft keyboard overlay. Does it occur on multiple sites: N/A Is it a problem with a plugin? No Did this work before? Yes Version 68 (non Canary), enters fullscreen mode without the screen disappearing Does this work in other browsers? Yes Chrome version: 70.0.3529.0 Channel: stable OS Version: 9.0 Flash Version: This is related to a whole set of bugs around this issue, including bug https://bugs.chromium.org/p/chromium/issues/detail?id=704070 ... which is also unresolved, even though marked as fixed, as of 21 August, 2018.
,
Aug 22
Try adding width: 100% to your style for html/body.
,
Aug 23
100% for the html / body works. Strangely. But is it not still a bug?
,
Aug 23
Thank you for providing more feedback. Adding the requester to the cc list. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 23
,
Aug 23
Tested the issue in Android and able to reproduce the issue. Steps Followed: 1. Navigated to https://eeyo.io/bonnie2 2. Clicked the screen a few times, until the ">" prompt is seen. 3. typed FULLSCREEN 4. Screen turned blank. Chrome versions tested: 70.0.3530.0(Latest canary) OS: Android 9.0.0 Android Devices: Pixel 2 Using the per-revision bisect providing the bisect results, Good Build - 69.0.3446.0 Bad Build - 69.0.3447.0 CL: https://chromium.googlesource.com/chromium/src/+/14eeb1d5b6369a4fefa57973bf6b646469f72e35 @ dtapuska: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to owner concerned. Adding RB-Stable for M-69, Please remove if this not the case. Please navigate to below link for log's -- go/chrome-androidlogs/876339 Thanks!
,
Aug 23
I don't think this is RBS. Yes it is a regression but we specifically changed a lot of functionality wrt to fullscreen for top layers to match the spec. I'll continue investigating but I don't think we should hold the release for this.
,
Aug 23
,
Aug 23
Adjusting targets as this happens everywhere. I've got a proposed fix in https://chromium-review.googlesource.com/c/chromium/src/+/1186961
,
Aug 23
M69 Stable promotion is coming VERY soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Merge has to happen latest by 1:00 PM PT Monday (08/27/18) in order to make it to next week stable cut. Thank you.
,
Aug 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b80e551ec51c516cd66abe71bd07a672d109f857 commit b80e551ec51c516cd66abe71bd07a672d109f857 Author: Dave Tapuska <dtapuska@chromium.org> Date: Fri Aug 24 14:06:24 2018 Fullscreen elements that were root level elements weren't sized properly. Avoid setting position absolute on top layer elements that are the documentElement. This matches what Firefox does. The root element is special when it is in fullscreen mode because it does not get the style applied that forces its dimensions and position to be fixed. BUG= 876339 Change-Id: I42b18047dc9648585bc279510d66decd6d6a4516 Reviewed-on: https://chromium-review.googlesource.com/1186961 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#585830} [add] https://crrev.com/b80e551ec51c516cd66abe71bd07a672d109f857/third_party/WebKit/LayoutTests/external/wpt/fullscreen/rendering/fullscreen-root-block-size-manual.html [modify] https://crrev.com/b80e551ec51c516cd66abe71bd07a672d109f857/third_party/blink/renderer/core/css/resolver/style_adjuster.cc
,
Aug 24
Change has landed. Need verification before requesting merging.
,
Aug 24
[Auto-generated comment by a script] We noticed that this issue is targeted for M-69; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-69 label, otherwise remove Merge-TBD label. Thanks.
,
Aug 24
Pls update bug with canary result on Monday morning. Thank you.
,
Aug 24
,
Aug 26
Verified fixed in 70.0.3533.0
,
Aug 26
This bug requires manual review: We are only 8 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 27
Approving merge to M69 branch 3497 based on comment #16. Pls merge. Thank you.
,
Aug 27
The NextAction date has arrived: 2018-08-27
,
Aug 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17c350235c1f4004a943df50028f2221df7202c9 commit 17c350235c1f4004a943df50028f2221df7202c9 Author: Dave Tapuska <dtapuska@chromium.org> Date: Mon Aug 27 13:06:19 2018 Fullscreen elements that were root level elements weren't sized properly. Avoid setting position absolute on top layer elements that are the documentElement. This matches what Firefox does. The root element is special when it is in fullscreen mode because it does not get the style applied that forces its dimensions and position to be fixed. BUG= 876339 TBR=dtapuska@chromium.org (cherry picked from commit b80e551ec51c516cd66abe71bd07a672d109f857) Change-Id: I42b18047dc9648585bc279510d66decd6d6a4516 Reviewed-on: https://chromium-review.googlesource.com/1186961 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#585830} Reviewed-on: https://chromium-review.googlesource.com/1190126 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#809} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [add] https://crrev.com/17c350235c1f4004a943df50028f2221df7202c9/third_party/WebKit/LayoutTests/external/wpt/fullscreen/rendering/fullscreen-root-block-size-manual.html [modify] https://crrev.com/17c350235c1f4004a943df50028f2221df7202c9/third_party/blink/renderer/core/css/resolver/style_adjuster.cc
,
Aug 27
Thank you for resolving this, but PLEASE take a look at bug https://bugs.chromium.org/p/chromium/issues/detail?id=704070 , which is NOT resolved (even though marked as resolved). I posted a video demonstrating this is not resolved. Essentially, fullscreen mode is still unusable for my application. It works on Android 9 / Pixel 2, but not fixed for Android 6 / Moto E.
,
Aug 29
Issue is Verified on 69.0.3497.73 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by c.b.ains...@gmail.com
, Aug 21