GpuMode fallback issues reintroduced |
||||
Issue descriptionThere had been this issue with GPU mode fallback that if the GPU process was launched before appropriate fallback mode was determined, it would be launched in pre-fallback mode, messing up different mode crash counts in GpuProcessHost (see issue 869419 ). This has been fixed by ensuring that GpuProcessHost::RecordProcessCrash() (which is responsible for determining the fallback mode) is called before trying to launch the GPU process (r579625). However, r584455 changed GpuProcessHost to use a connection error handler on GpuService to clean up its status. This cleanup can lead to re-launch of GPU process. The problem is that the connection error handler might be called before GpuProcessHost::RecordProcessCrash(), causing the same issues mentioned above.
,
Aug 21
CL to undo the use of connection error handler: https://crrev.com/c/1183696
,
Aug 21
,
Aug 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0cbc3757366de658ac1a366fb7792c4b4517a4a9 commit 0cbc3757366de658ac1a366fb7792c4b4517a4a9 Author: Mohsen Izadi <mohsen@chromium.org> Date: Tue Aug 21 20:21:31 2018 Don't use GpuService's connection error handler in GpuProcessHost The connection error handler set on the GpuService in GpuProcessHost might arrive either before or after GpuProcessHost::OnProcessCrashed(). If it arrives before, it might end up running a new GPU process before OnProcessCrashed() has a chance to fallback to the appropriate GpuMode. This CL essentially reverts the use of connection error handler introduced in r584455 so that we ensure that the new GPU process is not launched before the fallback GPU mode is determined. BUG= 876336 Change-Id: Ie83b0824b45b25c46c2baad3aa55e7f30c8a9113 Reviewed-on: https://chromium-review.googlesource.com/1183696 Reviewed-by: Zhenyao Mo <zmo@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#584886} [modify] https://crrev.com/0cbc3757366de658ac1a366fb7792c4b4517a4a9/content/browser/gpu/gpu_process_host.cc [modify] https://crrev.com/0cbc3757366de658ac1a366fb7792c4b4517a4a9/content/browser/gpu/gpu_process_host.h
,
Aug 21
|
||||
►
Sign in to add a comment |
||||
Comment 1 Deleted