New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 876326 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 28
Components:
EstimatedDays: 2
NextAction: 2018-08-21
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

PersistentAvailabilityStoreTest.TestAllFilterCombinations fails with new protobuf

Project Member Reported by medinaan...@chromium.org, Aug 21

Issue description

Chrome Version: 68.0.3440.106 

When upgrading protobuf to one that include move constructors
this unit test fails:

components_unittests --
gtest_filter=PersistentAvailabilityStoreTest.TestAllFilterCombinations --single-process-tests

../../components/feature_engagement/internal/persistent_availability_store_unittest.cc:248: Failure
Expected equality of these values:
  14u
    Which is: 14
  (*load_results_)[kTestFeatureFoo.name]
    Which is: 0


What steps will reproduce the problem?
1. Get new protobuf from here
https://chromium-review.googlesource.com/c/chromium/src/+/1081411

2. Build and run components_unittests 

What is the expected result?
Should get 14 on line 248 of the test.


What happens instead?
Gets 0.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34f071a6fa809af415f14c4b312ea85de9b35c4a

commit 34f071a6fa809af415f14c4b312ea85de9b35c4a
Author: Andres Medina <medinaandres@google.com>
Date: Wed Aug 22 17:51:40 2018

[feature_engagement] Corrected use after move.

Since current version of protobuf doesn't support move constructors,
this issue is not exposed yet.

Bug:  crbug.com/876326 
Change-Id: Ia107b6ab011f8b59efccfe81617dd494beb14aac
Reviewed-on: https://chromium-review.googlesource.com/1183685
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Andres Medina <medinaandres@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585151}
[modify] https://crrev.com/34f071a6fa809af415f14c4b312ea85de9b35c4a/components/feature_engagement/internal/persistent_availability_store.cc

Status: Fixed (was: Assigned)

Sign in to add a comment