Some of the touch action browser tests is flaky |
||
Issue descriptionPlease refer to the flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests&tests=TouchActionBrowserTest.*
,
Nov 13
,
Nov 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/15d9e1b4f21f71af7212054095ed8335df002664 commit 15d9e1b4f21f71af7212054095ed8335df002664 Author: Xida Chen <xidachen@chromium.org> Date: Mon Nov 19 20:57:08 2018 Bundle white listed touch action into the compositor ack With kCompositorTouchAction turned on, a touch event is acked from the compositor thread instead of the main thread. Then the white listed touch action is sent from the compositor to the browser from a separate IPC. There is a potential race condition here, that the white listed touch action would arrive before or after the ack. It could also happen that the white listed touch action arrives after some gesture events being dispatched, for example, the GSB might have reached the TouchActionFilter while the white listed touch action is not arrived yet. To solve this problem, this CL puts the white listed touch action as a callback parameter, and send it through the ack, to the browser. Bug: 905325 , 876323 Change-Id: Ia9d0bb02b57291d2333f6cfe6959430ff41b5084 Reviewed-on: https://chromium-review.googlesource.com/c/1336071 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#609429} [modify] https://crrev.com/15d9e1b4f21f71af7212054095ed8335df002664/content/browser/renderer_host/input/input_router_impl.cc [modify] https://crrev.com/15d9e1b4f21f71af7212054095ed8335df002664/content/browser/renderer_host/input/input_router_impl.h [modify] https://crrev.com/15d9e1b4f21f71af7212054095ed8335df002664/content/browser/renderer_host/input/input_router_impl_unittest.cc [modify] https://crrev.com/15d9e1b4f21f71af7212054095ed8335df002664/content/browser/renderer_host/input/touch_action_filter.h [modify] https://crrev.com/15d9e1b4f21f71af7212054095ed8335df002664/content/renderer/input/widget_input_handler_manager.cc [modify] https://crrev.com/15d9e1b4f21f71af7212054095ed8335df002664/content/renderer/input/widget_input_handler_manager.h
,
Dec 5
,
Dec 5
This problem has been around for a while. Please disable the flaky tests.
,
Dec 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc4b7196ecbd35a92870ed88bb47b4cd658aff4f commit cc4b7196ecbd35a92870ed88bb47b4cd658aff4f Author: Xida Chen <xidachen@chromium.org> Date: Thu Dec 06 17:12:43 2018 [BrowserTest] Deflake TouchActionBrowserTest In these browser tests, we inject a synthetic gesture scroll, and jank the main thread sometimes, and then check the scroll offset by executing: "document.scrollingElement.scrollTop" and ".scrollLeft" From the resut when it is flaky, it seems that even though the compositor frame's metadata shows that the scroll offset is >= half of the expected scroll offset, the main thread's scroll offset might still smaller than half of the expected scroll offset. This CL makes change to just check that it actually scrolled on the expected axis (from the main thread), instead of checking the scroll offset. Bug: 876323 Change-Id: Ieee6f44304c67e8db89bc4e899ae8e69e8416f33 Reviewed-on: https://chromium-review.googlesource.com/c/1363863 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#614392} [modify] https://crrev.com/cc4b7196ecbd35a92870ed88bb47b4cd658aff4f/content/browser/renderer_host/input/touch_action_browsertest.cc |
||
►
Sign in to add a comment |
||
Comment 1 by xidac...@chromium.org
, Nov 13