New issue
Advanced search Search tips

Issue 876293 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 10
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Picture-in-Picture controls background does not cover the entire video

Project Member Reported by fbeaufort@chromium.org, Aug 21

Issue description

Chrome Version       : 70.0.3524.2
OS Version: 10981.0.0

When screen resolution is not the default one, we can see that controls background doesn't cover entirely the video.

See screenshot attached.
 
Screenshot 2018-08-21 at 3.14.46 PM - Edited.png
204 KB View Download
Owner: fbeaufort@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b17ceb369ee4dceb72fbad82476dd327fafd7cf3

commit b17ceb369ee4dceb72fbad82476dd327fafd7cf3
Author: François Beaufort <beaufort.francois@gmail.com>
Date: Wed Aug 22 18:07:38 2018

Picture-in-Picture controls background covers window.

This CL makes sures when screen resolution is not the default one,
controls background still covers entirely the video. It does so by
adding one pixel in width and height to the size of the controls
background view.

Bug:  876293 
Change-Id: I005e8d0a4fd178a05ab794851c5ae22507a7343f
Reviewed-on: https://chromium-review.googlesource.com/1183486
Reviewed-by: apacible <apacible@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#585163}
[modify] https://crrev.com/b17ceb369ee4dceb72fbad82476dd327fafd7cf3/chrome/browser/ui/views/overlay/overlay_window_views.cc

Status: Fixed (was: Started)

Sign in to add a comment