Regression : Search box spinner keeps spinning forever after searching for a query.
Reported by
avsha...@etouch.net,
Aug 21
|
|||||
Issue descriptionChrome Version : 70.0.3529.0 (Official Build) f36604dbb975d27c686eccb77d02398ba2e3ddde-refs/branch-heads/3529@{#1} 32/64 bit OS : Windows (7, 8, 8.1, 10), Linux(14.04 LTS), Mac(10.12.6, 10.13.1, 10.13.6, 10.14) What steps will reproduce the problem? 1. Launch chrome and navigate to chrome://settings page. 2. Type letter "e" in search box and observe the spinner. Actual Result : Search box spinner keeps spinning forever after searching for a query and matched results are shown even after cancelling search. Expected Result : Spinner should stop once the matching results are found and page should update after clicking on 'Clear search' icon. This is a regression issue broken in ‘M-70’ and below is the per-revision bisect info: Good Build : 70.0.3525.0 (Revision : 583912) Bad Build : 70.0.3526.0 (Revision : 584272) Change Log URL : https://chromium.googlesource.com/chromium/src/+log/f7f385986a69d648d77b0b9f7821e7901df5c90f..00d099ea75e9565afdee5be3f8e4f54eabc7ae0b Suspecting : https://chromium.googlesource.com/chromium/src/+/00d099ea75e9565afdee5be3f8e4f54eabc7ae0b David@ : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note : Issue is not reproducible in Dev #70.0.3521.2 and latest Branch build #69.0.3497.51 Thank you..!
,
Aug 30
droger@ the cause was somewhat related - for each <settings-subpage> there's an associated control that the search needs to know about, and at some point we changed the control that links to the /manageProfile subpage when DICE is enabled, so we needed to update the associated-control attribute accordingly. I made a CL that I'll be landing soon, see it for more detail.
,
Aug 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92dc010b146f4dc52006e74585a40e6382b54825 commit 92dc010b146f4dc52006e74585a40e6382b54825 Author: Scott Chen <scottchen@chromium.org> Date: Thu Aug 30 23:58:29 2018 Settings: fix search's associated control for edit profile subpage A bug occured when searching through settings page, because one of the controls associated with the "edit person" subpage does not exist if DICE is enabled. This CL points it to a different control when DICE is enabled. Bug: 876280 Change-Id: I24049100f2b2357ada85b07a44c893a39fd1b66b Reviewed-on: https://chromium-review.googlesource.com/1198006 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#587862} [modify] https://crrev.com/92dc010b146f4dc52006e74585a40e6382b54825/chrome/browser/resources/settings/people_page/people_page.html [modify] https://crrev.com/92dc010b146f4dc52006e74585a40e6382b54825/chrome/browser/resources/settings/people_page/people_page.js
,
Aug 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f1928dcab7fc3d8b9d8782cb1b6cd45f4d4466ee commit f1928dcab7fc3d8b9d8782cb1b6cd45f4d4466ee Author: Scott Chen <scottchen@chromium.org> Date: Fri Aug 31 00:55:49 2018 Settings: fix settings-subpage breaking search If a settings-subpage doesn't have a valid associated-control attribute value, searching would crash. This CL fixes a couple of those instances. Bug: 876280 Change-Id: I4be99c6d6e29e5019409f0fde056847e68d34d9e Reviewed-on: https://chromium-review.googlesource.com/1197907 Reviewed-by: Esmael El-Moslimany <aee@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#587882} [modify] https://crrev.com/f1928dcab7fc3d8b9d8782cb1b6cd45f4d4466ee/chrome/browser/resources/settings/downloads_page/downloads_page.html [modify] https://crrev.com/f1928dcab7fc3d8b9d8782cb1b6cd45f4d4466ee/chrome/browser/resources/settings/people_page/people_page.html
,
Aug 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3209297c08cdea168140c6bffe09d8433bd56973 commit 3209297c08cdea168140c6bffe09d8433bd56973 Author: Kush Sinha <sinhak@chromium.org> Date: Fri Aug 31 17:42:07 2018 Add crOS Account Manager settings subpage search control Conditionally enabled only when Account Manager feature flag is set. Bug: 876280 , 833797 Change-Id: I4ecdfae67f01ca1dbf227b912d976e901b8fa2b3 Reviewed-on: https://chromium-review.googlesource.com/1199362 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#588076} [modify] https://crrev.com/3209297c08cdea168140c6bffe09d8433bd56973/chrome/browser/resources/settings/people_page/people_page.html
,
Aug 31
,
Sep 3
Update : Tested above issue in latest Canary build #71.0.3541.0 on Mac(10.12.6, 10.13.1 ,10.13.6, 10.14), Windows (7, 8, 8.1, 10) and Linux(14.04 LTS) OS and the issue is fixed. Now Spinner stops accordingly when matching results are found and page updates after clicking on 'Clear search' icon, hence adding TE-Verified labels. Kindly review an attached screen-cast for reference.
,
Oct 18
Issue 896040 has been merged into this issue. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by droger@chromium.org
, Aug 30Owner: scottchen@chromium.org