Regression: Extra space is seen between 'Cancel' and 'Done' buttons on NTP for RTL language.
Reported by
sanyam.g...@etouch.net,
Aug 21
|
||||||||
Issue descriptionChrome Version : 70.0.3529.0 (Official Build) f36604dbb975d27c686eccb77d02398ba2e3ddde-refs/branch-heads/3529@{#1}(32/64-bit) OS: Win(7,8,8.1,10), Mac(10.12.6,10.13.1,10.13.6,10.14), Linux(14.04 LTS) OS Pre-condition: Enable the flag 'Enable using the Google local NTP' and 'New Tab Page Background Selection' from chrome://flags/ Steps to reproduce: 1. Launch Chrome, navigate to 'chrome://settings/languages' and change browser language to 'Arabic'. 2. Open NTP, click on 'Gear' icon on bottom LHS and select 'Chrome Backgrounds'. 3. On 'Chrome Backgrounds' overlay, observe the spacing between 'Cancel' & 'Done' buttons. Actual Result : Extra space is seen between 'Cancel' and 'Done' buttons. Expected Result: Extra space should not be seen between 'Cancel' and 'Done' buttons. This is a regression issue, broken in 'M-70, and below is bisect-info: Good Build: 70.0.3522.0 (Revision:582756) Bad Build : 70.0.3523.0 (Revision:583083) Narrow Bisect info : (Unable to provide bisect using per-revision script,Hence providing bisect with old script): https://chromium.googlesource.com/chromium/src/+log/de901269bda0d336f0777e6df373756ff04451d4..5910043303e3ebe5c5fb2048171de96d4fc8e7a4 Suspecting: r582820 ? @sweilun : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: Issue is reproducible on Mac(10.12.6,10.13.1,10.13.6,10.14) OS by changing the system language to Arabic. Kindly refer the attached screen-cast for reference. Thank You!
,
Aug 22
,
Aug 22
,
Aug 22
,
Aug 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fca76f5d69c78dc7a442a72083afe61ea0579f22 commit fca76f5d69c78dc7a442a72083afe61ea0579f22 Author: Weilun Shi <sweilun@chromium.org> Date: Wed Aug 22 18:09:06 2018 [NTP] Set min width for buttons in custom background dialog Set min width for cancel and done button to make it to fix the extra space shown on rtl mode when the "cancel" and "done" are too short in another language. Bug: 876251 Change-Id: I588ed62bf28249c2078edb10a0d29143041f3d92 Reviewed-on: https://chromium-review.googlesource.com/1184164 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#585165} [modify] https://crrev.com/fca76f5d69c78dc7a442a72083afe61ea0579f22/chrome/browser/resources/local_ntp/custom_backgrounds.css
,
Aug 22
,
Aug 22
,
Aug 22
,
Aug 24
Update : Rechecked the above issue on Win(7,8,8.1,10), Mac(10.12.6,10.13.1,10.13.6,10.14), Linux(14.04 LTS) OS with latest Canary Chrome version : 70.0.3532.0 and the issue is Fixed. Hence adding TE Verified Label. Kindly refer the attached screen cast for reference. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by twelling...@chromium.org
, Aug 21