New issue
Advanced search Search tips

Issue 876233 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

[📍] Provide direct link to benchmark results

Project Member Reported by cbruni@chromium.org, Aug 21

Issue description

Example Pintpoint Job: https://pinpoint-dot-chromeperf.appspot.com/job/179ae676640000

Clicking on "Analyze benchmark results" opens the results.html file inside an iframe which is not the full width and height of the screen.

Given that you already have an inline view of the results.html page on the main pinpoint results page it would make more sense to just point directly to the raw result.html file.
 
Cc: cbruni@chromium.org
Labels: -Type-Bug Type-Feature
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc8fe0364d1fa8c20e308567a0d1a4340d27e046

commit fc8fe0364d1fa8c20e308567a0d1a4340d27e046
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Mon Oct 01 22:31:14 2018

Roll src/third_party/catapult ac93684421fa..69f64b270397 (4 commits)

https://chromium.googlesource.com/catapult.git/+log/ac93684421fa..69f64b270397


git log ac93684421fa..69f64b270397 --date=short --no-merges --format='%ad %ae %s'
2018-10-01 oysteine@google.com Allow bindId for separate begin/end slices as well
2018-10-01 simonhatch@chromium.org Dashboard - Create histograms per bot for alert statistics
2018-10-01 cbruni@chromium.org [pinpoint] Redirect to raw results.html on job completion
2018-10-01 pasko@chromium.org Avoid running Android background jobs


Created with:
  gclient setdep -r src/third_party/catapult@69f64b270397

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:890025 ,chromium:876233, chromium:890424 , chromium:881384 
TBR=sullivan@chromium.org

Change-Id: I3fa5e360f1c7c98152f5078c58d9d41e34b66ebc
Reviewed-on: https://chromium-review.googlesource.com/1254685
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#595601}
[modify] https://crrev.com/fc8fe0364d1fa8c20e308567a0d1a4340d27e046/DEPS

Sign in to add a comment