Issue metadata
Sign in to add a comment
|
compilation issue with Jumbo builds |
||||||||||||||||||||||
Issue description
Compilation settings:
target_os="android"
target_cpu="arm"
enable_nacl=false
symbol_level=0
remove_webcore_debug_symbols=true
is_debug=false
dcheck_always_on=false
is_component_build=false
use_jumbo_build=true
Errors:
In file included from gen/content/browser/browser_jumbo_10.cc:26:
./../../content/browser/media/session/media_session_impl.cc:92:7: error: typedef redefinition with different types ('media_session::mojom::AudioFocusType' vs 'content::AudioFocusType')
using AudioFocusType = media_session::mojom::AudioFocusType;
^
../../content/browser/media/session/audio_focus_delegate_android.h:21:12: note: previous definition is here
enum class AudioFocusType;
^
In file included from gen/content/browser/browser_jumbo_10.cc:26:
./../../content/browser/media/session/media_session_impl.cc:215:33: error: incomplete type 'content::AudioFocusType' named in nested name specifier
required_audio_focus_type = AudioFocusType::kGain;
^~~~~~~~~~~~~~~~
./../../content/browser/media/session/media_session_impl.cc:217:33: error: incomplete type 'content::AudioFocusType' named in nested name specifier
required_audio_focus_type = AudioFocusType::kGainTransientMayDuck;
^~~~~~~~~~~~~~~~
./../../content/browser/media/session/media_session_impl.cc:224:29: error: incomplete type 'content::AudioFocusType' named in nested name specifier
(audio_focus_type_ == AudioFocusType::kGain ||
^~~~~~~~~~~~~~~~
./../../content/browser/media/session/media_session_impl.cc:225:26: error: invalid operands to binary expression ('media_session::mojom::AudioFocusType' and 'content::AudioFocusType')
audio_focus_type_ == required_audio_focus_type)) {
~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~
./../../content/browser/media/session/media_session_impl.cc:231:27: error: cannot initialize a parameter of type 'media_session::mojom::AudioFocusType' with an lvalue of type 'content::AudioFocusType'
RequestSystemAudioFocus(required_audio_focus_type);
^~~~~~~~~~~~~~~~~~~~~~~~~
../../content/browser/media/session/media_session_impl.h:211:44: note: passing argument to parameter 'audio_focus_type' here
media_session::mojom::AudioFocusType audio_focus_type);
^
In file included from gen/content/browser/browser_jumbo_10.cc:26:
./../../content/browser/media/session/media_session_impl.cc:426:31: error: incomplete type 'content::AudioFocusType' named in nested name specifier
audio_focus_type_ == AudioFocusType::kGain &&
^~~~~~~~~~~~~~~~
./../../content/browser/media/session/media_session_impl.cc:576:25: error: incomplete type 'content::AudioFocusType' named in nested name specifier
audio_focus_type_(AudioFocusType::kGainTransientMayDuck),
^~~~~~~~~~~~~~~~
./../../content/browser/media/session/media_session_impl.cc:589:24: error: out-of-line definition of 'RequestSystemAudioFocus' does not match any declaration in 'content::MediaSessionImpl'
bool MediaSessionImpl::RequestSystemAudioFocus(
^~~~~~~~~~~~~~~~~~~~~~~
../../content/browser/media/session/media_session_impl.h:211:7: note: type of 1st parameter of member declaration does not match definition ('media_session::mojom::AudioFocusType' vs 'content::AudioFocusType')
media_session::mojom::AudioFocusType audio_focus_type);
^
In file included from gen/content/browser/browser_jumbo_10.cc:26:
./../../content/browser/media/session/media_session_impl.cc:591:46: error: cannot initialize a parameter of type 'media_session::mojom::AudioFocusType' with an lvalue of type 'content::AudioFocusType'
bool result = delegate_->RequestAudioFocus(audio_focus_type);
^~~~~~~~~~~~~~~~
../../content/browser/media/session/audio_focus_delegate.h:31:44: note: passing argument to parameter 'audio_focus_type' here
media_session::mojom::AudioFocusType audio_focus_type) = 0;
^
In file included from gen/content/browser/browser_jumbo_10.cc:26:
./../../content/browser/media/session/media_session_impl.cc:601:23: error: assigning to 'media_session::mojom::AudioFocusType' from incompatible type 'content::AudioFocusType'
audio_focus_type_ = audio_focus_type;
^~~~~~~~~~~~~~~~
./../../content/browser/media/session/media_session_impl.cc:671:42: error: incomplete type 'content::AudioFocusType' named in nested name specifier
bool success = RequestSystemAudioFocus(AudioFocusType::kGain);
^~~~~~~~~~~~~~~~
./../../content/browser/media/session/media_session_impl.cc:684:32: error: incomplete type 'content::AudioFocusType' named in nested name specifier
if (!RequestSystemAudioFocus(AudioFocusType::kGain))
^~~~~~~~~~~~~~~~
13 errors generated.
Note:
introduced in last two or three days.
suspected CL: https://chromium-review.googlesource.com/c/chromium/src/+/1161500
,
Aug 21
,
Aug 21
,
Aug 21
,
Aug 26
Do you know when it can be fixed? It's 5 days and neither problem was fixed nor patched was reverted.
,
Aug 27
There is a CL out to fix this: https://chromium-review.googlesource.com/c/chromium/src/+/1183885
,
Aug 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a57bb14404e53b823a6cd1a10b8366fcd42f6f34 commit a57bb14404e53b823a6cd1a10b8366fcd42f6f34 Author: Becca Hughes <beccahughes@chromium.org> Date: Mon Aug 27 17:34:20 2018 [Audio Focus] Fix Jumbo builds Fix an issue with duplicate AudioFocusType typedef that breaks Jumbo builds. BUG= 876227 Change-Id: Ic10ecb871d8d1e63093505f63d29bf0b499e6626 Reviewed-on: https://chromium-review.googlesource.com/1183885 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#586296} [modify] https://crrev.com/a57bb14404e53b823a6cd1a10b8366fcd42f6f34/content/browser/media/media_internals_unittest.cc [modify] https://crrev.com/a57bb14404e53b823a6cd1a10b8366fcd42f6f34/content/browser/media/session/audio_focus_delegate_default.cc [modify] https://crrev.com/a57bb14404e53b823a6cd1a10b8366fcd42f6f34/content/browser/media/session/audio_focus_manager.cc [modify] https://crrev.com/a57bb14404e53b823a6cd1a10b8366fcd42f6f34/content/browser/media/session/media_session_impl.cc [modify] https://crrev.com/a57bb14404e53b823a6cd1a10b8366fcd42f6f34/content/browser/media/session/media_session_impl_browsertest.cc
,
Aug 27
,
Aug 27
Please compile tree with settings from #0 before marking this bug as fixed. I receive such errors now:
In file included from gen/content/browser/browser_jumbo_10.cc:26:
./../../content/browser/media/session/media_session_impl.cc:93:29: error: target of using declaration conflicts with declaration already in scope
using media_session::mojom::AudioFocusType;
^
../../content/browser/media/session/audio_focus_delegate_android.h:15:12: note: target of using declaration
enum class AudioFocusType;
^
../../content/browser/media/session/audio_focus_delegate_android.h:21:12: note: conflicting declaration
enum class AudioFocusType;
^
In file included from gen/content/browser/browser_jumbo_10.cc:26:
./../../content/browser/media/session/media_session_impl.cc:216:33: error: incomplete type 'content::AudioFocusType' named in nested name specifier
required_audio_focus_type = AudioFocusType::kGain;
^~~~~~~~~~~~~~~~
./../../content/browser/media/session/media_session_impl.cc:218:33: error: incomplete type 'content::AudioFocusType' named in nested name specifier
required_audio_focus_type = AudioFocusType::kGainTransientMayDuck;
^~~~~~~~~~~~~~~~
./../../content/browser/media/session/media_session_impl.cc:225:29: error: incomplete type 'content::AudioFocusType' named in nested name specifier
(audio_focus_type_ == AudioFocusType::kGain ||
^~~~~~~~~~~~~~~~
./../../content/browser/media/session/media_session_impl.cc:226:26: error: invalid operands to binary expression ('media_session::mojom::AudioFocusType' and 'content::AudioFocusType')
audio_focus_type_ == required_audio_focus_type)) {
~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~
./../../content/browser/media/session/media_session_impl.cc:232:27: error: cannot initialize a parameter of type 'media_session::mojom::AudioFocusType' with an lvalue of type 'content::AudioFocusType'
RequestSystemAudioFocus(required_audio_focus_type);
^~~~~~~~~~~~~~~~~~~~~~~~~
../../content/browser/media/session/media_session_impl.h:214:44: note: passing argument to parameter 'audio_focus_type' here
media_session::mojom::AudioFocusType audio_focus_type);
^
In file included from gen/content/browser/browser_jumbo_10.cc:26:
./../../content/browser/media/session/media_session_impl.cc:427:31: error: incomplete type 'content::AudioFocusType' named in nested name specifier
audio_focus_type_ == AudioFocusType::kGain &&
^~~~~~~~~~~~~~~~
./../../content/browser/media/session/media_session_impl.cc:577:25: error: incomplete type 'content::AudioFocusType' named in nested name specifier
audio_focus_type_(AudioFocusType::kGainTransientMayDuck),
^~~~~~~~~~~~~~~~
./../../content/browser/media/session/media_session_impl.cc:590:24: error: out-of-line definition of 'RequestSystemAudioFocus' does not match any declaration in 'content::MediaSessionImpl'
bool MediaSessionImpl::RequestSystemAudioFocus(
^~~~~~~~~~~~~~~~~~~~~~~
../../content/browser/media/session/media_session_impl.h:214:7: note: type of 1st parameter of member declaration does not match definition ('media_session::mojom::AudioFocusType' vs 'content::AudioFocusType')
media_session::mojom::AudioFocusType audio_focus_type);
^
In file included from gen/content/browser/browser_jumbo_10.cc:26:
./../../content/browser/media/session/media_session_impl.cc:592:46: error: cannot initialize a parameter of type 'media_session::mojom::AudioFocusType' with an lvalue of type 'content::AudioFocusType'
bool result = delegate_->RequestAudioFocus(audio_focus_type);
^~~~~~~~~~~~~~~~
../../content/browser/media/session/audio_focus_delegate.h:31:44: note: passing argument to parameter 'audio_focus_type' here
media_session::mojom::AudioFocusType audio_focus_type) = 0;
^
In file included from gen/content/browser/browser_jumbo_10.cc:26:
./../../content/browser/media/session/media_session_impl.cc:602:23: error: assigning to 'media_session::mojom::AudioFocusType' from incompatible type 'content::AudioFocusType'
audio_focus_type_ = audio_focus_type;
^~~~~~~~~~~~~~~~
./../../content/browser/media/session/media_session_impl.cc:677:42: error: incomplete type 'content::AudioFocusType' named in nested name specifier
bool success = RequestSystemAudioFocus(AudioFocusType::kGain);
^~~~~~~~~~~~~~~~
./../../content/browser/media/session/media_session_impl.cc:690:32: error: incomplete type 'content::AudioFocusType' named in nested name specifier
if (!RequestSystemAudioFocus(AudioFocusType::kGain))
^~~~~~~~~~~~~~~~
13 errors generated.
[8981/11932] CXX obj/content/browser/browser/browser_jumbo_13.o
ninja: build stopped: subcommand failed.
,
Aug 27
There is a pending CL to fix here: https://chromium-review.googlesource.com/c/chromium/src/+/1192118
,
Aug 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f182177005dc6a2c760ff60b2f0ce9483a4b03e commit 2f182177005dc6a2c760ff60b2f0ce9483a4b03e Author: Becca Hughes <beccahughes@chromium.org> Date: Tue Aug 28 17:27:00 2018 [Media Session] Fix Android Jumbo build Fix Android jumbo build. BUG= 876227 Change-Id: Iabe7d634e2019ac15993ac53570b7c20e581549f Reviewed-on: https://chromium-review.googlesource.com/1192118 Reviewed-by: John Rummell <jrummell@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#586765} [modify] https://crrev.com/2f182177005dc6a2c760ff60b2f0ce9483a4b03e/content/browser/media/session/audio_focus_delegate_android.h
,
Aug 28
,
Aug 28
Thank you |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by mar...@mwiacek.com
, Aug 21