New issue
Advanced search Search tips

Issue 876223 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 678905



Sign in to add a comment

WPT: navigation-redirect.https.html is failing

Project Member Reported by falken@chromium.org, Aug 21

Issue description

This is disabled on Windows and has separate -expected.txt files on Mac and Linux.

We should be able to enable the test and have a single -expected.txt file. Investigating that.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8442f319da925e10b9cd8c754d9a44467dd63c29

commit 8442f319da925e10b9cd8c754d9a44467dd63c29
Author: Matt Falkenhagen <falken@chromium.org>
Date: Tue Aug 21 09:54:56 2018

Gardening: Re-enable WPT navigation-redirect.https.html with failing expectation file.

This was disabled on Windows and had separate expectations on Linux and
Mac. It should be able to run on all platforms with a single expectation
file. Attempting that.

Bug: 876223, 757165
Change-Id: I5ea603e037373a6c17edc00a1a14177a8be99a1a
Reviewed-on: https://chromium-review.googlesource.com/1183049
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584702}
[modify] https://crrev.com/8442f319da925e10b9cd8c754d9a44467dd63c29/third_party/WebKit/LayoutTests/TestExpectations
[rename] https://crrev.com/8442f319da925e10b9cd8c754d9a44467dd63c29/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-redirect.https-expected.txt
[delete] https://crrev.com/0b5c2d1f81f8b6ab286dfc051f0aaac3d5feab1b/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-blobs/external/wpt/service-workers/service-worker/navigation-redirect.https-expected.txt
[delete] https://crrev.com/0b5c2d1f81f8b6ab286dfc051f0aaac3d5feab1b/third_party/WebKit/LayoutTests/platform/linux/virtual/outofblink-cors/external/wpt/service-workers/service-worker/navigation-redirect.https-expected.txt
[delete] https://crrev.com/0b5c2d1f81f8b6ab286dfc051f0aaac3d5feab1b/third_party/WebKit/LayoutTests/platform/mac/external/wpt/service-workers/service-worker/navigation-redirect.https-expected.txt

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01378c9226c1e76ef7c5611a14a3544ea3608ab8

commit 01378c9226c1e76ef7c5611a14a3544ea3608ab8
Author: Matt Falkenhagen <falken@chromium.org>
Date: Fri Aug 24 07:20:15 2018

WPT: service worker: Refactor and format navigation-redirect.https.html.

In preparation for extending or modifying the test to test Client.url
and resultingClientId for https://github.com/whatwg/html/pull/3891.

Bug: 876223
Change-Id: I50e8b8c21c5f8639a24a9c2ec00df3ccafdc8ac8
Reviewed-on: https://chromium-review.googlesource.com/1184656
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585738}
[modify] https://crrev.com/01378c9226c1e76ef7c5611a14a3544ea3608ab8/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-redirect.https-expected.txt
[modify] https://crrev.com/01378c9226c1e76ef7c5611a14a3544ea3608ab8/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-redirect.https.html

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f265d393a6510995bca20dd2bb361b6ee6d5d0b

commit 4f265d393a6510995bca20dd2bb361b6ee6d5d0b
Author: Matt Falkenhagen <falken@chromium.org>
Date: Tue Sep 04 09:51:44 2018

WPT: More refactoring navigation-redirect.https.html

This makes the test more extensible. Preparation for adding tests for
the Clients API and resultingClientId. Specifically, the requestInfos
from the workers and the expectations will have a resultingClientId
in addition to the URL.

Bug: 876223,  778497 
Change-Id: Id7c25a77f43f33d40b64ea77c2cf51a0745f57c6
Reviewed-on: https://chromium-review.googlesource.com/1203711
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588479}
[modify] https://crrev.com/4f265d393a6510995bca20dd2bb361b6ee6d5d0b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-redirect.https.html
[modify] https://crrev.com/4f265d393a6510995bca20dd2bb361b6ee6d5d0b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/redirected-response.https.html
[modify] https://crrev.com/4f265d393a6510995bca20dd2bb361b6ee6d5d0b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/navigation-redirect-other-origin.html
[modify] https://crrev.com/4f265d393a6510995bca20dd2bb361b6ee6d5d0b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/redirect-worker.js

Comment 4 Deleted

Comment 5 Deleted

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f328a7f306ae64c0af4f2a4cb5da7f3214f6fc7

commit 4f328a7f306ae64c0af4f2a4cb5da7f3214f6fc7
Author: Matt Falkenhagen <falken@chromium.org>
Date: Thu Sep 27 15:02:01 2018

WPT: service worker: Fix potential race in navigation-redirect.https.html.

Before this CL, the test makes a frame which posts a message to the test
window. But if the test fails, we might not consume the message with
`await` and move on the next test. It's possible the next test gets an
unexpected message from the previous test.

I think a related issue caused the timeout after the Clients variant was
added to the test, since the message handler was created after the frame
was created and it was possible the message arrived after that.

Fix things by explicitly asking the frame for the message when we're
ready for it.

Bug: 876223,  778497 
Change-Id: I82b8685df2977aeadea7475965ecccf69bd33111
Reviewed-on: https://chromium-review.googlesource.com/1249423
Reviewed-by: Ben Kelly <wanderview@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594723}
[modify] https://crrev.com/4f328a7f306ae64c0af4f2a4cb5da7f3214f6fc7/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/navigation-redirect.https.html
[modify] https://crrev.com/4f328a7f306ae64c0af4f2a4cb5da7f3214f6fc7/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/navigation-redirect-out-scope.py
[modify] https://crrev.com/4f328a7f306ae64c0af4f2a4cb5da7f3214f6fc7/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/navigation-redirect-scope1.py
[modify] https://crrev.com/4f328a7f306ae64c0af4f2a4cb5da7f3214f6fc7/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/navigation-redirect-scope2.py

Sign in to add a comment