Picture-in-Picture video should get first eve's play/pause key |
||||||||
Issue descriptionIt would be better in my opinion when user presses the play/pause keyboard key (on eve for instance) to toggle picture-in-picture video play/pause state.
,
Sep 10
WIP at https://chromium-review.googlesource.com/c/chromium/src/+/1217382
,
Sep 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c1ff230d15ee2674428ac50ad7ca1edb1c14494 commit 1c1ff230d15ee2674428ac50ad7ca1edb1c14494 Author: François Beaufort <beaufort.francois@gmail.com> Date: Mon Sep 17 10:44:17 2018 Toggle Picture-in-Picture video play/pause with VK_MEDIA_PLAY_PAUSE This CL makes sure that playback state of Picture-in-Picture video is toggled when user presses the play/pause keyboard key. Bug: 876192 Change-Id: I1346187729b0e7d1ce289345daee995dda907d0f Reviewed-on: https://chromium-review.googlesource.com/1217382 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Becca Hughes <beccahughes@chromium.org> Reviewed-by: apacible <apacible@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#591635} [modify] https://crrev.com/1c1ff230d15ee2674428ac50ad7ca1edb1c14494/chrome/browser/picture_in_picture/DEPS [modify] https://crrev.com/1c1ff230d15ee2674428ac50ad7ca1edb1c14494/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc [modify] https://crrev.com/1c1ff230d15ee2674428ac50ad7ca1edb1c14494/chrome/browser/picture_in_picture/picture_in_picture_window_manager.cc [modify] https://crrev.com/1c1ff230d15ee2674428ac50ad7ca1edb1c14494/chrome/browser/picture_in_picture/picture_in_picture_window_manager.h [modify] https://crrev.com/1c1ff230d15ee2674428ac50ad7ca1edb1c14494/chrome/browser/ui/ash/media_client.cc [modify] https://crrev.com/1c1ff230d15ee2674428ac50ad7ca1edb1c14494/chrome/browser/ui/ash/media_client.h
,
Sep 20
,
Oct 3
,
Oct 3
This bug requires manual review: We are only 12 days from stable. Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 3
This is a P3. Does it really need to be in M70?
,
Oct 4
It would be a nice to have for Chromebook Pixel owners as we're aiming to launch PiP in M70.
,
Oct 4
,
Oct 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a399f2f1b44c5dbf737b9fceea0f24b8846d4055 commit a399f2f1b44c5dbf737b9fceea0f24b8846d4055 Author: François Beaufort <beaufort.francois@gmail.com> Date: Fri Oct 05 08:23:04 2018 Toggle Picture-in-Picture video play/pause with VK_MEDIA_PLAY_PAUSE This CL makes sure that playback state of Picture-in-Picture video is toggled when user presses the play/pause keyboard key. Bug: 876192 Change-Id: I1346187729b0e7d1ce289345daee995dda907d0f Reviewed-on: https://chromium-review.googlesource.com/1217382 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Becca Hughes <beccahughes@chromium.org> Reviewed-by: apacible <apacible@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Original-Commit-Position: refs/heads/master@{#591635}(cherry picked from commit 1c1ff230d15ee2674428ac50ad7ca1edb1c14494) Reviewed-on: https://chromium-review.googlesource.com/c/1264377 Reviewed-by: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/branch-heads/3538@{#870} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/a399f2f1b44c5dbf737b9fceea0f24b8846d4055/chrome/browser/picture_in_picture/DEPS [modify] https://crrev.com/a399f2f1b44c5dbf737b9fceea0f24b8846d4055/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc [modify] https://crrev.com/a399f2f1b44c5dbf737b9fceea0f24b8846d4055/chrome/browser/picture_in_picture/picture_in_picture_window_manager.cc [modify] https://crrev.com/a399f2f1b44c5dbf737b9fceea0f24b8846d4055/chrome/browser/picture_in_picture/picture_in_picture_window_manager.h [modify] https://crrev.com/a399f2f1b44c5dbf737b9fceea0f24b8846d4055/chrome/browser/ui/ash/media_client.cc [modify] https://crrev.com/a399f2f1b44c5dbf737b9fceea0f24b8846d4055/chrome/browser/ui/ash/media_client.h
,
Oct 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a399f2f1b44c5dbf737b9fceea0f24b8846d4055 Commit: a399f2f1b44c5dbf737b9fceea0f24b8846d4055 Author: beaufort.francois@gmail.com Commiter: beaufort.francois@gmail.com Date: 2018-10-05 08:23:04 +0000 UTC Toggle Picture-in-Picture video play/pause with VK_MEDIA_PLAY_PAUSE This CL makes sure that playback state of Picture-in-Picture video is toggled when user presses the play/pause keyboard key. Bug: 876192 Change-Id: I1346187729b0e7d1ce289345daee995dda907d0f Reviewed-on: https://chromium-review.googlesource.com/1217382 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Becca Hughes <beccahughes@chromium.org> Reviewed-by: apacible <apacible@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Original-Commit-Position: refs/heads/master@{#591635}(cherry picked from commit 1c1ff230d15ee2674428ac50ad7ca1edb1c14494) Reviewed-on: https://chromium-review.googlesource.com/c/1264377 Reviewed-by: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/branch-heads/3538@{#870} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by mlamouri@chromium.org
, Aug 21Status: Available (was: Unconfirmed)