New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 876182 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocking:
issue 864904



Sign in to add a comment

desktop-pwas: PendingAppManager or its clients shouldn't try to install apps if they are installed already.

Project Member Reported by ortuno@chromium.org, Aug 21

Issue description

WebAppPolicyManager and ScanForExternalWebApps try to install the same apps on startup. We should either give them a way to check which apps are already installed so they only try to install new apps, or PendingAppManager should skip installing an app if its already installed.
 
Labels: -Pri-3 Pri-2
Labels: M-70
Cc: ortuno@chromium.org
What is the consequence of this not being fixed?

- Does this refer to manual installation when an app has already been policy-installed? Or policy installation when an app has already been policy-installed? Or some other combo(s)?
- Does the user see an attempt to install an already-installed app (like a dialog box), or is it just inefficient / duplicated work internally?

Trying to figure out the priority.
This refers to PendingAppManager clients e.g. default apps, WebAppPolicyManager, etc. always trying to install their apps on startup.

On startup, these clients get a list of apps to install (through policy or a json file) and then try to install them. They don't check if they already installed the app on the last startup; they just keep trying to install their apps every single time the system boots up.
From a discussion with ortuno:

I think this is an issue if the app is already open, while we reinstall it a few seconds after startup, it might close the window as part of reinstall.

We're not sure if that happens. If it does, this is high priority. Otherwise it's a performance hit, but shouldn't otherwise cause any noticeable user problems.
Labels: -Pri-2 Pri-3
P3 because this shouldn't block launch of policy.
Status: Fixed (was: Assigned)
Fixed by https://crrev.com/c/1192462 which is based on nigeltao's https://crrev.com/c/1179115

Sign in to add a comment