ExtensionUpdaterTest.TestMultipleExtensionDownloadingUpdates{Succeed,Fail} start failing |
||
Issue descriptionmxnguyen@, could you take look? It seems the CL[1] causes this. [1] http://crrev.com/c/1180076 Extensions: Add Extensions.UnifiedExtensionUpdaterUpdateServiceErrors histogram. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/15010 [ RUN ] ExtensionUpdaterTest.TestMultipleExtensionDownloadingUpdatesSucceed ../../chrome/browser/extensions/updater/extension_updater_unittest.cc:1837: Failure Value of: tmpfile_path.empty() Actual: true Expected: false Stack trace: 0 unit_tests 0x0000000104de85fb testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 91 1 unit_tests 0x0000000104de7fc9 testing::internal::AssertHelper::operator=(testing::Message const&) const + 89 2 unit_tests 0x00000001043b2865 extensions::ExtensionUpdaterTest::TestMultipleExtensionDownloading(bool) + 2709 ../../chrome/browser/extensions/updater/extension_updater_unittest.cc:1838: Failure Expected equality of these values: id1 Which is: "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa" service.extension_id() Which is: "" [ RUN ] ExtensionUpdaterTest.TestMultipleExtensionDownloadingUpdatesFail ../../chrome/browser/extensions/updater/extension_updater_unittest.cc:1837: Failure Value of: tmpfile_path.empty() Actual: true Expected: false
,
Aug 22
[1] only adds a UMA histogram to the code, it doesn't change how the extension updater behaves. I can't repro the fail test on my machine (I don't have a Mac build, so I only tested it on Windows 10 and Linux). Does the test fail consistently? It's possible that the test is flaky on MacOS, can you retry the test again?
,
Dec 19
Are you still actively looking at this bug? Seeing the same failure today: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/37494
,
Dec 20
No, I'm not. I never see the tests failing on my machines (Windows/Linux).
,
Dec 20
The flakiness dashboard shows lots of "FAIL PASS", e.g. fails the first time and succeeds on the retry. Happening on Windows as well. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=unit_tests&tests=ExtensionUpdaterTest.TestMultipleExtensionDownloadingUpdatesSucceed |
||
►
Sign in to add a comment |
||
Comment 1 by mxnguyen@chromium.org
, Aug 22