New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 876175 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Feature

Blocking:
issue 864904



Sign in to add a comment

desktop-pwas: Add ability to opt-out of shortcut creation to PendingAppManager.

Project Member Reported by ortuno@chromium.org, Aug 21

Issue description

Some clients want shortcuts to be created upon installation and other don't. PendingAppManager should support both.
 
Labels: M-70
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52ee0f607ac3289e5c68ce7c653eb98a220ff6d1

commit 52ee0f607ac3289e5c68ce7c653eb98a220ff6d1
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Fri Aug 24 10:45:29 2018

desktop-pwas: Add option to skip shortcut creation in PendingAppManager

WebAppPolicyManager would like to skip shortcut creation because there
is a separate policy to create them. So we add that option to AppInfo
and plumb it all the way down to BookmarkAppHelper

Bug:  876175 
Change-Id: I09f460efe7c3809856bde77ebe4570de6ae8845e
Reviewed-on: https://chromium-review.googlesource.com/1186220
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585788}
[modify] https://crrev.com/52ee0f607ac3289e5c68ce7c653eb98a220ff6d1/chrome/browser/extensions/bookmark_app_helper.cc
[modify] https://crrev.com/52ee0f607ac3289e5c68ce7c653eb98a220ff6d1/chrome/browser/extensions/bookmark_app_helper.h
[modify] https://crrev.com/52ee0f607ac3289e5c68ce7c653eb98a220ff6d1/chrome/browser/web_applications/bookmark_apps/policy/web_app_policy_manager.cc
[modify] https://crrev.com/52ee0f607ac3289e5c68ce7c653eb98a220ff6d1/chrome/browser/web_applications/bookmark_apps/policy/web_app_policy_manager_unittest.cc
[modify] https://crrev.com/52ee0f607ac3289e5c68ce7c653eb98a220ff6d1/chrome/browser/web_applications/components/pending_app_manager.cc
[modify] https://crrev.com/52ee0f607ac3289e5c68ce7c653eb98a220ff6d1/chrome/browser/web_applications/components/pending_app_manager.h
[modify] https://crrev.com/52ee0f607ac3289e5c68ce7c653eb98a220ff6d1/chrome/browser/web_applications/extensions/bookmark_app_installation_task.cc
[modify] https://crrev.com/52ee0f607ac3289e5c68ce7c653eb98a220ff6d1/chrome/browser/web_applications/extensions/bookmark_app_installation_task_unittest.cc
[modify] https://crrev.com/52ee0f607ac3289e5c68ce7c653eb98a220ff6d1/chrome/browser/web_applications/extensions/pending_bookmark_app_manager_browsertest.cc

Status: Fixed (was: Started)

Sign in to add a comment