Currently we do this based on whether it's a PWA (window) or not (tab).

This is specifically in PendingAppManager right, which should respect what it's told when installing an app by default or by policy? It's separate to installing manually. 

This is specifically in PendingAppManager right, which should respect what it's told when installing an app by default or by policy? It's separate to installing manually. 

Yes this is in PendingAppManager. Currently we ignore the launch_container field, we just open in a window if the app is a PWA and in a tab otherwise.

And yes, it's separate to installing manually.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/598f81e2fc9575fd6b70577a33d18200d9fde65f

commit 598f81e2fc9575fd6b70577a33d18200d9fde65f
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Fri Aug 24 11:10:22 2018

desktop-pwas: Use AppInfo::launch_container during installation

Changed BookmarkAppInstallationTask to set forced_launch_type on the
BookmarkAppHelper used to install the app.

Also adds set_forced_launch_type() to BookmarkAppHelper. When called,
BookmarkAppHelper will ignore the default launch type (window for PWAs,
tabs for non-PWAs) and also the user set launch type if any.

Bug:  876169 
Change-Id: I077570c35c00d3581b404daab7e054615ee7fc2a
Reviewed-on: https://chromium-review.googlesource.com/1188176
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585790}
[modify] https://crrev.com/598f81e2fc9575fd6b70577a33d18200d9fde65f/chrome/browser/extensions/bookmark_app_helper.cc
[modify] https://crrev.com/598f81e2fc9575fd6b70577a33d18200d9fde65f/chrome/browser/extensions/bookmark_app_helper.h
[modify] https://crrev.com/598f81e2fc9575fd6b70577a33d18200d9fde65f/chrome/browser/extensions/bookmark_app_helper_unittest.cc
[modify] https://crrev.com/598f81e2fc9575fd6b70577a33d18200d9fde65f/chrome/browser/web_applications/extensions/bookmark_app_installation_task.cc
[modify] https://crrev.com/598f81e2fc9575fd6b70577a33d18200d9fde65f/chrome/browser/web_applications/extensions/bookmark_app_installation_task_unittest.cc