New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 876168 link

Starred by 1 user
Status: Fixed
Owner:
alancutter@chromium.org
Closed: Aug 27
Cc:
dominickn@chromium.org
█ bgalbs@google.com
pcovell@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

Desktop PWA controls placed incorrectly when maximised

Project Member Reported by alancutter@chromium.org, Aug 21 
Chrome Version: 70
OS: Win10

What steps will reproduce the problem?
(1) Open soft-puppy.glitch.me
(2) App menu > Install Soft Puppy... > Install
(3) Full screen app window.

What is the expected result?

The title and app menu button should be similarly placed as when not maximised.

What happens instead?

The title and app menu button are offset towards the top left.


Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.
fullscreen.png
11.2 KB View Download

Comment 1 by alancutter@chromium.org, Aug 21 

WIP layout fix screenshot.
wiplayout.png
8.5 KB View Download

Comment 2 by alancutter@chromium.org, Aug 23 

Updated screenshots for WIP CL: https://chromium-review.googlesource.com/c/chromium/src/+/1183019/4
before.png
2.8 KB View Download
after.png
3.0 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/484ed22f82cbbee35c787dea089fd1303e8f5f82

commit 484ed22f82cbbee35c787dea089fd1303e8f5f82
Author: Alan Cutter <alancutter@chromium.org>
Date: Fri Aug 24 05:06:22 2018

Fix hosted app button layout when maximized in Windows 10

Hosted app windows using GlassBrowserFrameView (Windows 10 only)
had their controls and title misplaced when maximized.
This CL adds missing padding values to the titlebar layout.

Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=354512&signed_aid=Tmrgizah9A_QhgrbRHXHFQ==&inline=1
After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=354513&signed_aid=h_aEa4bnb7fIu3UutTuNrA==&inline=1

Bug:  876168 ,  872203 
Change-Id: I9e4d3e1ff0776cfba09981cad30a0cfa39469e7c
Reviewed-on: https://chromium-review.googlesource.com/1183019
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585681}
[modify] https://crrev.com/484ed22f82cbbee35c787dea089fd1303e8f5f82/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/484ed22f82cbbee35c787dea089fd1303e8f5f82/chrome/browser/ui/views/frame/glass_browser_frame_view.cc
[modify] https://crrev.com/484ed22f82cbbee35c787dea089fd1303e8f5f82/chrome/browser/ui/views/frame/glass_browser_frame_view.h
[modify] https://crrev.com/484ed22f82cbbee35c787dea089fd1303e8f5f82/chrome/browser/ui/views/frame/glass_browser_frame_view_browsertest_win.cc
[modify] https://crrev.com/484ed22f82cbbee35c787dea089fd1303e8f5f82/chrome/browser/ui/views/frame/hosted_app_button_container.cc
[modify] https://crrev.com/484ed22f82cbbee35c787dea089fd1303e8f5f82/chrome/browser/ui/views/frame/hosted_app_button_container.h
[modify] https://crrev.com/484ed22f82cbbee35c787dea089fd1303e8f5f82/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc

Comment 4 by alancutter@chromium.org, Aug 27

Status: Fixed (was: Assigned)
►

Sign in to add a comment