New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 876163 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 875980


Participants' hotlists:
Better-Together-Launch-Blockers


Sign in to add a comment

Gate Android Messages serviceworker logic behind the user pref

Project Member Reported by jlklein@chromium.org, Aug 21

Issue description

In addition to the feature flag, we need to check the user pref for Android Messages to determine whether or not to try to start the service worker. This will also ensure that we only start it when Better Together setup is complete.
 
Blockedon: 875980
Note: We should use the FeatureState provided by the MultiDeviceSetup service; no code should depend directly on any preference. I am currently working on a fix for issue 875980, which should make it much easier for you to grab the current FeatureState.
Labels: Merge-Request-70
Status: Started (was: Assigned)
Labels: -Merge-Request-70
Only request a merge once your CL has landed.
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9e207bae1ee3a35d46282e69bba9843ebdc9d84

commit a9e207bae1ee3a35d46282e69bba9843ebdc9d84
Author: Azeem Arshad <azeemarshad@chromium.org>
Date: Fri Sep 07 02:17:13 2018

[AndroidSmsService] Gate connection establishing with multidevice feature state.

This change adds logic to retrieve and listen for changes in multidevice
feature state and enables/disables establishing background connection from
service worker approriately.

Bug:  876163 
Change-Id: I593a27f46a793678039ca40a1d0e49e97152c616
Reviewed-on: https://chromium-review.googlesource.com/1208143
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Azeem Arshad <azeemarshad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589411}
[modify] https://crrev.com/a9e207bae1ee3a35d46282e69bba9843ebdc9d84/chrome/browser/chromeos/android_sms/BUILD.gn
[modify] https://crrev.com/a9e207bae1ee3a35d46282e69bba9843ebdc9d84/chrome/browser/chromeos/android_sms/android_sms_service.cc
[modify] https://crrev.com/a9e207bae1ee3a35d46282e69bba9843ebdc9d84/chrome/browser/chromeos/android_sms/android_sms_service_factory.cc
[modify] https://crrev.com/a9e207bae1ee3a35d46282e69bba9843ebdc9d84/chrome/browser/chromeos/android_sms/connection_manager.cc
[modify] https://crrev.com/a9e207bae1ee3a35d46282e69bba9843ebdc9d84/chrome/browser/chromeos/android_sms/connection_manager.h
[modify] https://crrev.com/a9e207bae1ee3a35d46282e69bba9843ebdc9d84/chrome/browser/chromeos/android_sms/connection_manager_unittest.cc
[modify] https://crrev.com/a9e207bae1ee3a35d46282e69bba9843ebdc9d84/content/public/test/fake_service_worker_context.cc
[modify] https://crrev.com/a9e207bae1ee3a35d46282e69bba9843ebdc9d84/content/public/test/fake_service_worker_context.h

Labels: Merge-Request-70
Project Member

Comment 7 by sheriffbot@chromium.org, Sep 8

Labels: -Merge-Request-70 Hotlist-Merge-Approved Merge-Approved-70
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 8

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cde98874e31bd0204bb54ebcb56ba9e8f39c1118

commit cde98874e31bd0204bb54ebcb56ba9e8f39c1118
Author: Azeem Arshad <azeemarshad@chromium.org>
Date: Sat Sep 08 02:51:30 2018

[AndroidSmsService] Gate connection establishing with multidevice feature state.

This change adds logic to retrieve and listen for changes in multidevice
feature state and enables/disables establishing background connection from
service worker approriately.

Bug:  876163 
Change-Id: I593a27f46a793678039ca40a1d0e49e97152c616
Reviewed-on: https://chromium-review.googlesource.com/1208143
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Azeem Arshad <azeemarshad@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#589411}(cherry picked from commit a9e207bae1ee3a35d46282e69bba9843ebdc9d84)
Reviewed-on: https://chromium-review.googlesource.com/1214760
Cr-Commit-Position: refs/branch-heads/3538@{#183}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/cde98874e31bd0204bb54ebcb56ba9e8f39c1118/chrome/browser/chromeos/android_sms/BUILD.gn
[modify] https://crrev.com/cde98874e31bd0204bb54ebcb56ba9e8f39c1118/chrome/browser/chromeos/android_sms/android_sms_service.cc
[modify] https://crrev.com/cde98874e31bd0204bb54ebcb56ba9e8f39c1118/chrome/browser/chromeos/android_sms/android_sms_service_factory.cc
[modify] https://crrev.com/cde98874e31bd0204bb54ebcb56ba9e8f39c1118/chrome/browser/chromeos/android_sms/connection_manager.cc
[modify] https://crrev.com/cde98874e31bd0204bb54ebcb56ba9e8f39c1118/chrome/browser/chromeos/android_sms/connection_manager.h
[modify] https://crrev.com/cde98874e31bd0204bb54ebcb56ba9e8f39c1118/chrome/browser/chromeos/android_sms/connection_manager_unittest.cc
[modify] https://crrev.com/cde98874e31bd0204bb54ebcb56ba9e8f39c1118/content/public/test/fake_service_worker_context.cc
[modify] https://crrev.com/cde98874e31bd0204bb54ebcb56ba9e8f39c1118/content/public/test/fake_service_worker_context.h

Status: Fixed (was: Started)

Sign in to add a comment