Disable drawing separators next to selected tabs when background tab shapes are visible |
||||
Issue descriptionWith background tab shapes visible (e.g. Win 7) try dragging a tab in the middle of the strip around. Note separators on adjacent tabs, which ideally should not be drawn (because the edge of the tab shape is sufficient). This is basically like bug 862438 but slightly less critical to fix.
,
Aug 22
,
Aug 22
Too cosmetic + rare to be merged
,
Aug 22
,
Aug 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/37d9b50058c0cb1da28920eb3b75ecaca2ad38af commit 37d9b50058c0cb1da28920eb3b75ecaca2ad38af Author: Peter Kasting <pkasting@chromium.org> Date: Wed Aug 22 21:16:22 2018 Avoid drawing separators in several cases where tab shapes are visible. Bug: 876149 Test: Multiselect several tabs in the middle of the strip. There should be no separator on either end of the selection region. On Win 7, dragging this set of tabs slightly to one side should show no separator on the end of the stationary tab by the newly-opened gap. Change-Id: I68ebde9909c14683e50e9995ad9938e2cda6a1b3 Reviewed-on: https://chromium-review.googlesource.com/1185379 Reviewed-by: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#585249} [modify] https://crrev.com/37d9b50058c0cb1da28920eb3b75ecaca2ad38af/chrome/browser/ui/views/tabs/tab.cc [modify] https://crrev.com/37d9b50058c0cb1da28920eb3b75ecaca2ad38af/chrome/browser/ui/views/tabs/tab_controller.h [modify] https://crrev.com/37d9b50058c0cb1da28920eb3b75ecaca2ad38af/chrome/browser/ui/views/tabs/tab_strip.cc [modify] https://crrev.com/37d9b50058c0cb1da28920eb3b75ecaca2ad38af/chrome/browser/ui/views/tabs/tab_strip.h [modify] https://crrev.com/37d9b50058c0cb1da28920eb3b75ecaca2ad38af/chrome/browser/ui/views/tabs/tab_unittest.cc |
||||
►
Sign in to add a comment |
||||
Comment 1 by pkasting@chromium.org
, Aug 21Labels: Proj-MdRefresh