New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 876147 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[Findit] Flake Analyzer - Save flakiness result for check in recent build

Project Member Reported by lijeffrey@chromium.org, Aug 21

Issue description

Flakiness in recent builds is checked for when filing bugs, with results saved to the list of data points. They should instead be saved to the MasterFlakeAnalysis separately from the data_point list
 
Owner: lijeffrey@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/e103571a2bc6ceb7b96e085e0c5ffa5c533e9102

commit e103571a2bc6ceb7b96e085e0c5ffa5c533e9102
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Fri Aug 24 22:58:13 2018

[Findit] Flake Analyzer - Save recent check for flakiness in separate data point list

1. Introduce a new field, post_analysis_data_points to MasterFlakeAnalysis to store
   checks for flakiness outside of analyses.
2. Save an error field to DataPoint in case check for flakiness at a recent commit
   encounters unrecoverable errors for surfacing purposes.
3. Append data points for checks in recent commits to the appropriate data point list.
4. Basic cleanup of CreateBugForFlakePipeline

Next steps: UI for displaying recent flakiness separate from the main graph.

Bug:  876147 
Change-Id: I3ee8e193cc27b0d248d369e4399aea598fbc0e80
Reviewed-on: https://chromium-review.googlesource.com/1187840
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>

[modify] https://crrev.com/e103571a2bc6ceb7b96e085e0c5ffa5c533e9102/appengine/findit/pipelines/flake_failure/update_flake_analysis_data_points_pipeline.py
[add] https://crrev.com/e103571a2bc6ceb7b96e085e0c5ffa5c533e9102/appengine/findit/pipelines/flake_failure/save_flakiness_verification_pipeline.py
[modify] https://crrev.com/e103571a2bc6ceb7b96e085e0c5ffa5c533e9102/appengine/findit/pipelines/flake_failure/test/update_flake_analysis_data_points_pipeline_test.py
[add] https://crrev.com/e103571a2bc6ceb7b96e085e0c5ffa5c533e9102/appengine/findit/pipelines/flake_failure/test/save_flakiness_verification_pipeline_test.py
[modify] https://crrev.com/e103571a2bc6ceb7b96e085e0c5ffa5c533e9102/appengine/findit/pipelines/flake_failure/test/create_bug_for_flake_pipeline_test.py
[modify] https://crrev.com/e103571a2bc6ceb7b96e085e0c5ffa5c533e9102/appengine/findit/services/flake_failure/test/data_point_util_test.py
[modify] https://crrev.com/e103571a2bc6ceb7b96e085e0c5ffa5c533e9102/appengine/findit/model/flake/master_flake_analysis.py
[modify] https://crrev.com/e103571a2bc6ceb7b96e085e0c5ffa5c533e9102/appengine/findit/pipelines/flake_failure/analyze_flake_pipeline.py
[modify] https://crrev.com/e103571a2bc6ceb7b96e085e0c5ffa5c533e9102/appengine/findit/pipelines/flake_failure/test/analyze_flake_pipeline_test.py
[modify] https://crrev.com/e103571a2bc6ceb7b96e085e0c5ffa5c533e9102/appengine/findit/pipelines/flake_failure/create_bug_for_flake_pipeline.py
[modify] https://crrev.com/e103571a2bc6ceb7b96e085e0c5ffa5c533e9102/appengine/findit/services/flake_failure/data_point_util.py

Status: Fixed (was: Assigned)

Sign in to add a comment