Triage nag: This Chrome OS bug has an owner but no component. Please add a component so that this can be tracked by the relevant team.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dee4513516e073d4209660898ffaad30d6b206e3

commit dee4513516e073d4209660898ffaad30d6b206e3
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri Nov 09 18:09:37 2018

Move keyboard::SendKeyEvent to ChromeVirtualKeyboardDelegate

This CL moves SendKeyEvent to ChromeVirtualKeyboardDelegate
which is the only place it is used.

It also:
* Uses aura::EventInjector instead of EventSink::OnEventFromSource so
  that events will be injected properly in Mash.
* Removes the undocumented histogram (without documentation it is very
  unlikely that it is used): VirtualKeyboard.KeystrokesBetweenBackspaces

Bug:  876138 
Change-Id: I39836f5593587c32ccb229ca32a2126199500533
Reviewed-on: https://chromium-review.googlesource.com/c/1313208
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Shu Chen <shuchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606899}
[modify] https://crrev.com/dee4513516e073d4209660898ffaad30d6b206e3/chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc
[modify] https://crrev.com/dee4513516e073d4209660898ffaad30d6b206e3/ui/keyboard/keyboard_util.cc
[modify] https://crrev.com/dee4513516e073d4209660898ffaad30d6b206e3/ui/keyboard/keyboard_util.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd1e1a9f7b904ac3e22aef3872da9f7af1272d97

commit fd1e1a9f7b904ac3e22aef3872da9f7af1272d97
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri Nov 09 20:42:38 2018

Move non ash keyboard files to subdirs

This will allow easier restriction of ui/keyboard from src/chrome.

Bug:  876138 
Change-Id: I3db0793734225229b45aec08df9887277dbef491

For trivial header renames in:
chrome/browser/extensions/chrome_component_extension_resource_manager.cc
chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc
chrome/common/extensions/chrome_manifest_url_handlers.cc
TBR=sky@chromium.org

Change-Id: I3db0793734225229b45aec08df9887277dbef491
Reviewed-on: https://chromium-review.googlesource.com/c/1316103
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606957}
[modify] https://crrev.com/fd1e1a9f7b904ac3e22aef3872da9f7af1272d97/ash/app_list/app_list_presenter_delegate_unittest.cc
[modify] https://crrev.com/fd1e1a9f7b904ac3e22aef3872da9f7af1272d97/ash/keyboard/virtual_keyboard_controller.cc
[modify] https://crrev.com/fd1e1a9f7b904ac3e22aef3872da9f7af1272d97/ash/keyboard/virtual_keyboard_controller_unittest.cc
[modify] https://crrev.com/fd1e1a9f7b904ac3e22aef3872da9f7af1272d97/ash/keyboard/virtual_keyboard_unittest.cc
[modify] https://crrev.com/fd1e1a9f7b904ac3e22aef3872da9f7af1272d97/ash/login/ui/login_keyboard_test_base.cc
[modify] https://crrev.com/fd1e1a9f7b904ac3e22aef3872da9f7af1272d97/ash/root_window_controller_unittest.cc
[modify] https://crrev.com/fd1e1a9f7b904ac3e22aef3872da9f7af1272d97/ash/shelf/shelf_widget_unittest.cc
[modify] https://crrev.com/fd1e1a9f7b904ac3e22aef3872da9f7af1272d97/ash/shell_unittest.cc
[modify] https://crrev.com/fd1e1a9f7b904ac3e22aef3872da9f7af1272d97/ash/system/message_center/ash_popup_alignment_delegate_unittest.cc
[modify] https://crrev.com/fd1e1a9f7b904ac3e22aef3872da9f7af1272d97/ash/system/status_area_widget_unittest.cc
[modify] https://crrev.com/fd1e1a9f7b904ac3e22aef3872da9f7af1272d97/ash/system/virtual_keyboard/virtual_keyboard_tray_unittest.cc
[modify] https://crrev.com/fd1e1a9f7b904ac3e22aef3872da9f7af1272d97/ash/wm/always_on_top_controller_unittest.cc
[modify] https://crrev.com/fd1e1a9f7b904ac3e22aef3872da9f7af1272d97/ash/wm/lock_action_handler_layout_manager_unittest.cc
[modify] https://crrev.com/fd1e1a9f7b904ac3e22aef3872da9f7af1272d97/ash/wm/lock_layout_manager_unittest.cc
[modify] https://crrev.com/fd1e1a9f7b904ac3e22aef3872da9f7af1272d97/ash/wm/overview/window_selector_controller_unittest.cc
[modify] https://crrev.com/fd1e1a9f7b904ac3e22aef3872da9f7af1272d97/ash/wm/pip/pip_positioner_unittest.cc
[modify] https://crrev.com/fd1e1a9f7b904ac3e22aef3872da9f7af1272d97/ash/wm/pip/pip_window_resizer_unittest.cc
[modify] https://crrev.com/fd1e1a9f7b904ac3e22aef3872da9f7af1272d97/ash/wm/system_modal_container_layout_manager_unittest.cc
[modify] https://crrev.com/fd1e1a9f7b904ac3e22aef3872da9f7af1272d97/ash/wm/window_animations_unittest.cc
[modify] https://crrev.com/fd1e1a9f7b904ac3e22aef3872da9f7af1272d97/ash/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/fd1e1a9f7b904ac3e22aef3872da9f7af1272d97/chrome/browser/about_flags.cc
[modify] https://crrev.com/fd1e1a9f7b904ac3e22aef3872da9f7af1272d97/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/fd1e1a9f7b904ac3e22aef3872da9f7af1272d97/chrome/browser/chromeos/extensions/default_keyboard_extension_browser_test.cc
[modify] https://crrev.com/fd1e1a9f7b904ac3e22aef3872da9f7af1272d97/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/fd1e1a9f7b904ac3e22aef3872da9f7af1272d97/chrome/browser/chromeos/input_method/input_method_engine_unittest.cc
[modify] https://crrev.com/fd1e1a9f7b904ac3e22aef3872da9f7af1272d97/chrome/browser/chromeos/login/kiosk_browsertest.cc
[modify] https://crrev.com/fd1e1a9f7b904ac3e22aef3872da9f7af1272d97/chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc
[modify] https://crrev.com/fd1e1a9f7b904ac3e22aef3872da9f7af1272d97/chrome/browser/extensions/chrome_component_extension_resource_manager.cc
[modify] https://crrev.com/fd1e1a9f7b904ac3e22aef3872da9f7af1272d97/chrome/browser/ui/ash/chrome_keyboard_controller_client.cc
[modify] https://crrev.com/fd1e1a9f7b904ac3e22aef3872da9f7af1272d97/chrome/browser/ui/ash/chrome_keyboard_web_contents.cc
[modify] https://crrev.com/fd1e1a9f7b904ac3e22aef3872da9f7af1272d97/chrome/browser/ui/ash/keyboard_controller_browsertest.cc
[modify] https://crrev.com/fd1e1a9f7b904ac3e22aef3872da9f7af1272d97/chrome/browser/ui/ash/keyboard_end_to_end_browsertest.cc
[modify] https://crrev.com/fd1e1a9f7b904ac3e22aef3872da9f7af1272d97/chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc
[modify] https://crrev.com/fd1e1a9f7b904ac3e22aef3872da9f7af1272d97/chrome/common/extensions/chrome_manifest_url_handlers.cc
[modify] https://crrev.com/fd1e1a9f7b904ac3e22aef3872da9f7af1272d97/ui/keyboard/BUILD.gn
[modify] https://crrev.com/fd1e1a9f7b904ac3e22aef3872da9f7af1272d97/ui/keyboard/keyboard_controller.cc
[modify] https://crrev.com/fd1e1a9f7b904ac3e22aef3872da9f7af1272d97/ui/keyboard/keyboard_util.cc
[rename] https://crrev.com/fd1e1a9f7b904ac3e22aef3872da9f7af1272d97/ui/keyboard/public/keyboard_switches.cc
[rename] https://crrev.com/fd1e1a9f7b904ac3e22aef3872da9f7af1272d97/ui/keyboard/public/keyboard_switches.h
[rename] https://crrev.com/fd1e1a9f7b904ac3e22aef3872da9f7af1272d97/ui/keyboard/resources/keyboard_resource_util.cc
[rename] https://crrev.com/fd1e1a9f7b904ac3e22aef3872da9f7af1272d97/ui/keyboard/resources/keyboard_resource_util.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34692a3358b79bba904117fac0aec3eab841e1e3

commit 34692a3358b79bba904117fac0aec3eab841e1e3
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Sat Nov 10 02:11:44 2018

Restrict ui/keyboard includes in src/chrome

This CL updates a couple of browser tests to use
ChromeKeyboardControllerClient instead of direct calls into
ui/keyboard to simplify DEPS exceptions.

Bug:  876138 
Change-Id: I7874cee278a3b9439efb4e4056390951eac6705c

For keyboard specific changes to c/b/policy and c/b/ui/views tests:
TBR=sky@chromium.org

Change-Id: I7874cee278a3b9439efb4e4056390951eac6705c
Reviewed-on: https://chromium-review.googlesource.com/c/1316248
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607073}
[modify] https://crrev.com/34692a3358b79bba904117fac0aec3eab841e1e3/chrome/browser/DEPS
[modify] https://crrev.com/34692a3358b79bba904117fac0aec3eab841e1e3/chrome/browser/chromeos/input_method/DEPS
[modify] https://crrev.com/34692a3358b79bba904117fac0aec3eab841e1e3/chrome/browser/extensions/api/virtual_keyboard_private/DEPS
[modify] https://crrev.com/34692a3358b79bba904117fac0aec3eab841e1e3/chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc
[modify] https://crrev.com/34692a3358b79bba904117fac0aec3eab841e1e3/chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.h
[modify] https://crrev.com/34692a3358b79bba904117fac0aec3eab841e1e3/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/34692a3358b79bba904117fac0aec3eab841e1e3/chrome/browser/ui/ash/DEPS
[modify] https://crrev.com/34692a3358b79bba904117fac0aec3eab841e1e3/chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc
[modify] https://crrev.com/34692a3358b79bba904117fac0aec3eab841e1e3/testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b751b6f31037e75eae9d85de7f12a06d149974b6

commit b751b6f31037e75eae9d85de7f12a06d149974b6
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Mon Nov 12 17:46:48 2018

Add ash.mojom.KeyboardController.GetEnableFlags

This CL introduces GetEnableFlags to the mojo API so that
GetKeyboardLayout can be moved from keyboard_util.cc/h to
chrome_virtual_keyboard_delegate.cc (the only place it was used).

It also moves the implementaiton of GetKeyboardWindow to
ChromeKeyboardControllerClient.

BUG= 876138 

Change-Id: I83bca47c9a038f9be2bb3322c5500996d898f21b
Reviewed-on: https://chromium-review.googlesource.com/c/1330327
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Shu Chen <shuchen@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607285}
[modify] https://crrev.com/b751b6f31037e75eae9d85de7f12a06d149974b6/ash/keyboard/ash_keyboard_controller.cc
[modify] https://crrev.com/b751b6f31037e75eae9d85de7f12a06d149974b6/ash/keyboard/ash_keyboard_controller.h
[modify] https://crrev.com/b751b6f31037e75eae9d85de7f12a06d149974b6/ash/keyboard/ash_keyboard_controller_unittest.cc
[modify] https://crrev.com/b751b6f31037e75eae9d85de7f12a06d149974b6/ash/public/interfaces/keyboard_controller.mojom
[modify] https://crrev.com/b751b6f31037e75eae9d85de7f12a06d149974b6/chrome/browser/chromeos/DEPS
[modify] https://crrev.com/b751b6f31037e75eae9d85de7f12a06d149974b6/chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc
[modify] https://crrev.com/b751b6f31037e75eae9d85de7f12a06d149974b6/chrome/browser/ui/ash/DEPS
[modify] https://crrev.com/b751b6f31037e75eae9d85de7f12a06d149974b6/chrome/browser/ui/ash/chrome_keyboard_controller_client.cc
[modify] https://crrev.com/b751b6f31037e75eae9d85de7f12a06d149974b6/chrome/browser/ui/ash/chrome_keyboard_controller_client.h
[modify] https://crrev.com/b751b6f31037e75eae9d85de7f12a06d149974b6/chrome/browser/ui/ash/chrome_keyboard_controller_client_test_helper.cc
[modify] https://crrev.com/b751b6f31037e75eae9d85de7f12a06d149974b6/ui/keyboard/keyboard_controller.h
[modify] https://crrev.com/b751b6f31037e75eae9d85de7f12a06d149974b6/ui/keyboard/keyboard_util.cc
[modify] https://crrev.com/b751b6f31037e75eae9d85de7f12a06d149974b6/ui/keyboard/keyboard_util.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/801c71c5733824192ee92c840828ebc1ea761166

commit 801c71c5733824192ee92c840828ebc1ea761166
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Tue Nov 13 19:09:08 2018

Add ash.mojom.KeyboardController.SetContainerType

This also introduces keyboard.mojom.ContainerType, replacing
keyboard::ContainerType.

BUG= 876138 

Change-Id: Ib09d9bfa6037b60381054dad8b68288dc73b832b
Reviewed-on: https://chromium-review.googlesource.com/c/1330328
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Shu Chen <shuchen@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607690}
[modify] https://crrev.com/801c71c5733824192ee92c840828ebc1ea761166/ash/keyboard/ash_keyboard_controller.cc
[modify] https://crrev.com/801c71c5733824192ee92c840828ebc1ea761166/ash/keyboard/ash_keyboard_controller.h
[modify] https://crrev.com/801c71c5733824192ee92c840828ebc1ea761166/ash/keyboard/ash_keyboard_controller_unittest.cc
[modify] https://crrev.com/801c71c5733824192ee92c840828ebc1ea761166/ash/keyboard/virtual_keyboard_unittest.cc
[modify] https://crrev.com/801c71c5733824192ee92c840828ebc1ea761166/ash/public/interfaces/keyboard_controller.mojom
[modify] https://crrev.com/801c71c5733824192ee92c840828ebc1ea761166/ash/shelf/shelf_widget_unittest.cc
[modify] https://crrev.com/801c71c5733824192ee92c840828ebc1ea761166/ash/system/status_area_widget_unittest.cc
[modify] https://crrev.com/801c71c5733824192ee92c840828ebc1ea761166/ash/system/virtual_keyboard/virtual_keyboard_tray_unittest.cc
[modify] https://crrev.com/801c71c5733824192ee92c840828ebc1ea761166/ash/wm/lock_layout_manager_unittest.cc
[modify] https://crrev.com/801c71c5733824192ee92c840828ebc1ea761166/ash/wm/pip/pip_positioner.cc
[modify] https://crrev.com/801c71c5733824192ee92c840828ebc1ea761166/ash/wm/pip/pip_positioner_unittest.cc
[modify] https://crrev.com/801c71c5733824192ee92c840828ebc1ea761166/ash/wm/pip/pip_window_resizer_unittest.cc
[modify] https://crrev.com/801c71c5733824192ee92c840828ebc1ea761166/ash/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/801c71c5733824192ee92c840828ebc1ea761166/chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc
[modify] https://crrev.com/801c71c5733824192ee92c840828ebc1ea761166/chrome/browser/ui/ash/chrome_keyboard_controller_client.cc
[modify] https://crrev.com/801c71c5733824192ee92c840828ebc1ea761166/chrome/browser/ui/ash/chrome_keyboard_controller_client.h
[modify] https://crrev.com/801c71c5733824192ee92c840828ebc1ea761166/chrome/browser/ui/ash/chrome_keyboard_controller_client_test_helper.cc
[modify] https://crrev.com/801c71c5733824192ee92c840828ebc1ea761166/chrome/browser/ui/ash/chrome_keyboard_ui.cc
[modify] https://crrev.com/801c71c5733824192ee92c840828ebc1ea761166/chrome/browser/ui/ash/keyboard_controller_browsertest.cc
[modify] https://crrev.com/801c71c5733824192ee92c840828ebc1ea761166/ui/keyboard/BUILD.gn
[modify] https://crrev.com/801c71c5733824192ee92c840828ebc1ea761166/ui/keyboard/container_behavior.h
[modify] https://crrev.com/801c71c5733824192ee92c840828ebc1ea761166/ui/keyboard/container_floating_behavior.cc
[modify] https://crrev.com/801c71c5733824192ee92c840828ebc1ea761166/ui/keyboard/container_floating_behavior.h
[modify] https://crrev.com/801c71c5733824192ee92c840828ebc1ea761166/ui/keyboard/container_full_width_behavior.cc
[modify] https://crrev.com/801c71c5733824192ee92c840828ebc1ea761166/ui/keyboard/container_full_width_behavior.h
[modify] https://crrev.com/801c71c5733824192ee92c840828ebc1ea761166/ui/keyboard/container_fullscreen_behavior.cc
[modify] https://crrev.com/801c71c5733824192ee92c840828ebc1ea761166/ui/keyboard/container_fullscreen_behavior.h
[delete] https://crrev.com/f6c1bcdfb273f5b8bc0e0975f96bf6720991c95b/ui/keyboard/container_type.h
[modify] https://crrev.com/801c71c5733824192ee92c840828ebc1ea761166/ui/keyboard/keyboard_controller.cc
[modify] https://crrev.com/801c71c5733824192ee92c840828ebc1ea761166/ui/keyboard/keyboard_controller.h
[modify] https://crrev.com/801c71c5733824192ee92c840828ebc1ea761166/ui/keyboard/keyboard_controller_unittest.cc
[rename] https://crrev.com/801c71c5733824192ee92c840828ebc1ea761166/ui/keyboard/public/keyboard_controller_types.mojom
[modify] https://crrev.com/801c71c5733824192ee92c840828ebc1ea761166/ui/keyboard/queued_container_type.cc
[modify] https://crrev.com/801c71c5733824192ee92c840828ebc1ea761166/ui/keyboard/queued_container_type.h
[modify] https://crrev.com/801c71c5733824192ee92c840828ebc1ea761166/ui/keyboard/queued_display_change.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf48f5dc97ffbfbabe94f28e778387697e657907

commit cf48f5dc97ffbfbabe94f28e778387697e657907
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri Nov 16 01:27:12 2018

Add SetKeyboardLocked and bounds setters to ash.mojom.KeyboardController

This CL updates the remaining ChromeVirtualKeyboardDelegate calls to use
ChromeKeyboardControllerClient instead of direct calls to
keyboard::KeyboardController.

This also adds OnKeyboardEnableFlagsChanged to ensure that the enable
flags are cached accurately on the chrome side.

Bug:  876138 
Change-Id: I3022fa78df7c589c22579b4b4e3b2a3279622f81
Reviewed-on: https://chromium-review.googlesource.com/c/1330894
Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608618}
[modify] https://crrev.com/cf48f5dc97ffbfbabe94f28e778387697e657907/ash/keyboard/ash_keyboard_controller.cc
[modify] https://crrev.com/cf48f5dc97ffbfbabe94f28e778387697e657907/ash/keyboard/ash_keyboard_controller.h
[modify] https://crrev.com/cf48f5dc97ffbfbabe94f28e778387697e657907/ash/keyboard/ash_keyboard_controller_unittest.cc
[modify] https://crrev.com/cf48f5dc97ffbfbabe94f28e778387697e657907/ash/public/interfaces/keyboard_controller.mojom
[modify] https://crrev.com/cf48f5dc97ffbfbabe94f28e778387697e657907/chrome/browser/extensions/api/virtual_keyboard_private/DEPS
[modify] https://crrev.com/cf48f5dc97ffbfbabe94f28e778387697e657907/chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc
[modify] https://crrev.com/cf48f5dc97ffbfbabe94f28e778387697e657907/chrome/browser/ui/ash/chrome_keyboard_controller_client.cc
[modify] https://crrev.com/cf48f5dc97ffbfbabe94f28e778387697e657907/chrome/browser/ui/ash/chrome_keyboard_controller_client.h
[modify] https://crrev.com/cf48f5dc97ffbfbabe94f28e778387697e657907/chrome/browser/ui/ash/chrome_keyboard_controller_client_test_helper.cc
[modify] https://crrev.com/cf48f5dc97ffbfbabe94f28e778387697e657907/ui/keyboard/container_behavior.h
[modify] https://crrev.com/cf48f5dc97ffbfbabe94f28e778387697e657907/ui/keyboard/container_floating_behavior.cc
[modify] https://crrev.com/cf48f5dc97ffbfbabe94f28e778387697e657907/ui/keyboard/container_floating_behavior.h
[modify] https://crrev.com/cf48f5dc97ffbfbabe94f28e778387697e657907/ui/keyboard/container_full_width_behavior.cc
[modify] https://crrev.com/cf48f5dc97ffbfbabe94f28e778387697e657907/ui/keyboard/container_full_width_behavior.h
[modify] https://crrev.com/cf48f5dc97ffbfbabe94f28e778387697e657907/ui/keyboard/keyboard_controller.cc
[modify] https://crrev.com/cf48f5dc97ffbfbabe94f28e778387697e657907/ui/keyboard/keyboard_controller.h
[modify] https://crrev.com/cf48f5dc97ffbfbabe94f28e778387697e657907/ui/keyboard/keyboard_controller_observer.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/844b16cb3ffca98127bf288a699854febce99e59

commit 844b16cb3ffca98127bf288a699854febce99e59
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri Nov 16 02:30:27 2018

Update keyboard browser tests  to use ChromeKeyboardControllerClient

This includes:
* keyboard_end_to_end_browsertest.cc
* keyboard_controller_browsertest.cc

Note: This renames the tests in keyboard_controller_browsertest from
VirtualKeyboard* to KeyboardController* to better match the file name
and the specific area of test focus.

This also contains some minor cleanup to keyboard::KeyboardController
that primarily impacts the in-progress SingleProcessMash implementation,
but should not affect the classic Ash implementation (except to clean
it up some). It is useful to isolate these changes from the larger CL
introducing AshKeyboardUI.

Bug:  876138 
Change-Id: I8aa7e5da1f04f0d8b17a58e9582608e6159bee29
Reviewed-on: https://chromium-review.googlesource.com/c/1336250
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Shu Chen <shuchen@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608638}
[modify] https://crrev.com/844b16cb3ffca98127bf288a699854febce99e59/chrome/browser/ui/ash/chrome_keyboard_controller_client.cc
[modify] https://crrev.com/844b16cb3ffca98127bf288a699854febce99e59/chrome/browser/ui/ash/chrome_keyboard_controller_client.h
[modify] https://crrev.com/844b16cb3ffca98127bf288a699854febce99e59/chrome/browser/ui/ash/chrome_keyboard_ui.cc
[modify] https://crrev.com/844b16cb3ffca98127bf288a699854febce99e59/chrome/browser/ui/ash/keyboard_controller_browsertest.cc
[modify] https://crrev.com/844b16cb3ffca98127bf288a699854febce99e59/chrome/browser/ui/ash/keyboard_end_to_end_browsertest.cc
[modify] https://crrev.com/844b16cb3ffca98127bf288a699854febce99e59/testing/buildbot/filters/chromeos.mash.fyi.browser_tests.filter
[modify] https://crrev.com/844b16cb3ffca98127bf288a699854febce99e59/testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter
[modify] https://crrev.com/844b16cb3ffca98127bf288a699854febce99e59/ui/keyboard/keyboard_util_unittest.cc
[modify] https://crrev.com/844b16cb3ffca98127bf288a699854febce99e59/ui/keyboard/test/keyboard_test_util.cc
[modify] https://crrev.com/844b16cb3ffca98127bf288a699854febce99e59/ui/keyboard/test/keyboard_test_util.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e3f087f9fff7b1ddef16e62faa99c53bfb86bc1

commit 5e3f087f9fff7b1ddef16e62faa99c53bfb86bc1
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Tue Dec 18 16:33:36 2018

Fix KeyboardControllerWebContentTest.CanDragFloatingKeyboardWithMouse

This test was over-enthusiastically updted to use
ChromeKeyboardControllerClient, however ui::test::EventGenerator does
not correctly proagate the drag event to the Ash window (and probably
should not be exected to). Switch to using keyboard::KeyboardController
for now instead.

Bug:  876138 
Change-Id: I30d7193e947cadbb3148c9aa192415b2f92d4e3c
Reviewed-on: https://chromium-review.googlesource.com/c/1380996
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617524}
[modify] https://crrev.com/5e3f087f9fff7b1ddef16e62faa99c53bfb86bc1/chrome/browser/ui/ash/keyboard/keyboard_controller_browsertest.cc
[modify] https://crrev.com/5e3f087f9fff7b1ddef16e62faa99c53bfb86bc1/testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter